Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache9 commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968400901 https://github.com/apache/hbase/commit/b3892cb3eb3c0073ae64da5704653aaef27bf37a There is an extra commit on that branch to skip all other checks :) It is not included in the

Re: [PR] HBASE-28404 Use "set -x" when running release script in debug mode [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5715: URL: https://github.com/apache/hbase/pull/5715#issuecomment-1968360748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28404 Use "set -x" when running release script in debug mode [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5715: URL: https://github.com/apache/hbase/pull/5715#issuecomment-1968359220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28404 Use "set -x" when running release script in debug mode [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5715: URL: https://github.com/apache/hbase/pull/5715#issuecomment-1968359015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28404 Use "set -x" when running release script in debug mode [hbase]

2024-02-27 Thread via GitHub
stoty commented on PR #5715: URL: https://github.com/apache/hbase/pull/5715#issuecomment-1968347640 FYI @ndimiduk @virajjasani @saintstack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (HBASE-28404) Use "set -x" when running release script in debug mode

2024-02-27 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth reassigned HBASE-28404: --- Assignee: Istvan Toth > Use "set -x" when running release script in debug mode >

[jira] [Updated] (HBASE-28404) Use "set -x" when running release script in debug mode

2024-02-27 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28404: Status: Patch Available (was: Open) > Use "set -x" when running release script in debug mode >

[jira] [Updated] (HBASE-28404) Use "set -x" when running release script in debug mode

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28404: --- Labels: pull-request-available (was: ) > Use "set -x" when running release script in debug

[PR] HBASE-28404 Use "set -x" when running release script in debug mode [hbase]

2024-02-27 Thread via GitHub
stoty opened a new pull request, #5715: URL: https://github.com/apache/hbase/pull/5715 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968344564 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968342245 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968342212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache9 commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968335523 The solution is to also build a hadoop3 tarball when doing source release, and then use it to run hadoop 3 related integration test. -- This is an automated message from the Apache Git

[jira] [Updated] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28384: --- Labels: pull-request-available (was: ) > Client ingegration tests fails for

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache9 commented on PR #5714: URL: https://github.com/apache/hbase/pull/5714#issuecomment-1968335032 https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-28384-branch-2/8/ Finally we passed the client integration test. -- This is an automated message from the Apache Git

[PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache9 opened a new pull request, #5714: URL: https://github.com/apache/hbase/pull/5714 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821524#comment-17821524 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #8 on

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821504#comment-17821504 ] Hudson commented on HBASE-28391: Results for branch branch-2.4 [build #701 on

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821496#comment-17821496 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #7 on

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821492#comment-17821492 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #6 on

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-27 Thread via GitHub
frostruan commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1504486835 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821489#comment-17821489 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #5 on

Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]

2024-02-27 Thread via GitHub
Apache9 commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505264727 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This

Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]

2024-02-27 Thread via GitHub
busbey commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505263844 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This

Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]

2024-02-27 Thread via GitHub
Apache9 commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505261164 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This

Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1967794800 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] Backport "HBASE-28379 Upgrade thirdparty dep to 4.1.6 (#5693)" to branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5710: URL: https://github.com/apache/hbase/pull/5710#issuecomment-1967763497 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1967685269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1967675730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] Backport "HBASE-28379 Upgrade thirdparty dep to 4.1.6 (#5693)" to branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5710: URL: https://github.com/apache/hbase/pull/5710#issuecomment-1967560346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821400#comment-17821400 ] Rushabh Shah commented on HBASE-28391: -- Thank you [~nihaljain.cs]  and [~zhangduo]  for the review.

[jira] [Resolved] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah resolved HBASE-28391. -- Fix Version/s: 2.6.0 2.4.18 4.0.0-alpha-1

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-27 Thread via GitHub
rmdmattingly commented on code in PR #5713: URL: https://github.com/apache/hbase/pull/5713#discussion_r1504733844 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -153,24 +175,60 @@ public void addMutation(final Mutation mutation) {

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:49 PM:

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:48 PM:

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:46 PM:

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:46 PM:

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:45 PM:

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell edited comment on HBASE-28405 at 2/27/24 5:45 PM:

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821361#comment-17821361 ] Andrew Kyle Purtell commented on HBASE-28405: - {quote}Maybe since region is online just

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821350#comment-17821350 ] Aman Poonia edited comment on HBASE-28405 at 2/27/24 5:23 PM: -- [~zhangduo]

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821350#comment-17821350 ] Aman Poonia edited comment on HBASE-28405 at 2/27/24 5:08 PM: -- [~zhangduo]

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821350#comment-17821350 ] Aman Poonia commented on HBASE-28405: - [~zhangduo] Thanks for the insight. {noformat} The logic at

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1967159348 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers [hbase]

2024-02-27 Thread via GitHub
shahrs87 merged PR #5695: URL: https://github.com/apache/hbase/pull/5695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers [hbase]

2024-02-27 Thread via GitHub
shahrs87 commented on code in PR #5695: URL: https://github.com/apache/hbase/pull/5695#discussion_r1504611977 ## hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java: ## @@ -1203,12 +1203,6 @@ public void

Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#issuecomment-1966996039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-28385) Quota estimates are too optimistic for large scans

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28385: --- Labels: pull-request-available (was: ) > Quota estimates are too optimistic for large

[PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-27 Thread via GitHub
rmdmattingly opened a new pull request, #5713: URL: https://github.com/apache/hbase/pull/5713 ## Background https://issues.apache.org/jira/browse/HBASE-28385 Let's say you're running a table scan with a throttle of 100MB/sec per RegionServer. Ideally your scans are going to

[jira] [Updated] (HBASE-28407) [thirdparty] Update release instructions

2024-02-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28407: - Status: Patch Available (was: Open) > [thirdparty] Update release instructions >

[PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]

2024-02-27 Thread via GitHub
ndimiduk opened a new pull request, #113: URL: https://github.com/apache/hbase-thirdparty/pull/113 @Apache9 @busbey This is the processes that I (eventually) sorted out. Does it look about right from your recollection? -- This is an automated message from the Apache Git Service. To

Re: [PR] Backport "HBASE-28379 Upgrade thirdparty dep to 4.1.6 (#5693)" to branch-2.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5710: URL: https://github.com/apache/hbase/pull/5710#issuecomment-1966922160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1966921294 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Created] (HBASE-28407) [thirdparty] Update release instructions

2024-02-27 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-28407: Summary: [thirdparty] Update release instructions Key: HBASE-28407 URL: https://issues.apache.org/jira/browse/HBASE-28407 Project: HBase Issue Type: Task

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1966895219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1966868699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

[jira] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-27 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399 ] ruanhui deleted comment on HBASE-28399: - was (Author: frostruan): HBASE-26609 may have solved this problem. A little strange Let me digger more > region size can be wrong from

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-27 Thread via GitHub
frostruan commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1504486835 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

[jira] [Commented] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-27 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821304#comment-17821304 ] ruanhui commented on HBASE-28399: - HBASE-26609 may have solved this problem. A little strange Let

[jira] [Commented] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821287#comment-17821287 ] Duo Zhang commented on HBASE-28399: --- In general, the precision we used to calcuate the store file size

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-27 Thread via GitHub
Apache9 commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1504404795 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-27 Thread via GitHub
Apache9 commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1504402271 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966711401 > 1. If it held 1, it would mean that regions that no longer exist would still get reported with size (maybe?) I don't think regions in state transition and regions no longer exist

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821259#comment-17821259 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #4 on

Re: [PR] HBASE-28149 move_servers_namespaces_rsgroup is not changing the new r… [hbase]

2024-02-27 Thread via GitHub
chrajeshbabu commented on PR #5661: URL: https://github.com/apache/hbase/pull/5661#issuecomment-1966574426 > > @Apache9 Thanks for response. Even I am thinking the same while moving namespaces to the new RS group would be better to have following options. > > ``` > > 1. **Move All

[jira] [Created] (HBASE-28406) Move namespace to RS group can support multiple options to move tables under it

2024-02-27 Thread Rajeshbabu Chintaguntla (Jira)
Rajeshbabu Chintaguntla created HBASE-28406: --- Summary: Move namespace to RS group can support multiple options to move tables under it Key: HBASE-28406 URL:

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821234#comment-17821234 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #3 on

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821232#comment-17821232 ] Duo Zhang commented on HBASE-28405: --- The logic at RS side is that, at the end of assign a region, it

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821231#comment-17821231 ] Duo Zhang commented on HBASE-28405: --- So the problem is that, we should not issue a TRSP if the region

[jira] [Comment Edited] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821227#comment-17821227 ] Aman Poonia edited comment on HBASE-28405 at 2/27/24 1:14 PM: -- If we had

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821227#comment-17821227 ] Aman Poonia commented on HBASE-28405: - If we had executed postDeploy here the region would have come

[jira] [Updated] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated HBASE-28405: Description: *We had a scenario in production where a merge operation had failed as below*

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966499225 I prefer to use 1 byte to represent unknown region size for two reasons: 1. it cannot be a valid region size because even a minimal keyvalue is bigger than that. 2. some

[jira] [Commented] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821214#comment-17821214 ] Aman Poonia commented on HBASE-28405: - Looking at the code comments it says that it might be a

[jira] [Updated] (HBASE-28405) Region open procedure silently returns without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated HBASE-28405: Summary: Region open procedure silently returns without notifying the parent proc (was: Region

[jira] [Created] (HBASE-28405) Region open procedure silently does nothing without notifying the parent proc

2024-02-27 Thread Aman Poonia (Jira)
Aman Poonia created HBASE-28405: --- Summary: Region open procedure silently does nothing without notifying the parent proc Key: HBASE-28405 URL: https://issues.apache.org/jira/browse/HBASE-28405 Project:

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
aalhour commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966464798 I'm wondering what the byte constant would hold, other than `0`: - If it held `1`, it would mean that regions that no longer exist would still get reported with size (maybe?) - I'm

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-02-27 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1504055111 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -78,7 +85,10 @@ public Thread newThread(Runnable r) { +

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1966353273 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966344106 Also ping Duo~ @Apache9 This problem is related to my PR you reviewed yesterday, would you mind taking a look at this too ? -- This is an automated message from the Apache Git

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966341246 I think there are two problems here: 1. For in-transition regions, the result of RegionLocation.getServerName() could be null. In the current PR, we just filter out these regions. With

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821185#comment-17821185 ] Hudson commented on HBASE-28384: Results for branch HBASE-28384-branch-2 [build #2 on

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-27 Thread via GitHub
aalhour commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966144703 @frostruan, which part of the code would handle that byte? Also, should that be added to this PR or yours (https://github.com/apache/hbase/pull/5700)? -- This is an automated message

[jira] [Work started] (HBASE-28354) RegionSizeCalculator throws NPE when regions are in transition

2024-02-27 Thread Ahmad Alhour (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28354 started by Ahmad Alhour. > RegionSizeCalculator throws NPE when regions are in transition >

Re: [PR] HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5695: URL: https://github.com/apache/hbase/pull/5695#issuecomment-1966130805 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers [hbase]

2024-02-27 Thread via GitHub
Apache-HBase commented on PR #5695: URL: https://github.com/apache/hbase/pull/5695#issuecomment-1966116522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers [hbase]

2024-02-27 Thread via GitHub
NihalJain commented on code in PR #5695: URL: https://github.com/apache/hbase/pull/5695#discussion_r1503858370 ## hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java: ## @@ -1203,12 +1203,6 @@ public void