Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
virajjasani commented on code in PR #5837: URL: https://github.com/apache/hbase/pull/5837#discussion_r1599411467 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java: ## @@ -70,6 +73,11 @@ class ZKConnectionRegistry implements

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109241221 We have this patch in our internal branch for a long time, and the effect is in line with expectations. So I think we can pick this up too. -- This is an automated message from the

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108938449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108931751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108889817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

[jira] [Commented] (HBASE-28581) Remove deprecated methods in TableDescriotorBuilder

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846078#comment-17846078 ] Hudson commented on HBASE-28581: Results for branch master [build #1071 on

[jira] [Commented] (HBASE-28576) Remove FirstKeyValueMatchingQualifiersFilter

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846077#comment-17846077 ] Hudson commented on HBASE-28576: Results for branch master [build #1071 on

[jira] [Commented] (HBASE-24791) Improve HFileOutputFormat2 to avoid always call getTableRelativePath method

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846071#comment-17846071 ] Hudson commented on HBASE-24791: Results for branch branch-2.5 [build #527 on

[jira] [Commented] (HBASE-28586) Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846070#comment-17846070 ] Hudson commented on HBASE-28586: Results for branch branch-2.5 [build #527 on

[jira] [Commented] (HBASE-28581) Remove deprecated methods in TableDescriotorBuilder

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846067#comment-17846067 ] Hudson commented on HBASE-28581: Results for branch branch-3 [build #204 on

[jira] [Commented] (HBASE-28576) Remove FirstKeyValueMatchingQualifiersFilter

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846066#comment-17846066 ] Hudson commented on HBASE-28576: Results for branch branch-3 [build #204 on

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108528810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108325553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108323241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108321888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108300478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s |

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
joshelser commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2108176794  sorry, I don't recall exactly what was being put into the incremental backups anymore. I remember holding on to all of the WAL files quickly got out of control and we talked about

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on code in PR #5876: URL: https://github.com/apache/hbase/pull/5876#discussion_r1598758193 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java: ## @@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108155158 > Test failure looks like a failure of the backup system. It's attempting to take an incremental backup, which assumes the existence of a WAL that no longer exists. The test harness

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2108125557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2108095534 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108092675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108090607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108081495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2108072939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108057539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2108035193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2108035051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
Apache9 commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2108018917 Have you faced this problem in your production? @bbeaudreault We can pick this up I think. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2108006254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
bcolyn-ngdata commented on code in PR #5867: URL: https://github.com/apache/hbase/pull/5867#discussion_r1598654473 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java: ## @@ -124,4 +128,44 @@ public void TestIncBackupMergeRestore() throws Exception

[jira] [Updated] (HBASE-25880) remove files from filesCompacting when clear compaction queues

2024-05-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-25880: --- Labels: pull-request-available (was: ) > remove files from filesCompacting when clear

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2107770254 Can we pick this back up? This is actually a big issue. If you clear compaction queues, you're almost guaranteed to enter a case where new compactions for those regions cannot

[jira] [Updated] (HBASE-28594) Add a new "Promoting Release Candidate" section to the book

2024-05-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28594: - Component/s: community > Add a new "Promoting Release Candidate" section to the book >

[jira] [Commented] (HBASE-28593) Update "Releasing Apache HBase" section in the book to document `do-release.sh`

2024-05-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845963#comment-17845963 ] Nick Dimiduk commented on HBASE-28593: -- I'm totally fine with keeping the instructions in the code

[jira] [Updated] (HBASE-28594) Add a new "Promoting Release Candidate" section to the book

2024-05-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28594: - Description: Once we have a release candidate voted on and approved by the PMC, the steps for

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on code in PR #5871: URL: https://github.com/apache/hbase/pull/5871#discussion_r1598573660 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java: ## @@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName

[jira] [Updated] (HBASE-28594) Add a new "Promoting Release Candidate" section to the book

2024-05-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28594: - Summary: Add a new "Promoting Release Candidate" section to the book (was: Add a new

[jira] [Created] (HBASE-28594) Add a new "Promoting Release Candidate"

2024-05-13 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-28594: Summary: Add a new "Promoting Release Candidate" Key: HBASE-28594 URL: https://issues.apache.org/jira/browse/HBASE-28594 Project: HBase Issue Type: Task

[jira] [Created] (HBASE-28593) Update "Releasing Apache HBase" section in the book to document `do-release.sh`

2024-05-13 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-28593: Summary: Update "Releasing Apache HBase" section in the book to document `do-release.sh` Key: HBASE-28593 URL: https://issues.apache.org/jira/browse/HBASE-28593

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2107727003 > Looks good to me. It would be good to solicit comments from whomever made the change that deprecated the old manifest logic in the first place. @DieterDP-ng do you know whom that

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache9 commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1598529826 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName)

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
2005hithlj commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107650319 The failed UT TestMasterRegionWALCleaner is not related to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2107452083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2107435722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2107405484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

[jira] [Work started] (HBASE-28592) Backport HBASE-26525 Use unique thread name for group WALs

2024-05-13 Thread Szucs Villo (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28592 started by Szucs Villo. --- > Backport HBASE-26525 Use unique thread name for group WALs >

[jira] [Updated] (HBASE-28592) Backport HBASE-26525 Use unique thread name for group WALs

2024-05-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28592: --- Labels: pull-request-available (was: ) > Backport HBASE-26525 Use unique thread name for

[jira] [Created] (HBASE-28592) Backport HBASE-26525 Use unique thread name for group WALs

2024-05-13 Thread Szucs Villo (Jira)
Szucs Villo created HBASE-28592: --- Summary: Backport HBASE-26525 Use unique thread name for group WALs Key: HBASE-28592 URL: https://issues.apache.org/jira/browse/HBASE-28592 Project: HBase

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107079527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107008756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2106990146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[jira] [Commented] (HBASE-28591) Backport HBASE-26123 Restore fields dropped by HBASE-25986 to public interfaces

2024-05-13 Thread Szucs Villo (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845815#comment-17845815 ] Szucs Villo commented on HBASE-28591: - Hi [~apurtell], What branches do you think this should be

[jira] [Created] (HBASE-28591) Backport HBASE-26123 Restore fields dropped by HBASE-25986 to public interfaces

2024-05-13 Thread Szucs Villo (Jira)
Szucs Villo created HBASE-28591: --- Summary: Backport HBASE-26123 Restore fields dropped by HBASE-25986 to public interfaces Key: HBASE-28591 URL: https://issues.apache.org/jira/browse/HBASE-28591

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-13 Thread via GitHub
ndimiduk commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106862711 +1 from my. Still, I would like to hear @anmolnar 's arguments against. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-28586) Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845801#comment-17845801 ] Hudson commented on HBASE-28586: Results for branch branch-2 [build #1054 on

[jira] [Commented] (HBASE-24791) Improve HFileOutputFormat2 to avoid always call getTableRelativePath method

2024-05-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845802#comment-17845802 ] Hudson commented on HBASE-24791: Results for branch branch-2 [build #1054 on