[jira] [Commented] (HBASE-21070) SnapshotFileCache won't update for snapshots stored in S3

2019-01-28 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754531#comment-16754531 ] Mingliang Liu commented on HBASE-21070: --- # The UT is simple but makes sure we don'

[jira] [Commented] (HBASE-21164) reportForDuty to spew less log if master is initializing

2019-02-20 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773472#comment-16773472 ] Mingliang Liu commented on HBASE-21164: --- Thanks for reporting this [~psomogyi]. Th

[jira] [Commented] (HBASE-21940) TestMasterShutdown fails on branch-1

2019-02-20 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773474#comment-16773474 ] Mingliang Liu commented on HBASE-21940: --- [~psomogyi] After I made a comment in the

[jira] [Updated] (HBASE-21164) reportForDuty to spew less log if master is initializing

2019-02-20 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21164: -- Attachment: HBASE-21164.branch-1.000.patch > reportForDuty to spew less log if master is initi

[jira] [Commented] (HBASE-21164) reportForDuty to spew less log if master is initializing

2019-02-20 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773547#comment-16773547 ] Mingliang Liu commented on HBASE-21164: --- Andrew, I uploaded that patch along with

[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-09 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904184#comment-16904184 ] Mingliang Liu commented on HBASE-22804: --- Nits: # {{regionMap}} is created at const

[jira] [Comment Edited] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-09 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904184#comment-16904184 ] Mingliang Liu edited comment on HBASE-22804 at 8/10/19 3:54 AM: --

[jira] [Assigned] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu reassigned HBASE-23283: - Assignee: Mingliang Liu > Provide clear and consistent logging about the period of enab

[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973086#comment-16973086 ] Mingliang Liu commented on HBASE-23283: --- Thanks, this makes sense. Unless you are

[jira] [Updated] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23283: -- Attachment: HBASE-23283.000.patch > Provide clear and consistent logging about the period of e

[jira] [Updated] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23283: -- Status: Patch Available (was: Open) > Provide clear and consistent logging about the period o

[jira] [Created] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
Mingliang Liu created HBASE-23284: - Summary: Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support" Key: HBASE-23284 URL: https://issues.apache.org/jira/browse/HBASE-23284 P

[jira] [Updated] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23284: -- Affects Version/s: 3.0.0 > Fix Hadoop wiki link in Developer guide to "Distributions and Comme

[jira] [Updated] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23284: -- Issue Type: Task (was: New Feature) > Fix Hadoop wiki link in Developer guide to "Distributio

[jira] [Updated] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23284: -- Attachment: HBASE-23284.000.patch > Fix Hadoop wiki link in Developer guide to "Distributions

[jira] [Updated] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23284: -- Status: Patch Available (was: Open) > Fix Hadoop wiki link in Developer guide to "Distributio

[jira] [Commented] (HBASE-23284) Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973124#comment-16973124 ] Mingliang Liu commented on HBASE-23284: --- Ping [~stack] and [~ndimiduk]. Thanks, >

[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973649#comment-16973649 ] Mingliang Liu commented on HBASE-23283: --- [[~busbey]I don't have commit access so

[jira] [Assigned] (HBASE-23289) Update book links to Hadoop wiki

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu reassigned HBASE-23289: - Assignee: Mingliang Liu > Update book links to Hadoop wiki > --

[jira] [Commented] (HBASE-23289) Update book links to Hadoop wiki

2019-11-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973654#comment-16973654 ] Mingliang Liu commented on HBASE-23289: --- Thanks for filing this [~ndimiduk] On the

[jira] [Updated] (HBASE-23290) shell processlist command is broken

2019-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23290: -- Attachment: HBASE-23290.000.patch Assignee: Mingliang Liu Status: Patch Available

[jira] [Updated] (HBASE-23290) shell processlist command is broken

2019-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23290: -- Attachment: Screen Shot 2019-11-14 at 1.56.00 AM.png > shell processlist command is broken > -

[jira] [Comment Edited] (HBASE-23290) shell processlist command is broken

2019-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974109#comment-16974109 ] Mingliang Liu edited comment on HBASE-23290 at 11/14/19 8:20 PM: -

[jira] [Commented] (HBASE-23290) shell processlist command is broken

2019-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974583#comment-16974583 ] Mingliang Liu commented on HBASE-23290: --- Thanks [~stack]. Yes I think this should

[jira] [Comment Edited] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

2019-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973649#comment-16973649 ] Mingliang Liu edited comment on HBASE-23283 at 11/15/19 12:58 AM:

[jira] [Updated] (HBASE-23289) Update book links to Hadoop wiki

2019-11-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23289: -- Attachment: HBASE-23289.000.patch > Update book links to Hadoop wiki > ---

[jira] [Updated] (HBASE-23289) Update links to Hadoop wiki in code and book

2019-11-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23289: -- Summary: Update links to Hadoop wiki in code and book (was: Update book links to Hadoop wiki)

[jira] [Commented] (HBASE-23289) Update book links to Hadoop wiki

2019-11-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975931#comment-16975931 ] Mingliang Liu commented on HBASE-23289: --- The v0 patch fixes all links I found (usi

[jira] [Updated] (HBASE-23289) Update links to Hadoop wiki in code and book

2019-11-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23289: -- Status: Patch Available (was: Open) > Update links to Hadoop wiki in code and book >

[jira] [Updated] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-18 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23314: -- Issue Type: Improvement (was: New Feature) > Make HBaseObjectStoreSemantics FilterFileSystem

[jira] [Created] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-18 Thread Mingliang Liu (Jira)
Mingliang Liu created HBASE-23314: - Summary: Make HBaseObjectStoreSemantics FilterFileSystem Key: HBASE-23314 URL: https://issues.apache.org/jira/browse/HBASE-23314 Project: HBase Issue Type:

[jira] [Commented] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-18 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976958#comment-16976958 ] Mingliang Liu commented on HBASE-23314: --- [~wchevreuil], [~mackrorysd] and [~ste...

[jira] [Updated] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-18 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-23314: -- Status: Patch Available (was: Open) > Make HBaseObjectStoreSemantics FilterFileSystem > -

[jira] [Commented] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-19 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977647#comment-16977647 ] Mingliang Liu commented on HBASE-23314: --- Thank you very much for prompt review and

[jira] [Comment Edited] (HBASE-23314) Make HBaseObjectStoreSemantics FilterFileSystem

2019-11-19 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977647#comment-16977647 ] Mingliang Liu edited comment on HBASE-23314 at 11/19/19 5:29 PM: -

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2019-11-20 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978200#comment-16978200 ] Mingliang Liu commented on HBASE-23313: --- {quote} Better if the setRegionState just

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-11-20 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978218#comment-16978218 ] Mingliang Liu commented on HBASE-22607: --- I see this still happens now, see https:

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2019-11-20 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978248#comment-16978248 ] Mingliang Liu commented on HBASE-23313: --- > I don't see an RPC for this now, I gues

[jira] [Updated] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-22607: -- Attachment: HBASE-22607.addendum.000.patch > TestExportSnapshotNoCluster::testSnapshotWithRefs

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995257#comment-16995257 ] Mingliang Liu commented on HBASE-22607: --- [~AK2019] That is interesting. Can you r

[jira] [Comment Edited] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995257#comment-16995257 ] Mingliang Liu edited comment on HBASE-22607 at 12/13/19 1:16 AM: -

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-12 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995347#comment-16995347 ] Mingliang Liu commented on HBASE-22607: --- [~AK2019] Could you share the command to

[jira] [Created] (HBASE-23574) TestFixKerberosTicketOrder fails intermittently

2019-12-12 Thread Mingliang Liu (Jira)
Mingliang Liu created HBASE-23574: - Summary: TestFixKerberosTicketOrder fails intermittently Key: HBASE-23574 URL: https://issues.apache.org/jira/browse/HBASE-23574 Project: HBase Issue Type:

[jira] [Updated] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-22607: -- Attachment: HBASE-22607.addendum.001.patch > TestExportSnapshotNoCluster::testSnapshotWithRefs

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995824#comment-16995824 ] Mingliang Liu commented on HBASE-22607: --- [~AK2019] Thanks for providing more conte

[jira] [Updated] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-22607: -- Attachment: HBASE-22607.addendum.002.patch > TestExportSnapshotNoCluster::testSnapshotWithRefs

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998453#comment-16998453 ] Mingliang Liu commented on HBASE-22607: --- Thanks for confirming, [~AK2019]. The pre

[jira] [Comment Edited] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998453#comment-16998453 ] Mingliang Liu edited comment on HBASE-22607 at 12/17/19 6:21 PM: -

[jira] [Commented] (HBASE-23366) Test failure due to flaky tests on ppc64le

2019-12-18 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999592#comment-16999592 ] Mingliang Liu commented on HBASE-23366: --- [~AK2019] I'm not seeing this errors in o

[jira] [Commented] (HBASE-21070) SnapshotFileCache won't update for snapshots stored in S3

2019-01-16 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744323#comment-16744323 ] Mingliang Liu commented on HBASE-21070: --- I myself has been working on something el

[jira] [Updated] (HBASE-21071) HBaseTestingUtility::startMiniCluster() to use builder pattern

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21071: -- Labels: reviewed (was: ) > HBaseTestingUtility::startMiniCluster() to use builder pattern > -

[jira] [Commented] (HBASE-21071) HBaseTestingUtility::startMiniCluster() to use builder pattern

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593998#comment-16593998 ] Mingliang Liu commented on HBASE-21071: --- Thank you very much [~stack], [~yuzhih...

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594103#comment-16594103 ] Mingliang Liu commented on HBASE-21098: --- Interesting work. I'll review this week.

[jira] [Commented] (HBASE-20642) IntegrationTestDDLMasterFailover throws 'InvalidFamilyOperationException

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594362#comment-16594362 ] Mingliang Liu commented on HBASE-20642: --- Thanks [~an...@apache.org]. After discuss

[jira] [Commented] (HBASE-21070) SnapshotFileCache won't update for snapshots stored in S3

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594402#comment-16594402 ] Mingliang Liu commented on HBASE-21070: --- The patch looks good to me overall to rem

[jira] [Commented] (HBASE-21070) SnapshotFileCache won't update for snapshots stored in S3

2018-08-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594403#comment-16594403 ] Mingliang Liu commented on HBASE-21070: --- Last, I think it might be helpful to add

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-28 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595658#comment-16595658 ] Mingliang Liu commented on HBASE-21098: --- I did not finish, but my review is not bi

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-28 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595734#comment-16595734 ] Mingliang Liu commented on HBASE-21098: --- Making temporary directory for snapshort

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598105#comment-16598105 ] Mingliang Liu commented on HBASE-21098: --- Thanks [~mtylr] for updating the patch. N

[jira] [Updated] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21098: -- Affects Version/s: 1.4.8 > Improve Snapshot Performance with Temporary Snapshot Directory when

[jira] [Comment Edited] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598105#comment-16598105 ] Mingliang Liu edited comment on HBASE-21098 at 8/31/18 1:31 AM: --

[jira] [Assigned] (HBASE-20430) Improve store file management for non-HDFS filesystems

2018-08-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu reassigned HBASE-20430: - Assignee: Mingliang Liu > Improve store file management for non-HDFS filesystems >

[jira] [Commented] (HBASE-21070) SnapshotFileCache won't update for snapshots stored in S3

2018-08-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598122#comment-16598122 ] Mingliang Liu commented on HBASE-21070: --- Thanks [~zyork]. If all access methods ar

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.000.patch > Close HRegion instance at the end of every test in TestHRe

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599327#comment-16599327 ] Mingliang Liu commented on HBASE-21138: --- [~yuzhih...@gmail.com] is closing in {{@A

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Assignee: Mingliang Liu Status: Patch Available (was: Open) > Close HRegion instance at

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599527#comment-16599527 ] Mingliang Liu commented on HBASE-21138: --- {quote} We should keep the same behavior.

[jira] [Comment Edited] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599527#comment-16599527 ] Mingliang Liu edited comment on HBASE-21138 at 9/1/18 4:37 AM: ---

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-04 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603848#comment-16603848 ] Mingliang Liu commented on HBASE-21098: --- {quote} For TestSnapshotDFSTemporaryDirec

[jira] [Comment Edited] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-04 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598105#comment-16598105 ] Mingliang Liu edited comment on HBASE-21098 at 9/5/18 2:41 AM: ---

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-04 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.001.patch > Close HRegion instance at the end of every test in TestHRe

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-04 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603884#comment-16603884 ] Mingliang Liu commented on HBASE-21138: --- According to our discussion, submit [^HBA

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604737#comment-16604737 ] Mingliang Liu commented on HBASE-21138: --- Thanks [~yuzhih...@gmail.com]. That was t

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.002.patch > Close HRegion instance at the end of every test in TestHRe

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.003.patch > Close HRegion instance at the end of every test in TestHRe

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605068#comment-16605068 ] Mingliang Liu commented on HBASE-21098: --- Thanks [~mtylr]. I guess my suggestion is

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605082#comment-16605082 ] Mingliang Liu commented on HBASE-21138: --- Thanks, Ted. I will provide a branch-1 pa

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.branch-1.004.patch > Close HRegion instance at the end of every test i

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.004.patch > Close HRegion instance at the end of every test in TestHRe

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606428#comment-16606428 ] Mingliang Liu commented on HBASE-21098: --- I think if we bring back the {{FS.equals(

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.branch-2.004.patch > Close HRegion instance at the end of every test i

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606435#comment-16606435 ] Mingliang Liu commented on HBASE-21138: --- Thanks [~yuzhih...@gmail.com]. I have upl

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21138: -- Attachment: HBASE-21138.branch-1.004.patch > Close HRegion instance at the end of every test i

[jira] [Assigned] (HBASE-21164) reportForDuty should do backoff rather than retry every 3 seconds (default).

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu reassigned HBASE-21164: - Assignee: Mingliang Liu > reportForDuty should do backoff rather than retry every 3 sec

[jira] [Commented] (HBASE-21164) reportForDuty should do backoff rather than retry every 3 seconds (default).

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606460#comment-16606460 ] Mingliang Liu commented on HBASE-21164: --- Picking it up. Feel free to re-assign. >

[jira] [Commented] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606499#comment-16606499 ] Mingliang Liu commented on HBASE-21164: --- Yes, sir. I was thinking small jitter in

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606610#comment-16606610 ] Mingliang Liu commented on HBASE-21138: --- Thanks for helpful review comments, and c

[jira] [Commented] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606733#comment-16606733 ] Mingliang Liu commented on HBASE-21164: --- The v1 patch looks good to me (non-bindin

[jira] [Updated] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21164: -- Attachment: HBASE-21164.branch-2.1.002.patch > reportForDuty should do (expotential) backoff r

[jira] [Commented] (HBASE-21168) BloomFilterUtil uses hardcoded randomness

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607454#comment-16607454 ] Mingliang Liu commented on HBASE-21168: --- +1 (non-binding) Nits nits: {{setFakeLoo

[jira] [Commented] (HBASE-21168) BloomFilterUtil uses hardcoded randomness

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607638#comment-16607638 ] Mingliang Liu commented on HBASE-21168: --- Perfect! > BloomFilterUtil uses hardcode

[jira] [Commented] (HBASE-21001) ReplicationObserver fails to load in HBase 2.0.0

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607648#comment-16607648 ] Mingliang Liu commented on HBASE-21001: --- Nit: we don't need to call {{region.close

[jira] [Commented] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607706#comment-16607706 ] Mingliang Liu commented on HBASE-21164: --- Thanks [~stack]. I revised the test a lit

[jira] [Updated] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21164: -- Attachment: HBASE-21164.branch-2.1.003.patch > reportForDuty should do (expotential) backoff r

[jira] [Updated] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21164: -- Attachment: HBASE-21164.branch-2.1.004.patch > reportForDuty should do (expotential) backoff r

[jira] [Commented] (HBASE-21164) reportForDuty should do (expotential) backoff rather than retry every 3 seconds (default).

2018-09-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607757#comment-16607757 ] Mingliang Liu commented on HBASE-21164: --- Patch v4 to fix checkstyle warning. Faili

[jira] [Created] (HBASE-21170) Backport HBASE-20642 to branch-1: Clients should re-use the same nonce across DDL operations

2018-09-07 Thread Mingliang Liu (JIRA)
Mingliang Liu created HBASE-21170: - Summary: Backport HBASE-20642 to branch-1: Clients should re-use the same nonce across DDL operations Key: HBASE-21170 URL: https://issues.apache.org/jira/browse/HBASE-21170

[jira] [Commented] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

2018-09-08 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608149#comment-16608149 ] Mingliang Liu commented on HBASE-21173: ---  Thanks for working on this JIRA, [~andre

[jira] [Commented] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

2018-09-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609627#comment-16609627 ] Mingliang Liu commented on HBASE-21173: --- +1 (non-binding) Thanks for updating th

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609646#comment-16609646 ] Mingliang Liu commented on HBASE-21098: --- (again) +1 (non-binding) as my previous c

  1   2   3   >