[jira] [Commented] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580173#comment-16580173 ] Ted Yu commented on HBASE-21042: [~tdsilva]: Is the patch good by you ? [~chia7712]: Please also take a

[jira] [Commented] (HBASE-21040) Replace call to printStackTrace() with proper logger call

2018-08-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579873#comment-16579873 ] Ted Yu commented on HBASE-21040: For ClientAsyncPrefetchScanner.java and

[jira] [Commented] (HBASE-21041) Memstore's heap size will be decreased to minus zero after flush

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579247#comment-16579247 ] Ted Yu commented on HBASE-21041: Looks good overall. {code} +// Record the MutableSegment' heap

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579191#comment-16579191 ] Ted Yu commented on HBASE-19008: [~liuml07]: Can you see if your comments have been addressed ? > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579178#comment-16579178 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you see if your comments have been addressed ? > Add

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579173#comment-16579173 ] Ted Yu commented on HBASE-20968: Verified locally that the fix allows list_procedures_test to pass. >

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Attachment: 21042.branch-1.txt > processor.getRowsToLock() always assumes there is some row being locked in

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Attachment: (was: 21042.branch-1.txt) > processor.getRowsToLock() always assumes there is some row

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Attachment: 21042.branch-1.txt > processor.getRowsToLock() always assumes there is some row being locked in

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Fix Version/s: 1.4.7 > processor.getRowsToLock() always assumes there is some row being locked in >

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Status: Patch Available (was: Open) > processor.getRowsToLock() always assumes there is some row being

[jira] [Commented] (HBASE-18998) processor.getRowsToLock() always assumes there is some row being locked

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579123#comment-16579123 ] Ted Yu commented on HBASE-18998: Logged HBASE-21042 with patch coming soon. > processor.getRowsToLock()

[jira] [Created] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-13 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21042: -- Summary: processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks Key: HBASE-21042 URL: https://issues.apache.org/jira/browse/HBASE-21042

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578912#comment-16578912 ] Ted Yu commented on HBASE-19008: Please fix 8 checkstyle warnings in hbase-server module, 3 in

[jira] [Updated] (HBASE-20257) hbase-spark should not depend on com.google.code.findbugs.jsr305

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20257: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Updated] (HBASE-21040) Replace call to printStackTrace() with proper logger call

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21040: --- Description: Here is related code: {code}

[jira] [Updated] (HBASE-21040) Replace call to printStackTrace() with proper logger call

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21040: --- Summary: Replace call to printStackTrace() with proper logger call (was: printStackTrace() is used in

[jira] [Comment Edited] (HBASE-21040) printStackTrace() is used in RestoreDriver in case Exception is caught

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577906#comment-16577906 ] Ted Yu edited comment on HBASE-21040 at 8/13/18 4:32 PM: - Should be fine. Can

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578406#comment-16578406 ] Ted Yu commented on HBASE-20734: Agree with implementing existence check per region. > Colocate

[jira] [Commented] (HBASE-21040) printStackTrace() is used in RestoreDriver in case Exception is caught

2018-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577906#comment-16577906 ] Ted Yu commented on HBASE-21040: Should be fine. Can you look at similar calls in non-test code ? >

[jira] [Created] (HBASE-21040) printStackTrace() is used in RestoreDriver in case Exception is caught

2018-08-12 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21040: -- Summary: printStackTrace() is used in RestoreDriver in case Exception is caught Key: HBASE-21040 URL: https://issues.apache.org/jira/browse/HBASE-21040 Project: HBase

[jira] [Updated] (HBASE-21038) SAXParseException when hbase.spark.use.hbasecontext=false

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21038: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21038) SAXParseException when hbase.spark.use.hbasecontext=false

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577648#comment-16577648 ] Ted Yu commented on HBASE-21038: >From https://builds.apache.org/job/PreCommit-HBASE-Build/14014/console

[jira] [Assigned] (HBASE-21038) SAXParseException when hbase.spark.use.hbasecontext=false

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21038: -- Assignee: Ajith S > SAXParseException when hbase.spark.use.hbasecontext=false >

[jira] [Updated] (HBASE-21038) SAXParseException when hbase.spark.use.hbasecontext=false

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21038: --- Status: Patch Available (was: Open) > SAXParseException when hbase.spark.use.hbasecontext=false >

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577592#comment-16577592 ] Ted Yu commented on HBASE-21031: Looks good overall. > Memory leak if replay edits failed during

[jira] [Commented] (HBASE-21038) SAXParseException when hbase.spark.use.hbasecontext=false

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577515#comment-16577515 ] Ted Yu commented on HBASE-21038: is it possible to add a test showing the problem without the fix ? >

[jira] [Updated] (HBASE-19257) Document tool to dump information from MasterProcWALs file

2018-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19257: --- Labels: document (was: ) > Document tool to dump information from MasterProcWALs file >

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576643#comment-16576643 ] Ted Yu commented on HBASE-20917: [~xucang]: Can you take a look at the addendum ? thanks >

[jira] [Updated] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20917: --- Attachment: 20917.addendum > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576494#comment-16576494 ] Ted Yu commented on HBASE-21031: Can you come up with a test which fails if {{dropMemStoreContents}}

[jira] [Comment Edited] (HBASE-21029) Miscount of memstore's heap/offheap size if same cell was put

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576479#comment-16576479 ] Ted Yu edited comment on HBASE-21029 at 8/10/18 3:59 PM: - I applied the test

[jira] [Commented] (HBASE-21029) Miscount of memstore's heap/offheap size if same cell was put

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576479#comment-16576479 ] Ted Yu commented on HBASE-21029: I applied the test change only and ran:

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576466#comment-16576466 ] Ted Yu commented on HBASE-21031: I modified the dropMemStoreContents() method by passing it the region

[jira] [Assigned] (HBASE-21030) Correct javadoc for append operation

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21030: -- Assignee: Subrat Mishra > Correct javadoc for append operation >

[jira] [Commented] (HBASE-21011) Provide CLI option to run oldwals and hfiles cleaner separately when cleaner chore is disabled

2018-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575733#comment-16575733 ] Ted Yu commented on HBASE-21011: I may not have time to fully digest the proposal here. The scenario

[jira] [Commented] (HBASE-20943) Add offline/online region count into metrics

2018-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575127#comment-16575127 ] Ted Yu commented on HBASE-20943: lgtm > Add offline/online region count into metrics >

[jira] [Commented] (HBASE-20943) Add offline/online region count into metrics

2018-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574996#comment-16574996 ] Ted Yu commented on HBASE-20943: Looks good overall. {code} + PairOfSameType getRegionNumbers(); {code}

[jira] [Commented] (HBASE-21021) Result returned by Append operation should be ordered

2018-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574984#comment-16574984 ] Ted Yu commented on HBASE-21021: [~allan163]: What do you think of Nihal's comment above ? > Result

[jira] [Commented] (HBASE-20995) Clean Up Manual Array Copies, trivial

2018-08-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573875#comment-16573875 ] Ted Yu commented on HBASE-20995: For the change in HBaseAdmin: {code} 835 if (startKeys.length

[jira] [Updated] (HBASE-21026) Fix Backup/Restore command usage bug in book

2018-08-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21026: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21026) Fix Backup/Restore command usage bug in book

2018-08-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573662#comment-16573662 ] Ted Yu commented on HBASE-21026: +1 > Fix Backup/Restore command usage bug in book >

[jira] [Assigned] (HBASE-21018) RS crashed because AsyncFS was unable to update HDFS data encryption key

2018-08-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21018: -- Assignee: Wei-Chiu Chuang > RS crashed because AsyncFS was unable to update HDFS data encryption key

[jira] [Commented] (HBASE-21024) Add RSgroup info for Region Servers and Tables

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572614#comment-16572614 ] Ted Yu commented on HBASE-21024: Seems interesting. Want to attach a patch ? > Add RSgroup info for

[jira] [Commented] (HBASE-20943) Add offline/online region count into metrics

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572540#comment-16572540 ] Ted Yu commented on HBASE-20943: {code} 60String ONLINE_REGION_NUMBER_NAME =

[jira] [Updated] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20968: --- Attachment: 20968.v2.txt > list_procedures_test fails due to no matching regex >

[jira] [Updated] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20968: --- Attachment: (was: 20968.v1.txt) > list_procedures_test fails due to no matching regex >

[jira] [Updated] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20968: --- Attachment: 20968.v1.txt > list_procedures_test fails due to no matching regex >

[jira] [Updated] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20968: --- Status: Patch Available (was: Open) > list_procedures_test fails due to no matching regex >

[jira] [Assigned] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-20968: -- Assignee: Ted Yu > list_procedures_test fails due to no matching regex >

[jira] [Commented] (HBASE-20988) TestShell shouldn't be skipped for hbase-shell module test

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572463#comment-16572463 ] Ted Yu commented on HBASE-20988: If TestShell is skipped, QA bot shouldn't state: bq. hbase-shell in

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572092#comment-16572092 ] Ted Yu commented on HBASE-19008: [~reidchan] [~Jan Hentschel]: Can you take a look ? > Add missing

[jira] [Commented] (HBASE-21018) RS crashed because AsyncFS was unable to update HDFS data encryption key

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572082#comment-16572082 ] Ted Yu commented on HBASE-21018: +1 > RS crashed because AsyncFS was unable to update HDFS data

[jira] [Updated] (HBASE-21018) RS crashed because AsyncFS was unable to update HDFS data encryption key

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21018: --- Status: Patch Available (was: Open) > RS crashed because AsyncFS was unable to update HDFS data encryption

[jira] [Commented] (HBASE-21021) Result returned by Append operation should be ordered

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571906#comment-16571906 ] Ted Yu commented on HBASE-21021: The test on master branch fails too: {code}

[jira] [Assigned] (HBASE-20943) Add offline/online region count into metrics

2018-08-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-20943: -- Assignee: jinghan xu > Add offline/online region count into metrics >

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570582#comment-16570582 ] Ted Yu commented on HBASE-20997: Focusing this JIRA on branch-1.x is fine. > rebuildUserRegions() does

[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570012#comment-16570012 ] Ted Yu edited comment on HBASE-19008 at 8/6/18 10:33 AM: - Please fix the

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570012#comment-16570012 ] Ted Yu commented on HBASE-19008: Please fix the following compilation errors: {code} [ERROR]

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569512#comment-16569512 ] Ted Yu commented on HBASE-20997: Can you refactor the test to fit master branch ? It would be good to

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569214#comment-16569214 ] Ted Yu commented on HBASE-20997: Looks like the new test needs a little refactoring for master branch:

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569001#comment-16569001 ] Ted Yu commented on HBASE-20997: +1 > rebuildUserRegions() does not build ReplicaMapping during master

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568991#comment-16568991 ] Ted Yu commented on HBASE-20997: Looks good overall. Please drop the table at the end of the test. >

[jira] [Commented] (HBASE-20257) hbase-spark should not depend on com.google.code.findbugs.jsr305

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568865#comment-16568865 ] Ted Yu commented on HBASE-20257: Ping [~busbey] > hbase-spark should not depend on

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568844#comment-16568844 ] Ted Yu commented on HBASE-20997: I ran the test which took ~30 seconds. {code} + @Test(timeout =

[jira] [Commented] (HBASE-21003) Fix the flaky TestSplitOrMergeStatus

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568418#comment-16568418 ] Ted Yu commented on HBASE-21003: Makes sense. bq. except split success I guess you mean 'expect the

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568394#comment-16568394 ] Ted Yu commented on HBASE-19008: {code} [ERROR]

[jira] [Commented] (HBASE-20972) Fix call queue buffer size leaking bug

2018-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568246#comment-16568246 ] Ted Yu commented on HBASE-20972: Looks good overall {code} 229 protected void resetCallQueueSize()

[jira] [Commented] (HBASE-20997) rebuildUserRegions() does not build ReplicaMapping during master switchover

2018-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567678#comment-16567678 ] Ted Yu commented on HBASE-20997: lgtm > rebuildUserRegions() does not build ReplicaMapping during

[jira] [Commented] (HBASE-20940) HStore.cansplit should not allow split to happen if it has references

2018-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566680#comment-16566680 ] Ted Yu commented on HBASE-20940: {code} 492 e.printStackTrace(); {code} The above seems to

[jira] [Commented] (HBASE-20940) HStore.cansplit should not allow split to happen if it has references

2018-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566681#comment-16566681 ] Ted Yu commented on HBASE-20940: [~stack]: Can you take a look as well ? Thanks > HStore.cansplit

[jira] [Updated] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19036: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 1.5.0

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566671#comment-16566671 ] Ted Yu commented on HBASE-19036: nit: [PATCH] is repeated in patch subject line. Corrected when

[jira] [Commented] (HBASE-20985) add two attributes when we do normalization

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566268#comment-16566268 ] Ted Yu commented on HBASE-20985: I may not have time to do a thorough review. You can ask other

[jira] [Commented] (HBASE-20894) Move BucketCache from java serialization to protobuf

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566034#comment-16566034 ] Ted Yu commented on HBASE-20894: No additional comment. > Move BucketCache from java serialization to

[jira] [Updated] (HBASE-20729) B BackupLogCleaner must ignore ProcV2 WAL files

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20729: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-20975) Lock may not be taken or released while rolling back procedure

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565470#comment-16565470 ] Ted Yu commented on HBASE-20975: +1 > Lock may not be taken or released while rolling back procedure >

[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565142#comment-16565142 ] Ted Yu edited comment on HBASE-19008 at 8/1/18 1:40 PM: Liubang: Can you change

[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19008: --- Attachment: HBASE-19008.patch > Add missing equals or hashCode method(s) to stock Filter implementations >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565163#comment-16565163 ] Ted Yu commented on HBASE-19008: Liubang: Can you add the two methods to RowFilter.java ? Thanks > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565142#comment-16565142 ] Ted Yu commented on HBASE-19008: Liubang: Can you attach the patch here for QA run ? thanks > Add

[jira] [Commented] (HBASE-20729) B BackupLogCleaner must ignore ProcV2 WAL files

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564575#comment-16564575 ] Ted Yu commented on HBASE-20729: One comment: {code} logList = excludeAlreadyBackedUpWALs(logList,

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564417#comment-16564417 ] Ted Yu commented on HBASE-19036: {code} [ERROR]

[jira] [Updated] (HBASE-20950) Helper method to configure secure DFS cluster for tests

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20950: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 3.0.0

[jira] [Updated] (HBASE-20988) TestShell shouldn't be skipped for hbase-shell module test

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20988: --- Description: Here is snippet for QA run 13862 for HBASE-20985 : {code} 13:42:50 cd

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564053#comment-16564053 ] Ted Yu commented on HBASE-19036: https://builds.apache.org/job/PreCommit-HBASE-Build/13864/ didn't go

[jira] [Comment Edited] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562418#comment-16562418 ] Ted Yu edited comment on HBASE-20968 at 7/31/18 4:32 PM: - The attached test

[jira] [Updated] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20968: --- Attachment: org.apache.hadoop.hbase.client.TestShell-output.txt > list_procedures_test fails due to no

[jira] [Created] (HBASE-20988) TestShell shouldn't be skipped for hbase-shell module test

2018-07-31 Thread Ted Yu (JIRA)
Ted Yu created HBASE-20988: -- Summary: TestShell shouldn't be skipped for hbase-shell module test Key: HBASE-20988 URL: https://issues.apache.org/jira/browse/HBASE-20988 Project: HBase Issue Type:

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563647#comment-16563647 ] Ted Yu commented on HBASE-19036: Can you update master patch as well ? Thanks > Add action in Chaos

[jira] [Commented] (HBASE-20940) HStore.cansplit should not allow split to happen if it has references

2018-07-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563575#comment-16563575 ] Ted Yu commented on HBASE-20940: Can you attach patch for master branch ? > HStore.cansplit should not

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562418#comment-16562418 ] Ted Yu commented on HBASE-20968: There are several tests written in ruby: {code} ls

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562413#comment-16562413 ] Ted Yu commented on HBASE-20968: The test failure happens for hadoop2 as well:

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562024#comment-16562024 ] Ted Yu commented on HBASE-19036: {code} +LOG.info("Killing namenode :-" + server.getHostname()); +

[jira] [Commented] (HBASE-20919) meta region can't be re-onlined when restarting cluster if opening rsgroup

2018-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562005#comment-16562005 ] Ted Yu commented on HBASE-20919: +1 > meta region can't be re-onlined when restarting cluster if

[jira] [Commented] (HBASE-20976) SCP can be scheduled multiple times for the same RS

2018-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561999#comment-16561999 ] Ted Yu commented on HBASE-20976: +1 > SCP can be scheduled multiple times for the same RS >

[jira] [Commented] (HBASE-20578) Support region server group in target cluster

2018-07-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561257#comment-16561257 ] Ted Yu commented on HBASE-20578: Apart from the following static method: {code} protected static List

[jira] [Commented] (HBASE-19036) Add action in Chaos Monkey to restart Active Namenode

2018-07-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561122#comment-16561122 ] Ted Yu commented on HBASE-19036: {code} +clusterManager.start(ServiceType.HADOOP_NAMENODE,

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561040#comment-16561040 ] Ted Yu commented on HBASE-20968: bq. -Dhadoop-three.version=3.0.0 Have you tried without the above ?

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-07-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560895#comment-16560895 ] Ted Yu commented on HBASE-20968: I was able to reproduce this locally on branch-2. {code} mvn test

<    3   4   5   6   7   8   9   10   11   12   >