[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638573746 > Maybe an alternative would be to improve the message in tasks and explicitly say "noticed an SCP, waiting for processing". Don't know if such verbosity would be useful though?

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638530854 And I got the reason why there is a currentRunningState field. We will call setNextState after scheduling sub procedures, so when updating progress, if we just use the recorded

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638527858 > Thanks for suggestion @Apache9, but I don't think that's going to work for the case of state being `SERVER_CRASH_FINISH`. With such code change, `executeFromState` will end up

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-01 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-637222180 I think the problem here is in the implementation of updateProgress? We pass updateState as false when calling it in the deserialize method, but the only place to update the