[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-27 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r931639878 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1911,7 +1916,13 @@ public void split(final TableName tableName, final byte[] splitPo

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-27 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r931639352 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, final by

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-27 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r931639878 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1911,7 +1916,13 @@ public void split(final TableName tableName, final byte[] splitPo

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-27 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r931639352 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, final by

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-26 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r930512690 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1931,7 +1942,13 @@ public void splitRegion(final byte[] regionName, final byte[] spl

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-26 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r930512471 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1911,7 +1916,13 @@ public void split(final TableName tableName, final byte[] splitPo

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-26 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r930512250 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: ## @@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, final by

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-26 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r930509784 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java: ## @@ -94,34 +94,35 @@ private long resultSize2CacheSize(long maxResultSize)

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

2022-07-26 Thread GitBox
apurtell commented on code in PR #4651: URL: https://github.com/apache/hbase/pull/4651#discussion_r930509784 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java: ## @@ -94,34 +94,35 @@ private long resultSize2CacheSize(long maxResultSize)