[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-12 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323167385 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-12 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323097842 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-12 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1322965001 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1625,14 +1641,16 @@ private void cacheNextBlockHeader(final long offset,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321727477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321591860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321548711 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321537092 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-07 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1319156850 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-07 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1319153181 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-07 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1319150874 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-07 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1319142361 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock