bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1399111088
> @bbeaudreault How to re run the CI pipeline?
Only committers can do it. Actually I was going to merge anyway, cuz we got
3 +1's which is all we really need. The pipeline failed
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398400263
There are some javac (checkstyle) warnings. They are all in the net-new
code, and I checked them and master has the same issues. Seems like we skipped
cleaning up checkstyle in backup/
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398394580
Nice! I think this looks good. Just waiting on clean pre-commit checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397708589
Thanks for doing this @rda3mon -- i made a few small comments, and then I
think we should be good.
Extra reminder: make sure to run `mvn spotless:apply` after making the
request
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1315969416
May still be a bit, but I'm finally starting to look at this now. Looks like
it's almost all net-new code.
I checked out this branch and the following:
```
git diff --c
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1253137587
Sorry for the delay here. We are currently evaluating internally in our
fork. Will get to reviewing in the near future.
--
This is an automated message from the Apache Git Service.
T
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1245477406
@rda3mon looks like that cherry-pick resolved most of the error prone
issues. Looks like there are 3 left:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artif
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244797927
@rda3mon I find that the violations are usually pretty straightforward. If
there are any that you have a question about, feel free to post here. I do
think it's possible to run locally
bbeaudreault commented on PR #4770:
URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244458268
@rda3mon I know this is still just a draft, but can you address the
error-prone findings in the pre-commit? Shows up under javac:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub
