[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-16 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r304207256 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SnapshotDescription.java ## @@ -63,46

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303572081 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303452338 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303452338 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303452338 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303507612 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303452338 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303452338 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-14 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303285898 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-14 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303285785 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-14 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303285110 ## File path: hbase-protocol-shaded/src/main/protobuf/Snapshot.proto ## @@ -35,15 +35,16 @@ message SnapshotDe

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r30313 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303167670 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ##

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303164891 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303164980 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1864,4 +1864,14 @@ possible configurati

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303167154 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -2745,6 +2745,40 @@ A snapshot is only a represen

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-12 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r302853121 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ##

[GitHub] [hbase] virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-11 Thread GitBox
virajjasani commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r302403318 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ##