virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601020460
@ndimiduk @saintstack I just triggered a build and since I have run
individual test 50-70 times in loop, let me commit thi
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-600247542
Thanks @ndimiduk
Could you please take a look one more time?
Thanks
---
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-599015485
Thanks Nick
Please review the patch @ndimiduk @saintstack
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018
Spotbug in this build has nothing to do with this patch:
```
Return value of putIfAbsent is ignored, but node is reus
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598796148
> There's a utility method `waitUntil` that lets you wait for a condition to
occur, or timeout. Check it's return value fo
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942
btw I am returning true in `waitFor()` because `confirmPayloadParams` is
anyways going to throw AssertError if match is no
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790294
> Maybe try inserting an intentional delay into the machinery around the
ringbuffer, so as to tease out a timing bug?
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598782970
Yeah agree, let me quickly try it. Thanks @saintstack
Th
