bbeaudreault merged PR #5509:
URL: https://github.com/apache/hbase/pull/5509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807568949
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807496723
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807371640
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 58s |
charlesconnell commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1390541789
##
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java:
##
@@ -92,7 +92,7 @@ public void setUp() throws Exception {
Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1390535691
##
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java:
##
@@ -92,7 +92,7 @@ public void setUp() throws Exception {
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807313227
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 23s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807309245
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 17s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807240326
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807230710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807209439
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
bbeaudreault commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807176917
@charlesconnell please fix the checkstyle warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807158464
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
bbeaudreault commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807149003
Yea, the last failure is unrelated. The other 2 look weird. I restarted the
build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
charlesconnell commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1807134094
I'm not seeing any evidence that my changes have caused these build failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1806904663
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1806849909
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1806849852
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1389560762
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
-
Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1389468881
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
-
charlesconnell commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1386855006
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1801133980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1801108114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1385915285
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
-
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800883383
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
charlesconnell commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800851233
Looking for a solution to cleanly support the various uses of
MobFileCleanerChore in test code, I gave it a constructor that takes an Admin
directly.
--
This is an automated
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800331863
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 10s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800328948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800323334
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800295253
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800288607
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
bbeaudreault commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1385476662
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -92,10 +92,6 @@ private void checkObsoleteConfigurations() {
}
}
bbeaudreault commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799650213
Also please fix checkstyle and spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799581402
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
34 matches
Mail list logo
