gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1837052398
Thanks @bbeaudreault for merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836930404
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836888615
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
bbeaudreault merged PR #5549:
URL: https://github.com/apache/hbase/pull/5549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836650922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836586869
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836567752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836266082
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s |
gourabtaparia commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1412113806
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1535,7 +1535,16 @@ default void modifyTable(TableName tableName,
TableDescriptor
gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836134087
@bbeaudreault Thanks for pointing this out, i have pushed a commit adding
the related javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the
bbeaudreault commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1412097064
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1535,7 +1535,16 @@ default void modifyTable(TableName tableName,
TableDescriptor
gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1836093101
Hi @bbeaudreault @GeorryHuang
Retriggered the build again, and all the previous failed test succeeded, and
this time a new test
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1835913691
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1835909767
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1835612728
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s |
gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1833548614
@GeorryHuang @bbeaudreault Looks like few of the unrelated unit tests are
failing here. How should we move ahead here ? Should i submit a dummy change to
retrigger the runs ? Or is
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1833029636
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 51s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1833022711
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 11s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832811805
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832701152
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 51s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832671929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832341479
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832228630
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gourabtaparia commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832192163
@bbeaudreault I have made the suggested change. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gourabtaparia commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409466122
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1582,7 +1591,7 @@ default Future modifyTableAsync(TableName
tableName,
bbeaudreault commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409458613
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1582,7 +1591,7 @@ default Future modifyTableAsync(TableName
tableName,
gourabtaparia commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409420727
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1582,7 +1591,7 @@ default Future modifyTableAsync(TableName
tableName,
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1832043866
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1831923592
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
bbeaudreault commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409229182
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##
@@ -1582,7 +1591,7 @@ default Future modifyTableAsync(TableName
tableName,
Apache-HBase commented on PR #5549:
URL: https://github.com/apache/hbase/pull/5549#issuecomment-1831556523
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
gourabtaparia opened a new pull request, #5549:
URL: https://github.com/apache/hbase/pull/5549
* This is to prevent RIT storms.
* The changes have been made in both alter and alter sync commands.
The related changes have already been merged in the master branch from
GeorryHuang merged PR #2924:
URL: https://github.com/apache/hbase/pull/2924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1802722637
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1802647215
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1802261054
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1802118133
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1801815306
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1801388943
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1386145595
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -104,6 +108,55 @@ protected void
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1386129802
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -2763,6 +2763,13 @@ protected String getDescription() {
private long
GeorryHuang commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1801177818
> We are good to go?
Yes, I am going to merge it into the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
virajjasani commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1382730988
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -104,6 +108,55 @@ protected void
Apache9 commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1792375532
We are good to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1789453319
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
bbeaudreault commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1379035689
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -2763,6 +2763,13 @@ protected String getDescription() {
private long
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1789120727
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1788825444
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1788585507
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1788529403
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1788350141
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1378329971
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -77,14 +80,22 @@ public ModifyTableProcedure(final
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1378328158
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -104,6 +115,55 @@ protected void
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1378327906
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -125,7 +185,11 @@ protected Flow executeFromState(final
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1378324126
##
hbase-shell/src/main/ruby/shell/commands/alter.rb:
##
@@ -72,6 +72,13 @@ def help
hbase> alter 't1', CONFIGURATION =>
wchevreuil commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1376086992
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -104,6 +115,55 @@ protected void
virajjasani commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1767654561
Sorry for the delay and thanks for working on this @GeorryHuang, let me come
back to the review soon as i can.
@bbeaudreault if the changes look good to you in the meantime,
GeorryHuang commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1758792020
> Unit tests seem to be unstable, unrelated unit tests (TestZookeeper*** and
TestReplication***) failed for my commit.
@virajjasani @bharathv @busbey @gourabtaparia
Hello
GeorryHuang commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1755027497
Unit tests seem to be unstable, unrelated unit tests (TestZookeeper*** and
TestReplication***) failed for my commit.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1754667602
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1754577718
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1754305811
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1753464264
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1753248742
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1752900444
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1350151910
##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -786,6 +787,12 @@ def alter(table_name_str, wait = true, *args)
# There are 3 possible options.
bbeaudreault commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1349678587
##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -786,6 +787,12 @@ def alter(table_name_str, wait = true, *args)
# There are 3 possible options.
GeorryHuang commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751979401
Hi everyone, I've completed the patch and all the tests have passed
successfully. My commit is ready for review. I would appreciate it if you could
take a look and provide your
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751977136
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751948664
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 20s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751908389
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751722692
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751715713
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1751644244
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1746297620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1746286649
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1746092983
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1345045779
##
hbase-shell/src/main/ruby/shell/commands/alter.rb:
##
@@ -72,6 +72,13 @@ def help
hbase> alter 't1', CONFIGURATION =>
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1345039935
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java:
##
@@ -584,4 +589,100 @@ public void run() {
t2.join();
79 matches
Mail list logo