wchevreuil merged PR #5501:
URL: https://github.com/apache/hbase/pull/5501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
judilsteve commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1809393968
@wchevreuil I am not sure what to do about the test failure above. The logs
show a timeout, which makes me suspicious of an issue on the build server,
since none of the previous builds
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1807837359
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1807640394
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1807442179
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 13s |
judilsteve commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1807404124
Documentation has been added. The base DELETE and multi-get endpoints were
not documented at all, so I added examples for both the plaintext and base64
encoded versions. The examples
wchevreuil commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1805717085
Thanks for providing UTs, @judilsteve ! One last ask I have before merging
this is to also update the ref guide to explain this extra param. You can find
the REST section under
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1804972679
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 2s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1804971303
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1804967830
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
judilsteve commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803397021
```
[ERROR]
org.apache.hadoop.hbase.rest.TestGetAndPutResource.testUrlB64EncodedKeyHeader
Time elapsed: 1.214 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[text/xml]>
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803388388
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803385410
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803381662
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
judilsteve commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803324257
Test failure log:
```
[ERROR] Tests run: 29, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
46.271 s <<< FAILURE! - in org.apache.hadoop.hbase.rest.TestGetAndPutResource
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803310707
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803308831
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803304978
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
judilsteve commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1803286915
Actioned. I've never used JUnit before, so the test code might not be
particularly idiomatic.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797147320
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797146346
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797146012
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794114939
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794112547
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 5s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794112162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791813930
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791807965
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791801238
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791778384
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791772728
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
judilsteve commented on code in PR #5501:
URL: https://github.com/apache/hbase/pull/5501#discussion_r1380962441
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RowSpec.java:
##
@@ -55,6 +59,19 @@ public RowSpec(String path) throws IllegalArgumentException {
i =
Apache-HBase commented on PR #5501:
URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791771782
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
judilsteve opened a new pull request, #5501:
URL: https://github.com/apache/hbase/pull/5501
See https://issues.apache.org/jira/browse/HBASE-28174
Very much a draft. I'm yet to test this. Testing checklist (hopefully I've
caught everything here):
- [ ] GET b64-encoded
33 matches
Mail list logo
