[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064020#comment-14064020
]
Hudson commented on HBASE-10322:
FAILURE: Integrated in HBase-TRUNK #5313 (See
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878469#comment-13878469
]
Hudson commented on HBASE-10322:
SUCCESS: Integrated in HBase-TRUNK #4847 (See
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878506#comment-13878506
]
Hudson commented on HBASE-10322:
SUCCESS: Integrated in HBase-0.98 #101 (See
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878559#comment-13878559
]
Hudson commented on HBASE-10322:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #95 (See
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877417#comment-13877417
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877651#comment-13877651
]
Andrew Purtell commented on HBASE-10322:
bq. I'd be +1 on committing this in
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877659#comment-13877659
]
Andrew Purtell commented on HBASE-10322:
And if making tags first class we will
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877662#comment-13877662
]
Anoop Sam John commented on HBASE-10322:
bq.Would have to be a LargeTest given it
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877665#comment-13877665
]
Andrew Purtell commented on HBASE-10322:
bq. Pls see TestReplicationWithTags in
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877721#comment-13877721
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878246#comment-13878246
]
ramkrishna.s.vasudevan commented on HBASE-10322:
+1 on V6. Thanks
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878259#comment-13878259
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878356#comment-13878356
]
Anoop Sam John commented on HBASE-10322:
Committed to Trunk and 98.
Will file a
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876241#comment-13876241
]
Anoop Sam John commented on HBASE-10322:
Sorry for the confusion Lars
The final
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876680#comment-13876680
]
Andrew Purtell commented on HBASE-10322:
Let's condense the dense walls of text
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876697#comment-13876697
]
Andrew Purtell commented on HBASE-10322:
[~lhofhansl], [~stack], [~anoop.hbase],
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876701#comment-13876701
]
Andrew Purtell commented on HBASE-10322:
[~lhofhansl]: Instead of Export, make a
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876734#comment-13876734
]
Lars Hofhansl commented on HBASE-10322:
---
Good summary. (And I'm really just a
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876758#comment-13876758
]
stack commented on HBASE-10322:
---
Nice distillation. So, to 'solve' this issue for
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876828#comment-13876828
]
Andrew Purtell commented on HBASE-10322:
bq. So, to 'solve' this issue for
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876835#comment-13876835
]
Andrew Purtell commented on HBASE-10322:
bq. A compelling argument might
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877148#comment-13877148
]
Anoop Sam John commented on HBASE-10322:
bq.It does not even have to be 'on' in
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877158#comment-13877158
]
ramkrishna.s.vasudevan commented on HBASE-10322:
+1 on the entire
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877180#comment-13877180
]
stack commented on HBASE-10322:
---
bq. The interface Codec is marked
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877187#comment-13877187
]
Anoop Sam John commented on HBASE-10322:
Got it Stack. We will provide codec
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877196#comment-13877196
]
stack commented on HBASE-10322:
---
If we remove tags from Put, how do tags make it into the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877208#comment-13877208
]
ramkrishna.s.vasudevan commented on HBASE-10322:
bq.If we remove tags
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877245#comment-13877245
]
ramkrishna.s.vasudevan commented on HBASE-10322:
I am +1 on patch.
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877275#comment-13877275
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877279#comment-13877279
]
stack commented on HBASE-10322:
---
OK. So CPs add tags for now. Good.
How we know
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877281#comment-13877281
]
ramkrishna.s.vasudevan commented on HBASE-10322:
I tried it atleast with
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877287#comment-13877287
]
stack commented on HBASE-10322:
---
I'd suggest you test in small cluster.
I'd be +1 on
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877291#comment-13877291
]
Anoop Sam John commented on HBASE-10322:
Let me try adding a test Stack.
I have
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877316#comment-13877316
]
stack commented on HBASE-10322:
---
[~anoop.hbase] Whatever you think boss. It'd just be good
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875919#comment-13875919
]
Anoop Sam John commented on HBASE-10322:
That changes can be in another Jira
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875990#comment-13875990
]
Lars Hofhansl commented on HBASE-10322:
---
I am a bit late to this party. The
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876141#comment-13876141
]
ramkrishna.s.vasudevan commented on HBASE-10322:
bq.CellCodecV2 is used
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876146#comment-13876146
]
stack commented on HBASE-10322:
---
bq. We need any way an RpcClient to talk with peer right?
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876147#comment-13876147
]
stack commented on HBASE-10322:
---
Just to say that the 'codec ' problem would be true of any
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876159#comment-13876159
]
ramkrishna.s.vasudevan commented on HBASE-10322:
bq.what happens when you
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876186#comment-13876186
]
Anoop Sam John commented on HBASE-10322:
bq.I.e. if I can see a certain KV,
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876212#comment-13876212
]
Lars Hofhansl commented on HBASE-10322:
---
Thanks for explaining, Ram and Anoop.
bq.
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875584#comment-13875584
]
ramkrishna.s.vasudevan commented on HBASE-10322:
If you do start using
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875600#comment-13875600
]
Anoop Sam John commented on HBASE-10322:
How about adding new config
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875602#comment-13875602
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875757#comment-13875757
]
stack commented on HBASE-10322:
---
It is wrong that replication is in the admin Service and
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875068#comment-13875068
]
Andrew Purtell commented on HBASE-10322:
Agree.
The goal is to prevent sensitive
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875069#comment-13875069
]
Andrew Purtell commented on HBASE-10322:
Ping [~stack], [~jdcryans],
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875139#comment-13875139
]
stack commented on HBASE-10322:
---
Sounds reasonable Andrew, what you say about replication
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875141#comment-13875141
]
Andrew Purtell commented on HBASE-10322:
bq. Is there a patch to review yet?
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875571#comment-13875571
]
Anoop Sam John commented on HBASE-10322:
My patch is like almost ready except
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874497#comment-13874497
]
Anoop Sam John commented on HBASE-10322:
After lot of discussions here btw me,
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873673#comment-13873673
]
Andrew Purtell commented on HBASE-10322:
There are three contexts where we
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871830#comment-13871830
]
Anoop Sam John commented on HBASE-10322:
Let us try doing it by removing tags in
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872415#comment-13872415
]
Andrew Purtell commented on HBASE-10322:
So for every cell we have to make a
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872531#comment-13872531
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872535#comment-13872535
]
Andrew Purtell commented on HBASE-10322:
Sorry, I need to -1 the current patch
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873066#comment-13873066
]
Anoop Sam John commented on HBASE-10322:
Because of the perf penalty I am also
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871455#comment-13871455
]
stack commented on HBASE-10322:
---
bq. 1. Send back tags in missing cases also. But sending
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871492#comment-13871492
]
Andrew Purtell commented on HBASE-10322:
Our bottom line, in my opinion, is that
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871598#comment-13871598
]
ramkrishna.s.vasudevan commented on HBASE-10322:
bq.The rock bottom
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871622#comment-13871622
]
Anoop Sam John commented on HBASE-10322:
Selectively sending back tags is one
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871644#comment-13871644
]
Anoop Sam John commented on HBASE-10322:
BTW, the stripping of tags can be
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871672#comment-13871672
]
ramkrishna.s.vasudevan commented on HBASE-10322:
As Anoop says, even in
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871683#comment-13871683
]
stack commented on HBASE-10322:
---
bq. Another suggestion atleast to avoid changes to the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871694#comment-13871694
]
ramkrishna.s.vasudevan commented on HBASE-10322:
bq.Anoop fed me the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871696#comment-13871696
]
stack commented on HBASE-10322:
---
Well, for 0.98, we could even hardcode it given we have
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871704#comment-13871704
]
ramkrishna.s.vasudevan commented on HBASE-10322:
Ok.. So considering
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871745#comment-13871745
]
Andrew Purtell commented on HBASE-10322:
bq. So export tool will not be working
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871750#comment-13871750
]
Andrew Purtell commented on HBASE-10322:
bq. Are we writing new KVs or creating a
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871753#comment-13871753
]
Andrew Purtell commented on HBASE-10322:
Finally, the reason I say rock bottom
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869356#comment-13869356
]
Andrew Purtell commented on HBASE-10322:
+1
Strip tags from KV while sending
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870126#comment-13870126
]
stack commented on HBASE-10322:
---
-final CellScanner cellScanner)
- throws IOException
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870330#comment-13870330
]
Anoop Sam John commented on HBASE-10322:
Thanks Stack.
bq.Or rather, it should
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870441#comment-13870441
]
stack commented on HBASE-10322:
---
Let me continue the review Anoop (sorry took a while to
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870491#comment-13870491
]
Andrew Purtell commented on HBASE-10322:
bq. Pardon me Anoop but I don't like the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868973#comment-13868973
]
Anoop Sam John commented on HBASE-10322:
https://reviews.apache.org/r/16810/
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868995#comment-13868995
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869026#comment-13869026
]
Hadoop QA commented on HBASE-10322:
---
{color:red}-1 overall{color}. Here are the
79 matches
Mail list logo