[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940317#comment-13940317
]
haosdent commented on HBASE-10648:
--
well done! [~carp84]
Pluggable Memstore
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939439#comment-13939439
]
Lars Hofhansl commented on HBASE-10648:
---
Looks good in principle. Doesn't change
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934691#comment-13934691
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934806#comment-13934806
]
Anoop Sam John commented on HBASE-10648:
Sorry I will need some more time to post
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934819#comment-13934819
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934833#comment-13934833
]
Yu Li commented on HBASE-10648:
---
{quote}
Sorry I will need some more time to post a patch
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934844#comment-13934844
]
Anoop Sam John commented on HBASE-10648:
bq.Sorry but what's preventing the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934846#comment-13934846
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934850#comment-13934850
]
Anoop Sam John commented on HBASE-10648:
Gone through the 94 patch. Looks good.
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934931#comment-13934931
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935014#comment-13935014
]
Anoop Sam John commented on HBASE-10648:
Test fail seems not related. Going to
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935055#comment-13935055
]
Anoop Sam John commented on HBASE-10648:
Committed to trunk.
Thanks for the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935079#comment-13935079
]
Yu Li commented on HBASE-10648:
---
Hi [~anoop.hbase],
{quote}
It won't be good to directly
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935337#comment-13935337
]
Hudson commented on HBASE-10648:
FAILURE: Integrated in HBase-TRUNK #5010 (See
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935907#comment-13935907
]
Hudson commented on HBASE-10648:
FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #118
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932424#comment-13932424
]
stack commented on HBASE-10648:
---
[~anoop.hbase] Whats up? I already said lgtm where the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932784#comment-13932784
]
Anoop Sam John commented on HBASE-10648:
bq.You looking for more compliments?
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932786#comment-13932786
]
Anoop Sam John commented on HBASE-10648:
May be better I will wait for ur commit
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930980#comment-13930980
]
Ted Yu commented on HBASE-10648:
+1 on v4
Pluggable Memstore
--
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931418#comment-13931418
]
Anoop Sam John commented on HBASE-10648:
Ping [~stack], [~apurtell] .
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925716#comment-13925716
]
Hadoop QA commented on HBASE-10648:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925191#comment-13925191
]
Anoop Sam John commented on HBASE-10648:
I will give the reworked patch soon.
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925003#comment-13925003
]
stack commented on HBASE-10648:
---
All of the above is good by me Anoop including the bit
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923806#comment-13923806
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923882#comment-13923882
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924402#comment-13924402
]
stack commented on HBASE-10648:
---
bq. KeyValueScanner snapshotScanner
Should it be
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924710#comment-13924710
]
Anoop Sam John commented on HBASE-10648:
Thanks Stack for the review and
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923576#comment-13923576
]
Anoop Sam John commented on HBASE-10648:
Sure I can add those java docs also.
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921802#comment-13921802
]
Ted Yu commented on HBASE-10648:
There're a few methods in MemStore interface which lack
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919117#comment-13919117
]
Andrew Purtell commented on HBASE-10648:
Static class in an interface is weird?
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918288#comment-13918288
]
Ted Yu commented on HBASE-10648:
Should there be an interface for Memstore so that the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918336#comment-13918336
]
Hadoop QA commented on HBASE-10648:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918996#comment-13918996
]
Anoop Sam John commented on HBASE-10648:
bq.Should there be an interface for
33 matches
Mail list logo
