[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-10 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241063#comment-14241063 ] Jurriaan Mous commented on HBASE-12597: --- Thanks for the SNAPSHOT! It works. I hav

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239523#comment-14239523 ] stack commented on HBASE-12597: --- I pushed a 1.0.0-SNAPSHOT [~jurmous] Let me know if issue

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-09 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239230#comment-14239230 ] Jurriaan Mous commented on HBASE-12597: --- Thanks for the commit! :) Would it be poss

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238811#comment-14238811 ] Hudson commented on HBASE-12597: SUCCESS: Integrated in HBase-TRUNK #5888 (See [https://

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238767#comment-14238767 ] Hudson commented on HBASE-12597: SUCCESS: Integrated in HBase-1.0 #552 (See [https://bui

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238687#comment-14238687 ] stack commented on HBASE-12597: --- Just to say that I committed and then had to revert becaus

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236962#comment-14236962 ] Hadoop QA commented on HBASE-12597: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236927#comment-14236927 ] stack commented on HBASE-12597: --- Nice. All green. Please make a branch-1 patch for me to

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236929#comment-14236929 ] stack commented on HBASE-12597: --- I could apply current patch to trunk as is but would rathe

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236921#comment-14236921 ] Jurriaan Mous commented on HBASE-12597: --- Here you go. :) I hope that the cluster te

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236908#comment-14236908 ] Hadoop QA commented on HBASE-12597: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236870#comment-14236870 ] stack commented on HBASE-12597: --- Great. Lets see how hadoopqa does. Let me try this on a

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236850#comment-14236850 ] Hadoop QA commented on HBASE-12597: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-05 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236460#comment-14236460 ] Enis Soztutar commented on HBASE-12597: --- Skimmed the patch. It should be ok for bra

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236034#comment-14236034 ] Hadoop QA commented on HBASE-12597: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235670#comment-14235670 ] stack commented on HBASE-12597: --- It fails for me too when I apply your patch to the master

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-05 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235343#comment-14235343 ] Jurriaan Mous commented on HBASE-12597: --- I can maven compile it on my local machine

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235337#comment-14235337 ] Hadoop QA commented on HBASE-12597: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234426#comment-14234426 ] stack commented on HBASE-12597: --- Skimmed. Will come back with a better review (should the

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-03 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233726#comment-14233726 ] stack commented on HBASE-12597: --- bq. This enabled me to remove setRpcClient on HConnection

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-03 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233037#comment-14233037 ] Anoop Sam John commented on HBASE-12597: ConnectionId You should add Apache lice

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-03 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232938#comment-14232938 ] Jurriaan Mous commented on HBASE-12597: --- bq. I presume no changes in RpcClientImpl

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-03 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232822#comment-14232822 ] Anoop Sam John commented on HBASE-12597: {code} } catch (RpcClientImpl.FailedServ

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-02 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231874#comment-14231874 ] stack commented on HBASE-12597: --- bq. Is it ok to use "hbase.ipc.client.impl" as the settin

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-02 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231558#comment-14231558 ] Jurriaan Mous commented on HBASE-12597: --- bq. I just pushed a new snapshot for you s

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230255#comment-14230255 ] stack commented on HBASE-12597: --- On your patch, what if RpcClient was the interface and the

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230238#comment-14230238 ] stack commented on HBASE-12597: --- [~jurmous] Just in case you've not seen this before, http

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-01 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229697#comment-14229697 ] Jurriaan Mous commented on HBASE-12597: --- Also updated my client to use the new Conn

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-12-01 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229559#comment-14229559 ] Jurriaan Mous commented on HBASE-12597: --- bq. I was just trying to warn you off the

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-11-30 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229298#comment-14229298 ] stack commented on HBASE-12597: --- bq. And I would like to switch out the RpcClient in whatev

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-11-30 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229105#comment-14229105 ] Jurriaan Mous commented on HBASE-12597: --- Some followup on your Channel codec/compre

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-11-30 Thread Jurriaan Mous (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229102#comment-14229102 ] Jurriaan Mous commented on HBASE-12597: --- [~stack] I indeed mention HCI since it is

[jira] [Commented] (HBASE-12597) Add RpcClient interface and enable changing of RpcClient implementation

2014-11-29 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228879#comment-14228879 ] stack commented on HBASE-12597: --- Sweet [~jurmous] You refer to HConnectionImplementation (