[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309619#comment-14309619 ] Jesse Yates commented on HBASE-12979: - Ah, that's the doc I was looking for! All I

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309841#comment-14309841 ] Lars Hofhansl commented on HBASE-12979: --- +1 That just looks so much cleaner too.

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309933#comment-14309933 ] Andrew Purtell commented on HBASE-12979: I've thought about returning stats on

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309885#comment-14309885 ] Hadoop QA commented on HBASE-12979: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309918#comment-14309918 ] Jesse Yates commented on HBASE-12979: - Well, this is the only places we changed it

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310168#comment-14310168 ] Enis Soztutar commented on HBASE-12979: --- Let's get this in this RC. The patch is

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310179#comment-14310179 ] Jesse Yates commented on HBASE-12979: - And just committed to branch-1.0 and 0.98.

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309961#comment-14309961 ] Jesse Yates commented on HBASE-12979: - Just committed to master and 1.1.0. I'll wait

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310224#comment-14310224 ] Hudson commented on HBASE-12979: FAILURE: Integrated in HBase-1.1 #151 (See

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310269#comment-14310269 ] Hadoop QA commented on HBASE-12979: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310556#comment-14310556 ] Hudson commented on HBASE-12979: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #798

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310235#comment-14310235 ] Enis Soztutar commented on HBASE-12979: --- Why is the version 0.98.10.1? Did I miss

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310519#comment-14310519 ] Hudson commented on HBASE-12979: FAILURE: Integrated in HBase-0.98 #840 (See

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309946#comment-14309946 ] Lars Hofhansl commented on HBASE-12979: --- 1.1, and 2.0 as well I assume. 1.0.1?

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310171#comment-14310171 ] Hudson commented on HBASE-12979: FAILURE: Integrated in HBase-TRUNK #6099 (See

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310296#comment-14310296 ] Andrew Purtell commented on HBASE-12979: bq. Why is the version 0.98.10.1? Did I

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310352#comment-14310352 ] Hudson commented on HBASE-12979: SUCCESS: Integrated in HBase-1.0 #718 (See

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309608#comment-14309608 ] Andrew Purtell commented on HBASE-12979: See

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309577#comment-14309577 ] Jesse Yates commented on HBASE-12979: - Is there any issue with the addition of the:

[jira] [Commented] (HBASE-12979) Use setters instead of return values for handing back statistics from HRegion methods

2015-02-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308038#comment-14308038 ] Andrew Purtell commented on HBASE-12979: Not super urgent, let's look at a patch