[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011347#comment-15011347 ] stack commented on HBASE-14803: --- bq. I tried to run the tests locally and it fails on unrel

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-18 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010830#comment-15010830 ] Jean-Marc Spaggiari commented on HBASE-14803: - Hey, I'm planning to change th

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010823#comment-15010823 ] Anoop Sam John commented on HBASE-14803: Ah.. bad that we have to have these muc

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009230#comment-15009230 ] Elliott Clark commented on HBASE-14803: --- These look much more like trace logs than

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008919#comment-15008919 ] Heng Chen commented on HBASE-14803: --- Except that, patch looks good to me. :) > Add

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008906#comment-15008906 ] Heng Chen commented on HBASE-14803: --- {quote} We do not want to keep one counter per re

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008889#comment-15008889 ] Jean-Marc Spaggiari commented on HBASE-14803: - Indeed. Goal is to limit the n

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008869#comment-15008869 ] Heng Chen commented on HBASE-14803: --- {quote} Also, this is only when doing scans for th

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-17 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008860#comment-15008860 ] Jean-Marc Spaggiari commented on HBASE-14803: - I was hesitant about the Atomi

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007946#comment-15007946 ] Heng Chen commented on HBASE-14803: --- {code} + private static long logLastLogin = 0; +

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007318#comment-15007318 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006694#comment-15006694 ] Jean-Marc Spaggiari commented on HBASE-14803: - Ok. Looks better. {quote} 201

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006642#comment-15006642 ] Jean-Marc Spaggiari commented on HBASE-14803: - {quote} 2015-11-16 07:53:32,90

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006627#comment-15006627 ] Jean-Marc Spaggiari commented on HBASE-14803: - Interesting... Let me test it

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006513#comment-15006513 ] Heng Chen commented on HBASE-14803: --- Oh, the patch will cause org.apache.hadoop.hbase

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006496#comment-15006496 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006161#comment-15006161 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006101#comment-15006101 ] Jean-Marc Spaggiari commented on HBASE-14803: - This error doesn't really make

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006098#comment-15006098 ] Jean-Marc Spaggiari commented on HBASE-14803: - Hum. Bad for the tabs. Don't k

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006093#comment-15006093 ] Sean Busbey commented on HBASE-14803: - v3 still has tabs. the v2 test failure was th

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005967#comment-15005967 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-15 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005901#comment-15005901 ] Jean-Marc Spaggiari commented on HBASE-14803: - {quote} please make private {q

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005680#comment-15005680 ] Heng Chen commented on HBASE-14803: --- IMO we should check whether reader.getHFileReader(

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-14 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005647#comment-15005647 ] Sean Busbey commented on HBASE-14803: - {code} + static final Log LOG = LogFactory.ge

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005150#comment-15005150 ] Anoop Sam John commented on HBASE-14803: Yes like this way. Test failure related

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004015#comment-15004015 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-12 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003526#comment-15003526 ] Anoop Sam John commented on HBASE-14803: Will it be still better if we can add th

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003269#comment-15003269 ] Heng Chen commented on HBASE-14803: --- {quote} + static final Log LOG = LogFactory.getLo

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003225#comment-15003225 ] Hadoop QA commented on HBASE-14803: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner

2015-11-12 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003098#comment-15003098 ] Jerry He commented on HBASE-14803: -- +1 The scanner implementations lack debug logging ov