[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552755#comment-15552755 ] Anoop Sam John commented on HBASE-15789: We have moved to PB 3.1 now with shading

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552851#comment-15552851 ] stack commented on HBASE-15789: --- Sounds good. Stating the obvious, lets make the new ByteIn

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570054#comment-15570054 ] stack commented on HBASE-15789: --- Should this be protected rather than default? s

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572627#comment-15572627 ] Anoop Sam John commented on HBASE-15789: bq.Should this be protected rather than

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574299#comment-15574299 ] stack commented on HBASE-15789: --- bq. As it is static I thought default is make sense than p

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574446#comment-15574446 ] Anoop Sam John commented on HBASE-15789: bq.Was more asking about how pb does it

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575914#comment-15575914 ] stack commented on HBASE-15789: --- What did you do regards mvn package? Where did you check i

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-14 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575955#comment-15575955 ] Anoop Sam John commented on HBASE-15789: Oh.. I just committed the new PB src fil

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576000#comment-15576000 ] stack commented on HBASE-15789: --- No worries. That'll work until we upgrade our protobuf ver

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577059#comment-15577059 ] stack commented on HBASE-15789: --- See what you think of this patch [~anoop.hbase] > PB rela

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-14 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577529#comment-15577529 ] Anoop Sam John commented on HBASE-15789: Looks good.. Got the way how we should

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578421#comment-15578421 ] stack commented on HBASE-15789: --- bq. Even the new classes in the patch can be inside src/pa

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578441#comment-15578441 ] stack commented on HBASE-15789: --- Nvm. One commit only. My commit included adding this patch

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578467#comment-15578467 ] Hudson commented on HBASE-15789: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578592#comment-15578592 ] Hadoop QA commented on HBASE-15789: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578650#comment-15578650 ] ChiaPing Tsai commented on HBASE-15789: --- [~stack] i get some compile error after co

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579096#comment-15579096 ] stack commented on HBASE-15789: --- Sorry about that [~chia7712] Thanks for the kick. I revert

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579208#comment-15579208 ] stack commented on HBASE-15789: --- There is an issue w/ the patch. Works the first time but t

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579532#comment-15579532 ] Hudson commented on HBASE-15789: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604113#comment-15604113 ] Hudson commented on HBASE-15789: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

2016-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604208#comment-15604208 ] Anoop Sam John commented on HBASE-15789: Thanks Stack. > PB related changes to w