[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366429#comment-15366429 ] Ted Yu commented on HBASE-16194: {code} 158 int getCellLength(Cell cell) { {code} A

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367280#comment-15367280 ] Hadoop QA commented on HBASE-16194: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367335#comment-15367335 ] Heng Chen commented on HBASE-16194: --- patch looks good to me. It's very interesting.

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367349#comment-15367349 ] Yu Li commented on HBASE-16194: --- Checking UT failures, {{TestReplicationSmallTests#testRepl

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367354#comment-15367354 ] Yu Li commented on HBASE-16194: --- Actually in branch-1 code it's named as "notPresent" (see

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367360#comment-15367360 ] Heng Chen commented on HBASE-16194: --- the action has succeeded actually when it return f

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367384#comment-15367384 ] Yu Li commented on HBASE-16194: --- Yes, the {{CellSkipListSet#add}} method invokes {{Map#put}

[jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells

2016-07-08 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367953#comment-15367953 ] Yu Li commented on HBASE-16194: --- As mentioned above, UT looks ok, and have addressed all re