[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376383#comment-15376383
]
binlijin commented on HBASE-16205:
--
If the backend byte[] is bigger enough, all cells do
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376391#comment-15376391
]
Anoop Sam John commented on HBASE-16205:
In trunk after HBASE-15180, we will not
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376404#comment-15376404
]
binlijin commented on HBASE-16205:
--
I mean if the byte[] is bigger enough, should all ce
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376411#comment-15376411
]
Anoop Sam John commented on HBASE-16205:
Yes when the Cell's length is big then M
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376425#comment-15376425
]
binlijin commented on HBASE-16205:
--
I mean if a request have two cell: cell1=100k cell2
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376465#comment-15376465
]
Yu Li commented on HBASE-16205:
---
Nice catch [~anoop.hbase]!
Some suggestions:
1. Should we
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376469#comment-15376469
]
Anoop Sam John commented on HBASE-16205:
Sorry am not getting what you actually t
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376486#comment-15376486
]
Anoop Sam John commented on HBASE-16205:
A fear we should not do that. When the
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376497#comment-15376497
]
Yu Li commented on HBASE-16205:
---
I see, makes sense, I should have noticed this is a sub-ta
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376523#comment-15376523
]
binlijin commented on HBASE-16205:
--
[~anoop.hbase], sir
With MSLAB turn on. What i am su
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376525#comment-15376525
]
binlijin commented on HBASE-16205:
--
This is more imp along with HBASE-15788, so for 2.0
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376561#comment-15376561
]
Anoop Sam John commented on HBASE-16205:
Case 2 : Both cells as such less than 25
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376624#comment-15376624
]
binlijin commented on HBASE-16205:
--
Yes, i know it for the master version.
> When Cells
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376622#comment-15376622
]
binlijin commented on HBASE-16205:
--
Yes, i know it for the master version.
> When Cells
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376704#comment-15376704
]
Anoop Sam John commented on HBASE-16205:
This jira is applicable only for master.
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376803#comment-15376803
]
binlijin commented on HBASE-16205:
--
Thanks [~anoop.hbase]
> When Cells are not copied t
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379279#comment-15379279
]
ramkrishna.s.vasudevan commented on HBASE-16205:
+1
> When Cells are not
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379298#comment-15379298
]
Yu Li commented on HBASE-16205:
---
+1
> When Cells are not copied to MSLAB, deep clone it wh
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379299#comment-15379299
]
Anoop Sam John commented on HBASE-16205:
Thanks for the reviews. Will commit onc
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379301#comment-15379301
]
Hadoop QA commented on HBASE-16205:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380534#comment-15380534
]
Hadoop QA commented on HBASE-16205:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380637#comment-15380637
]
Anoop Sam John commented on HBASE-16205:
There is a problem.. Am working on that.
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387157#comment-15387157
]
Anoop Sam John commented on HBASE-16205:
The upsert code path rely on Object equa
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387450#comment-15387450
]
Hadoop QA commented on HBASE-16205:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389025#comment-15389025
]
ramkrishna.s.vasudevan commented on HBASE-16205:
Just a question. So now
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389634#comment-15389634
]
Anoop Sam John commented on HBASE-16205:
upsert() is calling
cell = deepCopyIf
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389879#comment-15389879
]
ramkrishna.s.vasudevan commented on HBASE-16205:
I did not see that comme
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390517#comment-15390517
]
Yu Li commented on HBASE-16205:
---
Let me try to explain: in {{upsert()}} we have below code
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390974#comment-15390974
]
Anoop Sam John commented on HBASE-16205:
Exactly [~carp84]. Thanks.
That is why V
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391431#comment-15391431
]
ramkrishna.s.vasudevan commented on HBASE-16205:
bq. Its ok to have same
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391677#comment-15391677
]
Hadoop QA commented on HBASE-16205:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392051#comment-15392051
]
Hadoop QA commented on HBASE-16205:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392872#comment-15392872
]
Hudson commented on HBASE-16205:
FAILURE: Integrated in HBase-Trunk_matrix #1295 (See
[h
[
https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393575#comment-15393575
]
Anoop Sam John commented on HBASE-16205:
Missed handling TagRewriteCell here as p
34 matches
Mail list logo