[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-18 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368549#comment-16368549 ] Eshcar Hillel commented on HBASE-18294: --- Pushed to master and branch-2. No test fa

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368546#comment-16368546 ] Hudson commented on HBASE-18294: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368517#comment-16368517 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366069#comment-16366069 ] Hadoop QA commented on HBASE-18294: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365146#comment-16365146 ] stack commented on HBASE-18294: --- bq. Anoop the data size tracking at the RS is redundant as

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364705#comment-16364705 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-14 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364463#comment-16364463 ] Eshcar Hillel commented on HBASE-18294: --- Following a comment by Anoop on RB I made

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364325#comment-16364325 ] stack commented on HBASE-18294: --- bq. I think it deserves a separate documentation since thi

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-14 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363845#comment-16363845 ] Eshcar Hillel commented on HBASE-18294: --- Stack the barriers for the RS (global) lev

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363489#comment-16363489 ] stack commented on HBASE-18294: --- bq. Globally the decision should be with ||. We have barri

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363444#comment-16363444 ] Anoop Sam John commented on HBASE-18294: bq.If the offheap is 100x the onheap in

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363328#comment-16363328 ] stack commented on HBASE-18294: --- On release note, named the configs to set? On the patch,

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363247#comment-16363247 ] stack commented on HBASE-18294: --- Nice release note [~eshcar]. bq. (2) A region is flushed

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-13 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362160#comment-16362160 ] Eshcar Hillel commented on HBASE-18294: --- I have updated the release notes, please s

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-12 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360590#comment-16360590 ] Anoop Sam John commented on HBASE-18294: bq.You keep saying that but it seems to

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-12 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360410#comment-16360410 ] Eshcar Hillel commented on HBASE-18294: --- QA passed. Any additional comments on the

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360164#comment-16360164 ] Hadoop QA commented on HBASE-18294: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-11 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360087#comment-16360087 ] Eshcar Hillel commented on HBASE-18294: --- TestClientPushback is a flaky test, someti

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359979#comment-16359979 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359907#comment-16359907 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-08 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356649#comment-16356649 ] Eshcar Hillel commented on HBASE-18294: --- [~anoop.hbase] {quote} the general agreeme

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356538#comment-16356538 ] Anoop Sam John commented on HBASE-18294: Just forget off heap usage and consider

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-07 Thread Chance Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355534#comment-16355534 ] Chance Li commented on HBASE-18294: --- [~anastas] Accutally, It's not a new thing. All c

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-07 Thread Anastasia Braginsky (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355214#comment-16355214 ] Anastasia Braginsky commented on HBASE-18294: - Oh! And in my opinion adding M

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-07 Thread Anastasia Braginsky (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355209#comment-16355209 ] Anastasia Braginsky commented on HBASE-18294: - Hi All, Just want to add my 2

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-06 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353979#comment-16353979 ] Edward Bortnikov commented on HBASE-18294: -- [~eshcar], [~anoop.hbase], [~ram_kri

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-05 Thread Chance Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352221#comment-16352221 ] Chance Li commented on HBASE-18294: --- [~eshcar] The store will known the detail about th

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-05 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352186#comment-16352186 ] Eshcar Hillel commented on HBASE-18294: --- I would generally agree with your approach

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-05 Thread Chance Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352158#comment-16352158 ] Chance Li commented on HBASE-18294: --- [~eshcar]  How about we conside the RAM of the Me

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-04 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351714#comment-16351714 ] Edward Bortnikov commented on HBASE-18294: -- I second [~eshcar]. Off-heap and on-

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-04 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351674#comment-16351674 ] Eshcar Hillel commented on HBASE-18294: --- Here is my response from RB regarding the

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349333#comment-16349333 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-02-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349327#comment-16349327 ] stack commented on HBASE-18294: --- [~eshcar] Looks like there is a blocking item up on rb

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-24 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337712#comment-16337712 ] Eshcar Hillel commented on HBASE-18294: --- The failed test passes on my machine. So

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337695#comment-16337695 ] stack commented on HBASE-18294: --- [~anoop.hbase] when you get a chance sir, take a look at t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337678#comment-16337678 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337418#comment-16337418 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336445#comment-16336445 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336038#comment-16336038 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334160#comment-16334160 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333527#comment-16333527 ] Eshcar Hillel commented on HBASE-18294: --- Thanks Ted. I will try it if QA doesn't s

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333526#comment-16333526 ] Ted Yu commented on HBASE-18294: You can remove the .01 patch and rename .15 patch as .01

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333525#comment-16333525 ] Eshcar Hillel commented on HBASE-18294: --- We are back to a ``fat'' patch, so here is

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333514#comment-16333514 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305644#comment-16305644 ] Edward Bortnikov commented on HBASE-18294: -- Hallelujah! Thanks, all, for the fru

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305641#comment-16305641 ] Eshcar Hillel commented on HBASE-18294: --- OK let me prepare the patch. > Reduce glo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305579#comment-16305579 ] Anoop Sam John commented on HBASE-18294: Good that all started getting each other

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305514#comment-16305514 ] Edward Bortnikov commented on HBASE-18294: -- Agree with [~eshcar]. This design in

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305509#comment-16305509 ] Eshcar Hillel commented on HBASE-18294: --- Thank you [~anoop.hbase] for explaining. I

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305403#comment-16305403 ] Anoop Sam John commented on HBASE-18294: So when the Cell is added to Segment, th

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-28 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305325#comment-16305325 ] Eshcar Hillel commented on HBASE-18294: --- Thanks [~stack] for the document, I think

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305113#comment-16305113 ] ramkrishna.s.vasudevan commented on HBASE-18294: Got it. So probably we s

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305079#comment-16305079 ] Anoop Sam John commented on HBASE-18294: bq.why don't we change the global size t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305066#comment-16305066 ] ramkrishna.s.vasudevan commented on HBASE-18294: Again am not seeing the

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305040#comment-16305040 ] Anoop Sam John commented on HBASE-18294: bq.but Eshcar Hillel's patch needs to in

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304802#comment-16304802 ] stack commented on HBASE-18294: --- Sounds good [~ebortnik] but [~eshcar]'s patch needs to inc

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304800#comment-16304800 ] Edward Bortnikov commented on HBASE-18294: -- My 2 cents - after reviewing the cod

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304703#comment-16304703 ] stack commented on HBASE-18294: --- bq. There is no consideration of the data size. Ok. > Re

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304697#comment-16304697 ] stack commented on HBASE-18294: --- bq. ... we say it loudly that 128 MB region flush size mea

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304683#comment-16304683 ] Anoop Sam John commented on HBASE-18294: bq. Is that the right way to do accounti

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304679#comment-16304679 ] stack commented on HBASE-18294: --- bq. But change the meaning of heapSize itself Yeah, t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304674#comment-16304674 ] Anoop Sam John commented on HBASE-18294: Yes Stack. That is why we have || check

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304671#comment-16304671 ] stack commented on HBASE-18294: --- bq. dataSize > flushSize || heapSize >flushSize You are t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304669#comment-16304669 ] Anoop Sam John commented on HBASE-18294: For now data+overhead check for both al

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304667#comment-16304667 ] Anoop Sam John commented on HBASE-18294: I can not some how agree to ur reasoning

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304665#comment-16304665 ] stack commented on HBASE-18294: --- [~eshcar] Yeah, working on trying to figure whey ITBLL can

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304535#comment-16304535 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304514#comment-16304514 ] Eshcar Hillel commented on HBASE-18294: --- My previous solution had three different c

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304477#comment-16304477 ] ramkrishna.s.vasudevan commented on HBASE-18294: Yes. That is my concern

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304469#comment-16304469 ] Anoop Sam John commented on HBASE-18294: bq.we make flush decisions based on heap

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304452#comment-16304452 ] ramkrishna.s.vasudevan commented on HBASE-18294: Am not before a system s

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-27 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304443#comment-16304443 ] Eshcar Hillel commented on HBASE-18294: --- Thanks all for the reviews, attached a new

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304247#comment-16304247 ] stack commented on HBASE-18294: --- I tried running this patch to see if it would help w/ HBAS

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303972#comment-16303972 ] stack commented on HBASE-18294: --- bq. "The main change is that in store level and region lev

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303969#comment-16303969 ] Hadoop QA commented on HBASE-18294: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303858#comment-16303858 ] Eshcar Hillel commented on HBASE-18294: --- QA passed I would like to commit this in t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303751#comment-16303751 ] Hadoop QA commented on HBASE-18294: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-26 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303629#comment-16303629 ] Eshcar Hillel commented on HBASE-18294: --- I did not change the global level - see cu

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303437#comment-16303437 ] Anoop Sam John commented on HBASE-18294: bq.Note that with the new patch heap siz

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303408#comment-16303408 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303360#comment-16303360 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-25 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303287#comment-16303287 ] Eshcar Hillel commented on HBASE-18294: --- Sorry [~ram_krish] I missed you comment.

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302916#comment-16302916 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302854#comment-16302854 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-22 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301190#comment-16301190 ] ramkrishna.s.vasudevan commented on HBASE-18294: bq.If we compare the dat

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-21 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300507#comment-16300507 ] Eshcar Hillel commented on HBASE-18294: --- Hey [~jmspaggi], We are definitely going t

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-21 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1638#comment-1638 ] Jean-Marc Spaggiari commented on HBASE-18294: - [~eshcar] trying to understand

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299852#comment-16299852 ] Hadoop QA commented on HBASE-18294: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-21 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299712#comment-16299712 ] Eshcar Hillel commented on HBASE-18294: --- I attached a new patch, much thinner. MemS

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-12-05 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279774#comment-16279774 ] Edward Bortnikov commented on HBASE-18294: -- Chiming in ... This question seems

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269079#comment-16269079 ] Anoop Sam John commented on HBASE-18294: bq.My view is that off-heap can be a tab

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-28 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268647#comment-16268647 ] Eshcar Hillel commented on HBASE-18294: --- I think I understand where our different v

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268600#comment-16268600 ] Anoop Sam John commented on HBASE-18294: Ya as I said in above comments, we can c

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-26 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265945#comment-16265945 ] Eshcar Hillel commented on HBASE-18294: --- Ram and Anoop, the reason we see so much h

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-23 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264983#comment-16264983 ] ramkrishna.s.vasudevan commented on HBASE-18294: bq.I mean reducing the e

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264979#comment-16264979 ] Anoop Sam John commented on HBASE-18294: bq.I think this is why the argument of i

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264978#comment-16264978 ] Anoop Sam John commented on HBASE-18294: Ya all that observation make sense. On h

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-23 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264974#comment-16264974 ] ramkrishna.s.vasudevan commented on HBASE-18294: bq.First, I noticed that

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-23 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264459#comment-16264459 ] Eshcar Hillel commented on HBASE-18294: --- I am back with some numbers. First, I noti

[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2017-11-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260502#comment-16260502 ] ramkrishna.s.vasudevan commented on HBASE-18294: We were discussing inter

  1   2   >