[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-06-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527082#comment-16527082 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-06-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527081#comment-16527081 ] Mike Drob commented on HBASE-19753: --- [~stack] - can we resolve this and open a new iss

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323349#comment-16323349 ] Hudson commented on HBASE-19753: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322816#comment-16322816 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322699#comment-16322699 ] stack commented on HBASE-19753: --- Ok. Compound patch is hanging on my dodgy hardware... its

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322568#comment-16322568 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322505#comment-16322505 ] stack commented on HBASE-19753: --- Did some quick tests this morning. Replacing the wait-on-c

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322200#comment-16322200 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321986#comment-16321986 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321975#comment-16321975 ] stack commented on HBASE-19753: --- bq. Then how about modifying the UTs only as I described a

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321907#comment-16321907 ] Duo Zhang commented on HBASE-19753: --- The approach in v7 is fine. +1. > Miscellany of f

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321898#comment-16321898 ] stack commented on HBASE-19753: --- .007 Change how we wait on connection in ROZKClient. Don't

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321897#comment-16321897 ] Duo Zhang commented on HBASE-19753: --- Then how about modifying the UTs only as I describ

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321887#comment-16321887 ] stack commented on HBASE-19753: --- I can't commit this patch. As is it makes TestAdmin2 fail.

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321725#comment-16321725 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321703#comment-16321703 ] Duo Zhang commented on HBASE-19753: --- +1. > Miscellany of fixes for hbase-zookeeper tes

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321702#comment-16321702 ] stack commented on HBASE-19753: --- Yeah, this patch has been running last couple of hours and

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321699#comment-16321699 ] stack commented on HBASE-19753: --- .006 fixes checkstyle. Will push this soon. Shout if have

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321633#comment-16321633 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321603#comment-16321603 ] stack commented on HBASE-19753: --- .004 implements the [~Apache9] suggestion removing dupe'd

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321598#comment-16321598 ] Hadoop QA commented on HBASE-19753: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321592#comment-16321592 ] stack commented on HBASE-19753: --- Running .003 on three machines in a loop, TestReadOnlyZKCl

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321561#comment-16321561 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321552#comment-16321552 ] Duo Zhang commented on HBASE-19753: --- +1 on the approach of patch v3. But let's introduc

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321549#comment-16321549 ] stack commented on HBASE-19753: --- .002 adds wait to getZK in ReadOnlyZKClient. .003 Fixes a

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321483#comment-16321483 ] Duo Zhang commented on HBASE-19753: --- I think add a wait until connected in getZk could

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321471#comment-16321471 ] stack commented on HBASE-19753: --- This is on a linux machine: $ more /etc/issue Ubuntu 14.04

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321467#comment-16321467 ] Duo Zhang commented on HBASE-19753: --- {code} conf.setInt(ReadOnlyZKClient.KEEPALIVE_MILL

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321450#comment-16321450 ] Duo Zhang commented on HBASE-19753: --- The problem is that, the keepalive time is too sma

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321416#comment-16321416 ] stack commented on HBASE-19753: --- Let me dump this info in here in case it helps... I'm lo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321356#comment-16321356 ] Duo Zhang commented on HBASE-19753: --- Will take a look soon. > Miscellany of fixes for

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321348#comment-16321348 ] stack commented on HBASE-19753: --- This is pretty: 125 2018-01-10 15:23:26,648 WARN [ReadO

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321345#comment-16321345 ] stack commented on HBASE-19753: --- Thanks for taking a look [~Apache9] Here is info. Here is

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321300#comment-16321300 ] Hadoop QA commented on HBASE-19753: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321282#comment-16321282 ] Duo Zhang commented on HBASE-19753: --- I'm OK with the waiting until connected modificati

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321273#comment-16321273 ] Duo Zhang commented on HBASE-19753: --- Mind uploading the whole surefire output file for

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321264#comment-16321264 ] stack commented on HBASE-19753: --- [~Apache9] you ok w/ my committing this. Got a good test r

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321257#comment-16321257 ] stack commented on HBASE-19753: --- Whoops. I'd actually put aside errors and meant to add the

[jira] [Commented] (HBASE-19753) Miscellany of fixes for hbase-zookeeper tests to make them more robust

2018-01-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321225#comment-16321225 ] Duo Zhang commented on HBASE-19753: --- Could you please post some logs about your failure