[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416686#comment-16416686 ] Hudson commented on HBASE-20212: Results for branch HBASE-19064 [build #77 on

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411438#comment-16411438 ] Hudson commented on HBASE-20212: Results for branch master [build #270 on

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410352#comment-16410352 ] Hudson commented on HBASE-20212: Results for branch branch-2.0 [build #75 on

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409902#comment-16409902 ] Hudson commented on HBASE-20212: Results for branch branch-2 [build #516 on

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-22 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409314#comment-16409314 ] Chia-Ping Tsai commented on HBASE-20212: Will commit it later.. > Make all Public classes have

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409179#comment-16409179 ] Hadoop QA commented on HBASE-20212: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-21 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408889#comment-16408889 ] Chia-Ping Tsai commented on HBASE-20212: -HBASE-20246- is resolved so the patch to branch-2 need

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408839#comment-16408839 ] Hadoop QA commented on HBASE-20212: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408257#comment-16408257 ] stack commented on HBASE-20212: --- Retry. This patch is great. +1 for branch-2.0 and branch-2. > Make all

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-21 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407672#comment-16407672 ] Chia-Ping Tsai commented on HBASE-20212: TestFromClientSide3WoUnsafe pass locally. the docs error

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407566#comment-16407566 ] Hadoop QA commented on HBASE-20212: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-20 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407333#comment-16407333 ] Chia-Ping Tsai commented on HBASE-20212: Thank [~yuzhih...@gmail.com]. Try patch for branch-2 >

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406537#comment-16406537 ] Ted Yu commented on HBASE-20212: lgtm > Make all Public classes have InterfaceAudience category >

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406459#comment-16406459 ] Hadoop QA commented on HBASE-20212: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-20 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406041#comment-16406041 ] Chia-Ping Tsai commented on HBASE-20212: https://reviews.apache.org/r/66172/ > Make all Public

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-18 Thread Christopher Tubbs (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404092#comment-16404092 ] Christopher Tubbs commented on HBASE-20212: --- I haven't benchmarked it, but I'd expect a second

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-18 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404012#comment-16404012 ] Chia-Ping Tsai commented on HBASE-20212: {quote}So i guess, regex lookahead method is the

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-18 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403922#comment-16403922 ] Appy commented on HBASE-20212: -- Checked the plugin code (https://github.com/revelc/warbucks-maven-plugin),

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-17 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403872#comment-16403872 ] Chia-Ping Tsai commented on HBASE-20212: {quote}Thrift classes are generated too. {quote} Thanks

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403697#comment-16403697 ] stack commented on HBASE-20212: --- Thrift classes are generated too. Otherwise sounds good sir. > Make all

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-17 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403480#comment-16403480 ] Chia-Ping Tsai commented on HBASE-20212: {quote}yeah, can do few modules at a time to chunk up

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-17 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403310#comment-16403310 ] Appy commented on HBASE-20212: -- yeah, can do few modules at a time to chunk up the work. > Make all Public

[jira] [Commented] (HBASE-20212) Make all Public classes have InterfaceAudience category

2018-03-15 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401351#comment-16401351 ] Chia-Ping Tsai commented on HBASE-20212: It will be a big patch. Perhaps we should create the