[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608231#comment-16608231
]
Hudson commented on HBASE-21001:
Results for branch branch-2.0
[build #787 on
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608068#comment-16608068
]
Guangxu Cheng commented on HBASE-21001:
---
Pushed to branch-2.0 and create new issue HBASE-21173 to
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608066#comment-16608066
]
Guangxu Cheng commented on HBASE-21001:
---
bq. Nit: we don't need to call region.close explicitly in
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608051#comment-16608051
]
Hudson commented on HBASE-21001:
Results for branch master
[build #480 on
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607742#comment-16607742
]
Hudson commented on HBASE-21001:
Results for branch branch-2.1
[build #293 on
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607740#comment-16607740
]
Hudson commented on HBASE-21001:
Results for branch branch-2
[build #1216 on
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607648#comment-16607648
]
Mingliang Liu commented on HBASE-21001:
---
Nit: we don't need to call {{region.close}} explicitly in
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607498#comment-16607498
]
Hadoop QA commented on HBASE-21001:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607285#comment-16607285
]
Guangxu Cheng commented on HBASE-21001:
---
pushed to master, branch-2 and branch-2.1.
'branch-2.0'
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606604#comment-16606604
]
Guangxu Cheng commented on HBASE-21001:
---
QA looks good. I will commit it late this day if no other
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606562#comment-16606562
]
Wei-Chiu Chuang commented on HBASE-21001:
-
I can confirm the test fails without the fix, and
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606288#comment-16606288
]
Hadoop QA commented on HBASE-21001:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606272#comment-16606272
]
Hadoop QA commented on HBASE-21001:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606232#comment-16606232
]
Hadoop QA commented on HBASE-21001:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606047#comment-16606047
]
Ted Yu commented on HBASE-21001:
+1
Thanks for working late.
> ReplicationObserver fails to load in
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606030#comment-16606030
]
Ted Yu commented on HBASE-21001:
{code}
8686(plugins == "" ? "" : (plugins + ",")) +
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605984#comment-16605984
]
Guangxu Cheng commented on HBASE-21001:
---
Attach 003 patch as [~yuzhih...@gmail.com]
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605907#comment-16605907
]
Ted Yu commented on HBASE-21001:
Looks good overall.
{code}
+ if
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605767#comment-16605767
]
Guangxu Cheng commented on HBASE-21001:
---
OK, let's add a unit test in {{TestHRegion}} to check
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605319#comment-16605319
]
Wei-Chiu Chuang commented on HBASE-21001:
-
[~andrewcheng] thanks for the patch. Looks good to
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605230#comment-16605230
]
Guangxu Cheng commented on HBASE-21001:
---
All tests pass locally. Checked the test report, these
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601964#comment-16601964
]
Hadoop QA commented on HBASE-21001:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601778#comment-16601778
]
Guangxu Cheng commented on HBASE-21001:
---
All tests pass locally. These failed tests are unrelated
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601766#comment-16601766
]
Hadoop QA commented on HBASE-21001:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601245#comment-16601245
]
Wei-Chiu Chuang commented on HBASE-21001:
-
Yes thanks for the patch. That's exactly where the
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601158#comment-16601158
]
Ashish Singhi commented on HBASE-21001:
---
lgtm
> ReplicationObserver fails to load in HBase 2.0.0
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601143#comment-16601143
]
Guangxu Cheng commented on HBASE-21001:
---
Upload the first patch for review. cc:
[
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601140#comment-16601140
]
Guangxu Cheng commented on HBASE-21001:
---
{code:title=HRegionServer.java|borderStyle=solid}
28 matches
Mail list logo
