[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593998#comment-16593998
]
Mingliang Liu commented on HBASE-21071:
---
Thank you very much [~stack], [~yuzhih...
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594317#comment-16594317
]
Hudson commented on HBASE-21071:
Results for branch branch-2
[build #1173 on
bu
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594583#comment-16594583
]
Hudson commented on HBASE-21071:
Results for branch master
[build #461 on
build
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584507#comment-16584507
]
Mingliang Liu commented on HBASE-21071:
---
ping [~te...@apache.org] and [~stack]. Th
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584511#comment-16584511
]
Ted Yu commented on HBASE-21071:
Overall, I like this initiative.
It seems the Builder
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584522#comment-16584522
]
stack commented on HBASE-21071:
---
Thank you for taking this up [~liuml07].
Should it be St
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584529#comment-16584529
]
stack commented on HBASE-21071:
---
Or, I just took a look... startMiniCluster method starts
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584586#comment-16584586
]
Mingliang Liu commented on HBASE-21071:
---
Thanks [~yuzhih...@gmail.com] and [~stack
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584741#comment-16584741
]
Mingliang Liu commented on HBASE-21071:
---
{quote}
It seems the Builder can be a cla
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584753#comment-16584753
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585017#comment-16585017
]
stack commented on HBASE-21071:
---
bq. ... so I think HBase cluster (option) builder also ma
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585018#comment-16585018
]
stack commented on HBASE-21071:
---
Man. This stuff is a mess. Your patch helps a load.
I sa
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585031#comment-16585031
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585101#comment-16585101
]
Mingliang Liu commented on HBASE-21071:
---
Thanks [~stack] for prompt review and hel
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585109#comment-16585109
]
Duo Zhang commented on HBASE-21071:
---
Our testing framework is a bit messy, IIRC, the H
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585110#comment-16585110
]
Duo Zhang commented on HBASE-21071:
---
And I like the approach here, Builder pattern is
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585146#comment-16585146
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586689#comment-16586689
]
Mingliang Liu commented on HBASE-21071:
---
[~Apache9] Thanks for the input. I unders
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586713#comment-16586713
]
stack commented on HBASE-21071:
---
bq. However, I have no idea about HBase's commitment to I
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586914#comment-16586914
]
Hadoop QA commented on HBASE-21071:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586935#comment-16586935
]
Mingliang Liu commented on HBASE-21071:
---
Thanks [~stack]. That makes perfect sense
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586968#comment-16586968
]
stack commented on HBASE-21071:
---
Excellent.
> HBaseTestingUtility::startMiniCluster() to
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587096#comment-16587096
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588161#comment-16588161
]
Mingliang Liu commented on HBASE-21071:
---
The v4 patch seems good to Hadoop QA (exc
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588190#comment-16588190
]
Ted Yu commented on HBASE-21071:
HBaseTestingUtility is annotated @InterfaceAudience.Pub
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588358#comment-16588358
]
Mingliang Liu commented on HBASE-21071:
---
{quote}
Shouldn't StartMiniClusterOption
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588378#comment-16588378
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588391#comment-16588391
]
Mingliang Liu commented on HBASE-21071:
---
The only failing test {{TestSyncReplicati
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588576#comment-16588576
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589201#comment-16589201
]
Mingliang Liu commented on HBASE-21071:
---
The failing test for {{branch-2}} is inte
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589402#comment-16589402
]
stack commented on HBASE-21071:
---
I +1'd it up on rb [~liuml07] (There is a small question
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589638#comment-16589638
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589674#comment-16589674
]
stack commented on HBASE-21071:
---
Failures seem unrelated. Retry.
> HBaseTestingUtility::s
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589713#comment-16589713
]
Mingliang Liu commented on HBASE-21071:
---
The failing tests can pass locally, and s
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589866#comment-16589866
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590228#comment-16590228
]
stack commented on HBASE-21071:
---
Random failures. One more try then will commit.
> HBaseT
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590231#comment-16590231
]
stack commented on HBASE-21071:
---
Although, this is second failure of TestFlushWithThroughp
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590586#comment-16590586
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590600#comment-16590600
]
stack commented on HBASE-21071:
---
Yeah, same tests fail. Maybe we changed the configs for t
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590623#comment-16590623
]
Mingliang Liu commented on HBASE-21071:
---
Thanks [~stack]. I wish I changed the con
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590626#comment-16590626
]
Mingliang Liu commented on HBASE-21071:
---
Oh, I see [~yuzhih...@gmail.com] provided
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590636#comment-16590636
]
stack commented on HBASE-21071:
---
Ok. Retrying this patch and +1'd over in HBASE-21097
> H
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590870#comment-16590870
]
Hadoop QA commented on HBASE-21071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590877#comment-16590877
]
Mingliang Liu commented on HBASE-21071:
---
Interesting. {{TestFlushWithThroughputCon
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591049#comment-16591049
]
Hadoop QA commented on HBASE-21071:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591063#comment-16591063
]
Mingliang Liu commented on HBASE-21071:
---
More than happy. Thanks [~stack].
> HBas
46 matches
Mail list logo