[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632756#comment-16632756 ] Duo Zhang commented on HBASE-21250: --- I have to say that it is really difficult to unde

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633012#comment-16633012 ] Duo Zhang commented on HBASE-21250: --- I plan to change the 'updated' to 'modified', it

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633026#comment-16633026 ] Duo Zhang commented on HBASE-21250: --- This is the patch by now. Not finished yet. Still

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633030#comment-16633030 ] Duo Zhang commented on HBASE-21250: --- Review board link: https://reviews.apache.org/r/

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-29 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633171#comment-16633171 ] Allan Yang commented on HBASE-21250: Great job! I will try to read these nice commen

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-30 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633373#comment-16633373 ] Duo Zhang commented on HBASE-21250: --- Add more comments and renaming ambiguous names. S

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-30 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633374#comment-16633374 ] Duo Zhang commented on HBASE-21250: --- Ping [~stack], if you have time please take a loo

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633421#comment-16633421 ] Hadoop QA commented on HBASE-21250: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-09-30 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633649#comment-16633649 ] Duo Zhang commented on HBASE-21250: --- There are already plenty of comments for the WALP

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633819#comment-16633819 ] Hadoop QA commented on HBASE-21250: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640699#comment-16640699 ] Hadoop QA commented on HBASE-21250: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641004#comment-16641004 ] Duo Zhang commented on HBASE-21250: --- Let me commit. > Refactor WALProcedureStore and

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641112#comment-16641112 ] Hudson commented on HBASE-21250: Results for branch branch-2.0 [build #917 on b

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641118#comment-16641118 ] Hudson commented on HBASE-21250: Results for branch branch-2 [build #1354 on bu

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641144#comment-16641144 ] Hudson commented on HBASE-21250: Results for branch branch-2.1 [build #430 on b

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641835#comment-16641835 ] Hudson commented on HBASE-21250: Results for branch master [build #532 on build

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642073#comment-16642073 ] Hudson commented on HBASE-21250: Results for branch branch-2.0 [build #921 on b

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642247#comment-16642247 ] Hudson commented on HBASE-21250: Results for branch branch-2.1 [build #434 on b

[jira] [Commented] (HBASE-21250) Refactor WALProcedureStore and add more comments for better understanding the implementation

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642256#comment-16642256 ] Hudson commented on HBASE-21250: Results for branch branch-2 [build #1358 on bu