[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848320#comment-16848320
]
Hudson commented on HBASE-21991:
Results for branch branch-2.1
[build #1191 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848319#comment-16848319
]
Hudson commented on HBASE-21991:
Results for branch branch-2.2
[build #287 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842436#comment-16842436
]
Hudson commented on HBASE-21991:
Results for branch branch-2.2
[build #265 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842370#comment-16842370
]
Hudson commented on HBASE-21991:
Results for branch branch-1.4
[build #801 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842363#comment-16842363
]
Hudson commented on HBASE-21991:
Results for branch branch-2
[build #1897 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842187#comment-16842187
]
Sean Busbey commented on HBASE-21991:
-
updated the release note. Thanks for pushing on this
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842083#comment-16842083
]
Hudson commented on HBASE-21991:
Results for branch branch-1
[build #835 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842074#comment-16842074
]
Hudson commented on HBASE-21991:
Results for branch master
[build #1012 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841826#comment-16841826
]
Guanghao Zhang commented on HBASE-21991:
+1 for addendum. If no objections, I will commit it
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837441#comment-16837441
]
Andrew Purtell commented on HBASE-21991:
Looks like we only have one release candidate affected
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836826#comment-16836826
]
Sean Busbey commented on HBASE-21991:
-
addendum looks good to me.
I posted to dev@ here:
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836722#comment-16836722
]
Andrew Purtell commented on HBASE-21991:
When resolving please consider copying the below
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836715#comment-16836715
]
Sakthi commented on HBASE-21991:
Will upload an addendum patch with
{code:java}
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836712#comment-16836712
]
Andrew Purtell commented on HBASE-21991:
Let's mark it Private immediate. We can make a release
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836711#comment-16836711
]
Sakthi commented on HBASE-21991:
[~busbey] sounds good to me.
> Fix MetaMetrics issues - [Race
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836686#comment-16836686
]
Sean Busbey commented on HBASE-21991:
-
Agreed LossyCounting shouldn't be public. Maybe a quick
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836689#comment-16836689
]
Sean Busbey commented on HBASE-21991:
-
sorry for the unclear phrasing. to be clear, I plan to do the
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836511#comment-16836511
]
Andrew Purtell commented on HBASE-21991:
I'm hard pressed to see why we would want to offer
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836250#comment-16836250
]
Peter Somogyi commented on HBASE-21991:
---
[~jatsakthi], both of the constructor signatures of
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802458#comment-16802458
]
stack commented on HBASE-21991:
---
Oh. That nice thing. Thanks for explanation. Let me add it as a link
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802435#comment-16802435
]
Sakthi commented on HBASE-21991:
MetaTable Metrics was implement in HBASE-19722, [~stack]. It's a
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802384#comment-16802384
]
stack commented on HBASE-21991:
---
This looks good. Whats metametrics? Thanks (maybe shove it into RNs?)
>
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799174#comment-16799174
]
Hudson commented on HBASE-21991:
Results for branch branch-1.4
[build #710 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798899#comment-16798899
]
Hudson commented on HBASE-21991:
Results for branch branch-1
[build #733 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798798#comment-16798798
]
Hudson commented on HBASE-21991:
Results for branch branch-2
[build #1767 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798790#comment-16798790
]
Xu Cang commented on HBASE-21991:
-
pushed to branch-1.4
Thanks [~jatsakthi] for all this good work!
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798783#comment-16798783
]
Xu Cang commented on HBASE-21991:
-
pushed to branch-1.
> Fix MetaMetrics issues - [Race condition,
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798758#comment-16798758
]
Hudson commented on HBASE-21991:
Results for branch master
[build #876 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798721#comment-16798721
]
Hudson commented on HBASE-21991:
Results for branch branch-2.1
[build #979 on
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798595#comment-16798595
]
Hadoop QA commented on HBASE-21991:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798472#comment-16798472
]
Sakthi commented on HBASE-21991:
Have uploaded a patch. Let's see what does the qa has to say.
> Fix
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798443#comment-16798443
]
Sakthi commented on HBASE-21991:
Will check.
> Fix MetaMetrics issues - [Race condition, Faulty remove
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798434#comment-16798434
]
Sakthi commented on HBASE-21991:
Thanks [~xucang]. I'll resubmit the patch to trigger the qa for
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798424#comment-16798424
]
Xu Cang commented on HBASE-21991:
-
Pushed to master, branch-1, branch-2.1
Master patch does not apply
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796659#comment-16796659
]
Sakthi commented on HBASE-21991:
Oh yes. "branch-1 & branch-1.4 doesn't have 20917(addendum) and 21800.
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796657#comment-16796657
]
Hadoop QA commented on HBASE-21991:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796654#comment-16796654
]
Sakthi commented on HBASE-21991:
Have uploaded a patch for branch-1. Waiting for qa.
> Fix MetaMetrics
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796561#comment-16796561
]
Sakthi commented on HBASE-21991:
Also, branch-2.0
> Fix MetaMetrics issues - [Race condition, Faulty
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796541#comment-16796541
]
Sakthi commented on HBASE-21991:
I'm not sure about branch-1.5 [~xucang] . Also I'm working on a patch
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796526#comment-16796526
]
Sakthi commented on HBASE-21991:
Thanks for your review [~apurtell]
> Fix MetaMetrics issues - [Race
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796529#comment-16796529
]
Xu Cang commented on HBASE-21991:
-
Will handle the commit tonight.
I plan to commit to master,
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793793#comment-16793793
]
Andrew Purtell commented on HBASE-21991:
+1
This should go into all branches where MetaMetrics
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789971#comment-16789971
]
Xu Cang commented on HBASE-21991:
-
+1 LGTM.
Thanks [~jatsakthi]
I will commit to master and branch-2.
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789972#comment-16789972
]
Sakthi commented on HBASE-21991:
I will [~xucang]. Thank you. Also I would like this in branch-2.1 as
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788836#comment-16788836
]
Hadoop QA commented on HBASE-21991:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788833#comment-16788833
]
Hadoop QA commented on HBASE-21991:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788675#comment-16788675
]
Hadoop QA commented on HBASE-21991:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788609#comment-16788609
]
Sakthi commented on HBASE-21991:
Thanks for your comments [~xucang]. I have updated the patch. Please
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788429#comment-16788429
]
Xu Cang commented on HBASE-21991:
-
very good analysis! And the patch looks great. [~jatsakthi]
I only
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787723#comment-16787723
]
Hadoop QA commented on HBASE-21991:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787510#comment-16787510
]
Sakthi commented on HBASE-21991:
Have updated the patch with your suggestions and few modifications.
>
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787455#comment-16787455
]
Sakthi commented on HBASE-21991:
[~xucang], Please ignore my above comment. I analyzed the possibilities
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786224#comment-16786224
]
Sakthi commented on HBASE-21991:
Oh yes! Thanks [~xucang], Somehow I overlooked that it's a
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786172#comment-16786172
]
Xu Cang commented on HBASE-21991:
-
I thought about the race condition you describe above again. It's a
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784538#comment-16784538
]
Hadoop QA commented on HBASE-21991:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784266#comment-16784266
]
Sakthi commented on HBASE-21991:
[~xucang], Open for your review! :)
> Fix MetaMetrics issues - [Race
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784001#comment-16784001
]
Xu Cang commented on HBASE-21991:
-
Thank you [~jatsakthi] ! Will review patch when available.
> Fix
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783983#comment-16783983
]
Sakthi commented on HBASE-21991:
Ping [~xucang] , [~apurtell] !
> Fix MetaMetrics issues - [Race
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783982#comment-16783982
]
Sakthi commented on HBASE-21991:
Regarding the race condition:
* With multiple rcp handler threads
[
https://issues.apache.org/jira/browse/HBASE-21991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783976#comment-16783976
]
Sakthi commented on HBASE-21991:
Regarding the faulty remove logic:
* According to the lossy counting
60 matches
Mail list logo
