[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-09-13 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455151#comment-13455151 ] Jesse Yates commented on HBASE-5456: Reviving this discussion after talking at recent

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214300#comment-13214300 ] Zhihong Yu commented on HBASE-5456: --- @Mikhail: Thanks for the reminder and pardon my mat

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214289#comment-13214289 ] Mikhail Bautin commented on HBASE-5456: --- On PowerMock: yes, I agree that in some cas

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214156#comment-13214156 ] Zhihong Yu commented on HBASE-5456: --- >From Jim on asynchbase mailing list: Works like a

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Jesse Yates (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214140#comment-13214140 ] Jesse Yates commented on HBASE-5456: I don't see it as that big of a deal that power m

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214131#comment-13214131 ] Zhihong Yu commented on HBASE-5456: --- bq. to define the test-only method as protected and

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214128#comment-13214128 ] Mikhail Bautin commented on HBASE-5456: --- I think most of our access restriction prob

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214119#comment-13214119 ] stack commented on HBASE-5456: -- I don't think that this is the kind of thing you can do by fi

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214039#comment-13214039 ] Zhihong Yu commented on HBASE-5456: --- If the following methods can be made protected or p

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214029#comment-13214029 ] Todd Lipcon commented on HBASE-5456: I tend to agree with Mikhail. The presence of a p

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214013#comment-13214013 ] Zhihong Yu commented on HBASE-5456: --- >From Ted Dunning: Actually jmockit uses byte code

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214006#comment-13214006 ] Zhihong Yu commented on HBASE-5456: --- My understanding is that Hadoop QA does run all tes

[jira] [Commented] (HBASE-5456) Introduce PowerMock into our unit tests to reduce unnecessary method exposure

2012-02-22 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213990#comment-13213990 ] Mikhail Bautin commented on HBASE-5456: --- I think this only makes sense for HBase if