[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536029#comment-13536029 ] Hadoop QA commented on HBASE-5778: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536047#comment-13536047 ] Jean-Daniel Cryans commented on HBASE-5778: --- [~ram_krish] I wasn't aware of it

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535650#comment-13535650 ] ramkrishna.s.vasudevan commented on HBASE-5778: --- @JD

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535665#comment-13535665 ] stack commented on HBASE-5778: -- I'm ok w/ committing it but I think it should be off in 0.96.

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533212#comment-13533212 ] stack commented on HBASE-5778: -- Good finds [~jdcryans]. Sounds like WAL compression could do

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532765#comment-13532765 ] Ted Yu commented on HBASE-5778: --- TestWALReplayCompressed passes with the rest of trunk

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532766#comment-13532766 ] Jean-Daniel Cryans commented on HBASE-5778: --- bq. Shall we keep this test ?

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532772#comment-13532772 ] Ted Yu commented on HBASE-5778: --- Thanks for the reminder, J-D. My question becomes: shall we

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532783#comment-13532783 ] Ted Yu commented on HBASE-5778: --- {code} + public HLog.Entry

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532784#comment-13532784 ] Jean-Daniel Cryans commented on HBASE-5778: --- bq. My question becomes: shall we

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532795#comment-13532795 ] Ted Yu commented on HBASE-5778: --- bq. is there anything in particular you think needs more

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532840#comment-13532840 ] Jean-Daniel Cryans commented on HBASE-5778: --- Turns out the patch fails in trunk

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532866#comment-13532866 ] Jean-Daniel Cryans commented on HBASE-5778: --- Figured it. First there's

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528430#comment-13528430 ] Jean-Daniel Cryans commented on HBASE-5778: --- bq. You have to explain the

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527669#comment-13527669 ] stack commented on HBASE-5778: -- reopen may not be too bad. You have to explain the

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497443#comment-13497443 ] stack commented on HBASE-5778: -- This is better. Here's some comments: Does

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497528#comment-13497528 ] Jean-Daniel Cryans commented on HBASE-5778: --- bq. Does CompressionContext class

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493453#comment-13493453 ] stack commented on HBASE-5778: -- Adding compression context to the general HLog Interface

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492967#comment-13492967 ] Ted Yu commented on HBASE-5778: --- Is the goal to turn on WAL compression by default ? If so,

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280311#comment-13280311 ] Jean-Daniel Cryans commented on HBASE-5778: --- I don't see how in theory the seek

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279927#comment-13279927 ] Li Pi commented on HBASE-5778: -- How far can replication lag behind our writes? If we can

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279939#comment-13279939 ] Lars Hofhansl commented on HBASE-5778: -- We do that guarantee (J-D, please correct me

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255203#comment-13255203 ] Jean-Daniel Cryans commented on HBASE-5778: --- bq. The files need to be read from

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255214#comment-13255214 ] Lars Hofhansl commented on HBASE-5778: -- If we could tail the logs it would work. We

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255225#comment-13255225 ] Jean-Daniel Cryans commented on HBASE-5778: --- I think everything is fine then :)

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255230#comment-13255230 ] Lars Hofhansl commented on HBASE-5778: -- Hmm... Then that does not explain what I saw.

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254136#comment-13254136 ] Zhihong Yu commented on HBASE-5778: --- I think ReplicationSource now has the additional

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254204#comment-13254204 ] Lars Hofhansl commented on HBASE-5778: -- @Ted: Unfortunately it is not as simple as

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253454#comment-13253454 ] stack commented on HBASE-5778: -- I backed it out of 0.94 and trunk. Turn on

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253522#comment-13253522 ] Hudson commented on HBASE-5778: --- Integrated in HBase-TRUNK #2752 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253529#comment-13253529 ] Jean-Daniel Cryans commented on HBASE-5778: --- Sorry for all the trouble guys, I

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253528#comment-13253528 ] Hudson commented on HBASE-5778: --- Integrated in HBase-0.94 #113 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253588#comment-13253588 ] Lars Hofhansl commented on HBASE-5778: -- I still don't understand why this is a

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253611#comment-13253611 ] Jean-Daniel Cryans commented on HBASE-5778: --- I haven't had a look, but I'd guess

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253614#comment-13253614 ] Lars Hofhansl commented on HBASE-5778: -- Oh I see. The KVs are only decompressed when

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253615#comment-13253615 ] Hudson commented on HBASE-5778: --- Integrated in HBase-0.94-security #9 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253636#comment-13253636 ] Hadoop QA commented on HBASE-5778: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253750#comment-13253750 ] Hudson commented on HBASE-5778: --- Integrated in HBase-TRUNK-security #170 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253995#comment-13253995 ] Lars Hofhansl commented on HBASE-5778: -- This fundamentally break replication. The

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252924#comment-13252924 ] Todd Lipcon commented on HBASE-5778: Do we have this in hbase-default.xml as well? if

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252927#comment-13252927 ] Jean-Daniel Cryans commented on HBASE-5778: --- It's not in there, do we want it

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252939#comment-13252939 ] Lars Hofhansl commented on HBASE-5778: -- +1 on patch Turn on WAL

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252947#comment-13252947 ] stack commented on HBASE-5778: -- +1 Add release note w/ how to turn it off

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252976#comment-13252976 ] Hudson commented on HBASE-5778: --- Integrated in HBase-TRUNK #2749 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253001#comment-13253001 ] Hudson commented on HBASE-5778: --- Integrated in HBase-0.94 #109 (See

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253053#comment-13253053 ] Lars Hofhansl commented on HBASE-5778: -- I see a bunch of suspicious test failures

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253058#comment-13253058 ] Lars Hofhansl commented on HBASE-5778: -- Yeah... The failures in TestHLog are because

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253061#comment-13253061 ] Lars Hofhansl commented on HBASE-5778: -- TestHLog.testAppendClose() uses this to read

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253063#comment-13253063 ] Lars Hofhansl commented on HBASE-5778: -- Then there's FaultySequenceFileLogReader,

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253065#comment-13253065 ] Lars Hofhansl commented on HBASE-5778: -- Have a fix for TestHLog, working on

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253091#comment-13253091 ] Lars Hofhansl commented on HBASE-5778: -- Similar... There're some other issues. I'll

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253107#comment-13253107 ] Ted Yu commented on HBASE-5778: --- {code} + } catch (IndexOutOfBoundsException iobe) { +

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253110#comment-13253110 ] Hadoop QA commented on HBASE-5778: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253118#comment-13253118 ] Lars Hofhansl commented on HBASE-5778: -- mvn failed with an OOME. Let's revert this

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253127#comment-13253127 ] Ted Yu commented on HBASE-5778: --- The remaining issue is about how the replication sink

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253138#comment-13253138 ] Hudson commented on HBASE-5778: --- Integrated in HBase-TRUNK-security #169 (See