[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534610#comment-13534610 ] Sergey Shelukhin commented on HBASE-7329: - Will have a patch tomorrow/later this w

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536305#comment-13536305 ] Sergey Shelukhin commented on HBASE-7329: - ok, have to read a lot of code to remov

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536765#comment-13536765 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537263#comment-13537263 ] Sergey Shelukhin commented on HBASE-7329: - TestDelayedRpc is flaky. TestLogRolling

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538335#comment-13538335 ] Sergey Shelukhin commented on HBASE-7329: - hmm... how do I nudge Hudson properly?

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538388#comment-13538388 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538475#comment-13538475 ] Sergey Shelukhin commented on HBASE-7329: - well, this is a real race condition...

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538561#comment-13538561 ] stack commented on HBASE-7329: -- Reapply the patch should get your patch rerun by hadoopqa.

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538569#comment-13538569 ] stack commented on HBASE-7329: -- On the patch, Sergey, are you convinced we can't make use of

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538601#comment-13538601 ] Sergey Shelukhin commented on HBASE-7329: - The race condition is actually the same

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538657#comment-13538657 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546440#comment-13546440 ] Sergey Shelukhin commented on HBASE-7329: - Hi. Ping? :) > remove

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546508#comment-13546508 ] Sergey Shelukhin commented on HBASE-7329: - rebased wrong patch, and then the corre

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546557#comment-13546557 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551390#comment-13551390 ] Sergey Shelukhin commented on HBASE-7329: - It looks like the patch doesn't contain

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554665#comment-13554665 ] Sergey Shelukhin commented on HBASE-7329: - /r/ at https://reviews.apache.org/r/896

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554721#comment-13554721 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554877#comment-13554877 ] chunhui shen commented on HBASE-7329: - Agree with removing that flush-related log. Pat

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555451#comment-13555451 ] Sergey Shelukhin commented on HBASE-7329: - When I diff the findbugs warnings from

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555808#comment-13555808 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555877#comment-13555877 ] Ted Yu commented on HBASE-7329: --- Since the patch doesn't involve generated protobuf files, l

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555888#comment-13555888 ] Ted Yu commented on HBASE-7329: --- You can produce diff between findbugs output of PreCommit b

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555950#comment-13555950 ] chunhui shen commented on HBASE-7329: - +1 on pacth v3 if warning is ok

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556495#comment-13556495 ] Ted Yu commented on HBASE-7329: --- This was how I generated the findbugs diff: diff 4066-newP

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556839#comment-13556839 ] Hadoop QA commented on HBASE-7329: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and reduce locking

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556851#comment-13556851 ] Ted Yu commented on HBASE-7329: --- Potentially we could have had a green PreCommit build. The

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559054#comment-13559054 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559055#comment-13559055 ] Sergey Shelukhin commented on HBASE-7329: - Integration tests have run without prob

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559067#comment-13559067 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559104#comment-13559104 ] stack commented on HBASE-7329: -- [~sershe] Thanks for running tests. +1 on commit.

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559122#comment-13559122 ] Ted Yu commented on HBASE-7329: --- HBASE-7268 has been checked in. I checked in and then reve

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559137#comment-13559137 ] Ted Yu commented on HBASE-7329: --- Patch v7 compiles based on latest trunk. TestHLog passes.

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559183#comment-13559183 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559192#comment-13559192 ] Ted Yu commented on HBASE-7329: --- Integrated to trunk. Thanks for the patch, Sergey. Thanks

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559205#comment-13559205 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK #3775 (See [https://builds.apach

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559250#comment-13559250 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #365 (See [https

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559274#comment-13559274 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK #3776 (See [https://builds.apach

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560889#comment-13560889 ] ramkrishna.s.vasudevan commented on HBASE-7329: --- Had time check this patch t

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560906#comment-13560906 ] Sergey Shelukhin commented on HBASE-7329: - Hmm... as I mentioned above actually I

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556854#comment-13556854 ] Ted Yu commented on HBASE-7329: --- [~stack]: Do you want to take another look ?

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556881#comment-13556881 ] chunhui shen commented on HBASE-7329: - Should we do the check {code} if (!force && thi

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556918#comment-13556918 ] Sergey Shelukhin commented on HBASE-7329: - Whoa, green precommit build! I thought

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556916#comment-13556916 ] Sergey Shelukhin commented on HBASE-7329: - No, this lock only protects concurrent

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556959#comment-13556959 ] chunhui shen commented on HBASE-7329: - bq.It's the same as synchronized method It's no

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556969#comment-13556969 ] Ted Yu commented on HBASE-7329: --- Was this part of code changed due to the following findbugs

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557426#comment-13557426 ] Sergey Shelukhin commented on HBASE-7329: - [~zjushch] good point, I'll move it ins

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557715#comment-13557715 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557725#comment-13557725 ] Ted Yu commented on HBASE-7329: --- [~stack], [~zjushch]: Do you have further comments ?

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557888#comment-13557888 ] chunhui shen commented on HBASE-7329: - +1 on patch v5 > remove flush-

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557941#comment-13557941 ] Ted Yu commented on HBASE-7329: --- Will integrate Monday (21st) morning if there is no further

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558167#comment-13558167 ] stack commented on HBASE-7329: -- Patch looks great. I like the analysis that is done in the b

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558973#comment-13558973 ] Sergey Shelukhin commented on HBASE-7329: - bq. Have you done much testing of this

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558984#comment-13558984 ] stack commented on HBASE-7329: -- bq. You mean rollWriter? I meant the fat log message we mak