[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556854#comment-13556854 ] Ted Yu commented on HBASE-7329: --- [~stack]: Do you want to take another look ?

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread chunhui shen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556881#comment-13556881 ] chunhui shen commented on HBASE-7329: - Should we do the check {code} if (!force && thi

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556918#comment-13556918 ] Sergey Shelukhin commented on HBASE-7329: - Whoa, green precommit build! I thought

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556916#comment-13556916 ] Sergey Shelukhin commented on HBASE-7329: - No, this lock only protects concurrent

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread chunhui shen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556959#comment-13556959 ] chunhui shen commented on HBASE-7329: - bq.It's the same as synchronized method It's no

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556969#comment-13556969 ] Ted Yu commented on HBASE-7329: --- Was this part of code changed due to the following findbugs

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-18 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557426#comment-13557426 ] Sergey Shelukhin commented on HBASE-7329: - [~zjushch] good point, I'll move it ins

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557715#comment-13557715 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557725#comment-13557725 ] Ted Yu commented on HBASE-7329: --- [~stack], [~zjushch]: Do you have further comments ?

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-18 Thread chunhui shen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557888#comment-13557888 ] chunhui shen commented on HBASE-7329: - +1 on patch v5 > remove flush-

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557941#comment-13557941 ] Ted Yu commented on HBASE-7329: --- Will integrate Monday (21st) morning if there is no further

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558167#comment-13558167 ] stack commented on HBASE-7329: -- Patch looks great. I like the analysis that is done in the b

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558973#comment-13558973 ] Sergey Shelukhin commented on HBASE-7329: - bq. Have you done much testing of this

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558984#comment-13558984 ] stack commented on HBASE-7329: -- bq. You mean rollWriter? I meant the fat log message we mak

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559054#comment-13559054 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559055#comment-13559055 ] Sergey Shelukhin commented on HBASE-7329: - Integration tests have run without prob

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559067#comment-13559067 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559104#comment-13559104 ] stack commented on HBASE-7329: -- [~sershe] Thanks for running tests. +1 on commit.

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559122#comment-13559122 ] Ted Yu commented on HBASE-7329: --- HBASE-7268 has been checked in. I checked in and then reve

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559137#comment-13559137 ] Ted Yu commented on HBASE-7329: --- Patch v7 compiles based on latest trunk. TestHLog passes.

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559183#comment-13559183 ] Hadoop QA commented on HBASE-7329: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559192#comment-13559192 ] Ted Yu commented on HBASE-7329: --- Integrated to trunk. Thanks for the patch, Sergey. Thanks

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559205#comment-13559205 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK #3775 (See [https://builds.apach

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559250#comment-13559250 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #365 (See [https

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559274#comment-13559274 ] Hudson commented on HBASE-7329: --- Integrated in HBase-TRUNK #3776 (See [https://builds.apach

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-23 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560889#comment-13560889 ] ramkrishna.s.vasudevan commented on HBASE-7329: --- Had time check this patch t

[jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular

2013-01-23 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560906#comment-13560906 ] Sergey Shelukhin commented on HBASE-7329: - Hmm... as I mentioned above actually I