[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795509#comment-13795509
]
Vladimir Rodionov commented on HBASE-9769:
--
Lars. I am going (finally) to create
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795519#comment-13795519
]
Vladimir Rodionov commented on HBASE-9769:
--
The main idea is to provide new Scann
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795547#comment-13795547
]
Ted Yu commented on HBASE-9769:
---
bq. Generally reseeks are better if they can skip many KVs.
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795559#comment-13795559
]
Vladimir Rodionov commented on HBASE-9769:
--
Ted, is this suggestion to change the
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795694#comment-13795694
]
Lars Hofhansl commented on HBASE-9769:
--
Also try with 0.94.12. The specific issue you
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796242#comment-13796242
]
Vladimir Rodionov commented on HBASE-9769:
--
In 0.94.12 the difference is not so d
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796311#comment-13796311
]
chunhui shen commented on HBASE-9769:
-
Move the logic of above patch to Scan class, is
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796331#comment-13796331
]
Vladimir Rodionov commented on HBASE-9769:
--
Its a server-side filter and is not m
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796345#comment-13796345
]
Lars Hofhansl commented on HBASE-9769:
--
Another idea I had was to make use of the col
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796348#comment-13796348
]
Vladimir Rodionov commented on HBASE-9769:
--
Lars, HTable can have small number of
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796408#comment-13796408
]
Lars Hofhansl commented on HBASE-9769:
--
Interestingly it depends on which column(s) i
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796411#comment-13796411
]
Lars Hofhansl commented on HBASE-9769:
--
Note that Vladimir's small row hint still can
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796417#comment-13796417
]
Lars Hofhansl commented on HBASE-9769:
--
bq. Lars, HTable can have small number of ver
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796426#comment-13796426
]
Vladimir Rodionov commented on HBASE-9769:
--
It contains check MAX_VERSIONS = 1 su
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796430#comment-13796430
]
Vladimir Rodionov commented on HBASE-9769:
--
It contains check MAX_VERSIONS = 1 su
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796431#comment-13796431
]
Vladimir Rodionov commented on HBASE-9769:
--
To activate this feature (hint):
{cod
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796433#comment-13796433
]
Vladimir Rodionov commented on HBASE-9769:
--
Lars, our patches are independent. I
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796434#comment-13796434
]
Lars Hofhansl commented on HBASE-9769:
--
MAX_VERSIONS=1 (or a low number) can only be
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796435#comment-13796435
]
Lars Hofhansl commented on HBASE-9769:
--
I created HBASE-9778 for my patch idea.
> I
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796436#comment-13796436
]
Lars Hofhansl commented on HBASE-9769:
--
Nit: Use the Eclipse formatter from HBASE-596
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796461#comment-13796461
]
Vladimir Rodionov commented on HBASE-9769:
--
Some additional performance numbers o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797167#comment-13797167
]
Hadoop QA commented on HBASE-9769:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797195#comment-13797195
]
Vladimir Rodionov commented on HBASE-9769:
--
What does *The patch command could no
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797224#comment-13797224
]
Ted Yu commented on HBASE-9769:
---
QA only applies patch on HBase trunk.
Can you attach patch
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797230#comment-13797230
]
Vladimir Rodionov commented on HBASE-9769:
--
I thought that I created patch for 0.
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797234#comment-13797234
]
Ted Yu commented on HBASE-9769:
---
This is what I meant with 'trunk':
http://svn.apache.org/re
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797524#comment-13797524
]
Hadoop QA commented on HBASE-9769:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797559#comment-13797559
]
Ted Yu commented on HBASE-9769:
---
Please add annotation for audience and stability:
{code}
+p
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797574#comment-13797574
]
Vladimir Rodionov commented on HBASE-9769:
--
1. Its not a client side filter (keep
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797680#comment-13797680
]
Lars Hofhansl commented on HBASE-9769:
--
Did some profiling on why reseek() is so much
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798643#comment-13798643
]
Ted Yu commented on HBASE-9769:
---
Minor comment:
{code}
+for (int i = 0; i < length; i++)
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798740#comment-13798740
]
Hadoop QA commented on HBASE-9769:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798748#comment-13798748
]
Ted Yu commented on HBASE-9769:
---
For ExplicitScanReplacementFilter:
{code}
+ * Copyright 201
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798819#comment-13798819
]
Hadoop QA commented on HBASE-9769:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798874#comment-13798874
]
Hadoop QA commented on HBASE-9769:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799235#comment-13799235
]
Vladimir Rodionov commented on HBASE-9769:
--
This patch has nothing to do with fai
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799607#comment-13799607
]
Ted Yu commented on HBASE-9769:
---
+1 from me.
Mind adding release note ?
> Improve performa
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799649#comment-13799649
]
Lars Hofhansl commented on HBASE-9769:
--
I would prefer if we just included the Filter
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799657#comment-13799657
]
Vladimir Rodionov commented on HBASE-9769:
--
Sure, it will be slower for rows abov
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799666#comment-13799666
]
Vladimir Rodionov commented on HBASE-9769:
--
I prefer keeping the existing version
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799670#comment-13799670
]
Ted Yu commented on HBASE-9769:
---
Since HStore is modified, this feature is not totally clien
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801214#comment-13801214
]
Lars Hofhansl commented on HBASE-9769:
--
Some comments:
* shouldUseExplicitColumnFilte
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801471#comment-13801471
]
Lars Hofhansl commented on HBASE-9769:
--
Lastly (and sorry for being difficult), why i
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801510#comment-13801510
]
Vladimir Rodionov commented on HBASE-9769:
--
Performance-wise, I think this filter
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801529#comment-13801529
]
Lars Hofhansl commented on HBASE-9769:
--
We should test end-to-end, not a microbenchma
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802059#comment-13802059
]
Vladimir Rodionov commented on HBASE-9769:
--
*Only with a coprocessor would it be
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802127#comment-13802127
]
stack commented on HBASE-9769:
--
Patch looks good caveat above questions. It was better havin
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802634#comment-13802634
]
chunhui shen commented on HBASE-9769:
-
HBASE-5987 would greatly improve the performanc
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803066#comment-13803066
]
stack commented on HBASE-9769:
--
Isn't HBASE-5987 committed on 0.94? If so, I wonder why we d
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803184#comment-13803184
]
stack commented on HBASE-9769:
--
Perhaps this was incorrectly forward-ported?
> Improve perfo
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803186#comment-13803186
]
Vladimir Rodionov commented on HBASE-9769:
--
Never mind, I was wrong. The code is
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803178#comment-13803178
]
Vladimir Rodionov commented on HBASE-9769:
--
I just checked trunk AbstractScannerV
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803203#comment-13803203
]
stack commented on HBASE-9769:
--
Do we see the benefit [~zjushch] talks of?
> Improve perform
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803206#comment-13803206
]
Vladimir Rodionov commented on HBASE-9769:
--
Interesting. We check if sought key i
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803209#comment-13803209
]
Vladimir Rodionov commented on HBASE-9769:
--
Looks like HBase-5987 and related JIR
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803214#comment-13803214
]
Vladimir Rodionov commented on HBASE-9769:
--
I think that HBASE-5987 does not wor
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803317#comment-13803317
]
stack commented on HBASE-9769:
--
HBASE-5987 was forward-ported as HBASE-6032 I reopened it.
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803319#comment-13803319
]
stack commented on HBASE-9769:
--
Or rather than reopen we should do a new issue.
> Improve pe
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804375#comment-13804375
]
Lars Hofhansl commented on HBASE-9769:
--
Let's do a new issue. HBASE-5987 is for resee
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804780#comment-13804780
]
Vladimir Rodionov commented on HBASE-9769:
--
Yes, I can confirm that on scan opera
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807632#comment-13807632
]
Chao Shi commented on HBASE-9769:
-
Hi folks,
I'm running into a similar problem (HBASE-98
[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807637#comment-13807637
]
Vladimir Rodionov commented on HBASE-9769:
--
Yes, its 1 HFile and all data was cac
62 matches
Mail list logo