Apache9 commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1325295375
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##
@@ -330,6 +322,73 @@ private boolean scheduleForRetry(IOException
virajjasani commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1325387382
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1718850992
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5401:
URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718864306
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 10s |
Apache-HBase commented on PR #5401:
URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718864359
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5401:
URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718895434
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache9 commented on code in PR #5401:
URL: https://github.com/apache/hbase/pull/5401#discussion_r1325503532
##
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java:
##
@@ -17,6 +17,8 @@
*/
package org.apache.hadoop.hbase.fs;
+import static
Apache9 opened a new pull request, #5401:
URL: https://github.com/apache/hbase/pull/5401
…ase of Hadoop3.3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #5401:
URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718898007
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
virajjasani commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1325395461
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws
zhangbutao commented on code in PR #5401:
URL: https://github.com/apache/hbase/pull/5401#discussion_r1325439479
##
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##
@@ -383,7 +400,7 @@ private static List>
Apache-HBase commented on PR #5405:
URL: https://github.com/apache/hbase/pull/5405#issuecomment-1721088253
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1721079638
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1721431777
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1721144416
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5403:
URL: https://github.com/apache/hbase/pull/5403#issuecomment-1721406772
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1721500608
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5335:
URL: https://github.com/apache/hbase/pull/5335#issuecomment-1721523389
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5403:
URL: https://github.com/apache/hbase/pull/5403#issuecomment-1721497863
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #5405:
URL: https://github.com/apache/hbase/pull/5405#issuecomment-1721084825
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5405:
URL: https://github.com/apache/hbase/pull/5405#issuecomment-1721085051
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5335:
URL: https://github.com/apache/hbase/pull/5335#issuecomment-1721229759
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache9 merged PR #5401:
URL: https://github.com/apache/hbase/pull/5401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5403:
URL: https://github.com/apache/hbase/pull/5403#issuecomment-1721121073
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5335:
URL: https://github.com/apache/hbase/pull/5335#issuecomment-1721587954
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1719163063
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1719245986
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5406:
URL: https://github.com/apache/hbase/pull/5406#issuecomment-1722156874
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5406:
URL: https://github.com/apache/hbase/pull/5406#issuecomment-1722157388
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
zhuyaogai opened a new pull request, #5406:
URL: https://github.com/apache/hbase/pull/5406
Detail: [HBASE-27853](https://issues.apache.org/jira/browse/HBASE-27853) and
backport for branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Apache-HBase commented on PR #5406:
URL: https://github.com/apache/hbase/pull/5406#issuecomment-1722123183
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
d-c-manning commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1327886285
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##
@@ -330,6 +330,56 @@ private boolean
frostruan closed pull request #4367: HBASE-26974 Introduce a LogRollProcedure
URL: https://github.com/apache/hbase/pull/4367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
NihalJain commented on code in PR #5407:
URL: https://github.com/apache/hbase/pull/5407#discussion_r1328004621
##
pom.xml:
##
@@ -856,7 +856,7 @@
2.1.43
1.0.57
2.12.2
-1.70
+1.76
Review Comment:
should we add an enforcer rule to ban
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1722364415
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1722367839
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
NihalJain commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722302815
First ran `mvn dependency:tree > original-tree.txt` without fix.
Output of `grep 'bouncycastle' original-tree.txt` is as follows:
```
$ grep 'bouncycastle' original-tree.txt
NihalJain commented on code in PR #5407:
URL: https://github.com/apache/hbase/pull/5407#discussion_r1328005368
##
pom.xml:
##
@@ -856,7 +856,7 @@
2.1.43
1.0.57
2.12.2
-1.70
+1.76
Review Comment:
Fixed, will undo this changes if others feel this is not
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722309013
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
NihalJain commented on code in PR #5407:
URL: https://github.com/apache/hbase/pull/5407#discussion_r1328005910
##
pom.xml:
##
@@ -856,7 +856,7 @@
2.1.43
1.0.57
2.12.2
-1.70
+1.76
Review Comment:
Verified the ban plugin is working correctly by deleting
virajjasani commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1328010092
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##
@@ -330,6 +330,56 @@ private boolean
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722369664
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722373649
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1722328824
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722353947
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
NihalJain merged PR #5387:
URL: https://github.com/apache/hbase/pull/5387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722423436
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5407:
URL: https://github.com/apache/hbase/pull/5407#issuecomment-1722426399
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722389900
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722426718
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 1s |
frostruan opened a new pull request, #5408:
URL: https://github.com/apache/hbase/pull/5408
**This PR tries to reimplement the log-roll procedure with proc-v2.**
**Modifies the following things**
**client side:**
instead of calling `admin.execProcedure()`, now we call
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722442599
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722529397
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722577245
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5408:
URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722575490
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5369:
URL: https://github.com/apache/hbase/pull/5369#issuecomment-1691436752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5369:
URL: https://github.com/apache/hbase/pull/5369#issuecomment-1691396786
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
ragarkar commented on code in PR #5342:
URL: https://github.com/apache/hbase/pull/5342#discussion_r1304112607
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetrics.java:
##
@@ -106,4 +106,6 @@ default String getVersion() {
@Nullable
List getTasks();
+ /**
anmolnar opened a new pull request, #5370:
URL: https://github.com/apache/hbase/pull/5370
Looks like HBase has 2 different prefixes for ZooKeeper properties:
`hbase.zookeeper.property.`
`hbase.client.zookeeper.property.`
and we also have these:
`hbase.zookeeper.quorum`
anmolnar commented on code in PR #5363:
URL: https://github.com/apache/hbase/pull/5363#discussion_r1304464029
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -83,9 +88,10 @@ public final class X509Util {
public static final String
Apache-HBase commented on PR #5370:
URL: https://github.com/apache/hbase/pull/5370#issuecomment-1691887726
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5370:
URL: https://github.com/apache/hbase/pull/5370#issuecomment-1691889829
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 43s |
Apache-HBase commented on PR #5370:
URL: https://github.com/apache/hbase/pull/5370#issuecomment-1691896272
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
wchevreuil commented on code in PR #5369:
URL: https://github.com/apache/hbase/pull/5369#discussion_r1304301738
##
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java:
##
@@ -158,6 +158,7 @@ public void testGrantGlobal1()
Apache-HBase commented on PR #5342:
URL: https://github.com/apache/hbase/pull/5342#issuecomment-1691771732
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5342:
URL: https://github.com/apache/hbase/pull/5342#issuecomment-1691780190
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5381:
URL: https://github.com/apache/hbase/pull/5381#issuecomment-1701426023
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5382:
URL: https://github.com/apache/hbase/pull/5382#issuecomment-1701955373
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1701830893
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5381:
URL: https://github.com/apache/hbase/pull/5381#issuecomment-1701730953
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
charlesconnell opened a new pull request, #5382:
URL: https://github.com/apache/hbase/pull/5382
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #5382:
URL: https://github.com/apache/hbase/pull/5382#issuecomment-1701957983
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5382:
URL: https://github.com/apache/hbase/pull/5382#issuecomment-1701954229
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1701985727
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
frostruan commented on PR #5381:
URL: https://github.com/apache/hbase/pull/5381#issuecomment-1702082826
this is indeed a problem. nice finding ! Thanks for the PR.
+1
Also, do you think if we can just make `submitSnapshotProcedure` a
`synchronized` method?
--
This is an
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1702016533
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5381:
URL: https://github.com/apache/hbase/pull/5381#issuecomment-1701736536
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5371:
URL: https://github.com/apache/hbase/pull/5371#issuecomment-1699257891
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
guluo2016 opened a new pull request, #5377:
URL: https://github.com/apache/hbase/pull/5377
Details see： HBASE-28051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #5378:
URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699399424
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5376:
URL: https://github.com/apache/hbase/pull/5376#issuecomment-1699449773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
ragarkar commented on code in PR #5376:
URL: https://github.com/apache/hbase/pull/5376#discussion_r1310267557
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -1477,6 +1477,7 @@ private void disableCache() {
// If persistent
wchevreuil commented on code in PR #5370:
URL: https://github.com/apache/hbase/pull/5370#discussion_r1310281661
##
hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java:
##
@@ -330,4 +341,27 @@ public static String
Apache-HBase commented on PR #5378:
URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699391089
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5378:
URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699410500
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
ankitsinghal commented on code in PR #5371:
URL: https://github.com/apache/hbase/pull/5371#discussion_r1310571851
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -1700,17 +1853,17 @@ public BucketEntry writeToCache(final IOEngine
Apache-HBase commented on PR #5392:
URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715777394
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5394:
URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715884281
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5394:
URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715924864
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 5s |
Apache-HBase commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1715970314
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716165368
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
ndimiduk commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1323068390
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1658,16 +1676,19 @@ private ByteBuff allocate(int size, boolean intoHeap) {
bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1323167385
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1700,6 +1721,21 @@ protected HFileBlock
hiping-tech commented on code in PR #5381:
URL: https://github.com/apache/hbase/pull/5381#discussion_r1323255457
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java:
##
@@ -670,11 +670,13 @@ public void takeSnapshot(SnapshotDescription
bbeaudreault commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1716136374
Oddly, I checked out the code locally and ran the UTs and they all pass. I
will try kicking off a new build once this one finishes.
--
This is an automated message from the Apache
Apache-HBase commented on PR #5397:
URL: https://github.com/apache/hbase/pull/5397#issuecomment-1716148748
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1715975167
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716187665
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5397:
URL: https://github.com/apache/hbase/pull/5397#issuecomment-1716202251
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
bbeaudreault commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716206315
Test failure looks unrelated. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
101 - 200 of 15440 matches
Mail list logo
