[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-21 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Attachment: HIVE-16449.05.patch Addressed review comments: - Created ConvertedOutputFile.java, and

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Status: Patch Available (was: Open) Let's see the PreCommit test results > BeeLineDriver should

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Attachment: HIVE-16449.patch Added the possibility to the OutputFile, to use the existing converters on

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Description: The CLI driver supports the following features: -- SORT_QUERY_RESULTS --

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Attachment: HIVE-16449.02.patch Removed – SORT_BEFORE_DIFF, since it is implemented differently >

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968956#comment-15968956 ] Peter Vary commented on HIVE-16146: --- Not related failures: - HIVE-15535 - Flaky test :

[jira] [Assigned] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16449: - > BeeLineDriver should handle query result sorting >

[jira] [Updated] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16146: -- Attachment: HIVE-16146.06.patch Rebased the patch. Since after the rebase the TestBeeLineDriver runs

[jira] [Commented] (HIVE-16416) Service: move constants out from HiveAuthFactory

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968706#comment-15968706 ] Peter Vary commented on HIVE-16416: --- +1 LGTM (non-binding) > Service: move constants out from

[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968710#comment-15968710 ] Peter Vary commented on HIVE-16355: --- Hi [~kgyrtkirk], How complicated would be to use serviceloader as

[jira] [Resolved] (HIVE-16320) Flaky test: TestBeeLineDriver.testCliDriver[escape_comments]

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary resolved HIVE-16320. --- Resolution: Done Fix Version/s: 3.0.0 Is should be solved by now... > Flaky test:

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969075#comment-15969075 ] Peter Vary commented on HIVE-16146: --- Checked the TestBeeLineDriver.testCliDriver[smb_mapjoin_11] error.

[jira] [Commented] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969081#comment-15969081 ] Peter Vary commented on HIVE-16451: --- Confirmed by adding sleep between the two method, like this:

[jira] [Assigned] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16451: - > Race condition between HiveStatement.getQueryLog and > HiveStatement.runAsyncOnServer >

[jira] [Assigned] (HIVE-16487) Serious Zookeeper exception is logged when a race condition happens

2017-04-20 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16487: - > Serious Zookeeper exception is logged when a race condition happens >

[jira] [Commented] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-20 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977107#comment-15977107 ] Peter Vary commented on HIVE-16451: --- [~vihangk1], [~ychena] could you please take a look? Thanks, Peter

[jira] [Updated] (HIVE-16487) Serious Zookeeper exception is logged when a race condition happens

2017-04-20 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16487: -- Status: Patch Available (was: Open) > Serious Zookeeper exception is logged when a race condition

[jira] [Updated] (HIVE-16487) Serious Zookeeper exception is logged when a race condition happens

2017-04-20 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16487: -- Attachment: HIVE-16487.patch The proposed patch: - Keeping the retying behavior - NONODE, and

[jira] [Updated] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16451: -- Status: Patch Available (was: Open) > Race condition between HiveStatement.getQueryLog and >

[jira] [Updated] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16451: -- Attachment: HIVE-16451.patch A patch to solve the current problem. Create a new method

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Attachment: HIVE-16449.03.patch Added null check, which caused test failures. > BeeLineDriver should

[jira] [Updated] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16467: -- Attachment: HIVE-16467.03.patch There were test infra problems, so the tests did not run > Flaky test:

[jira] [Assigned] (HIVE-16468) BeeLineDriver should be able to run tests against an externally created cluster

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16468: - > BeeLineDriver should be able to run tests against an externally created > cluster >

[jira] [Updated] (HIVE-16468) BeeLineDriver should be able to run tests against an externally created cluster

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16468: -- Description: It should be possible to run the query tests against an externally created cluster using

[jira] [Updated] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16467: -- Attachment: HIVE-16467.02.patch Cleaned up test files... > Flaky test:

[jira] [Updated] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16451: -- Component/s: JDBC > Race condition between HiveStatement.getQueryLog and >

[jira] [Commented] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972613#comment-15972613 ] Peter Vary commented on HIVE-16345: --- Thanks [~ychena] for the review and the commit! > BeeLineDriver

[jira] [Commented] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973179#comment-15973179 ] Peter Vary commented on HIVE-16467: --- This failed test is a known flaky, see: - HIVE-15776 - Flaky test:

[jira] [Commented] (HIVE-15751) Make it possible to run findbugs for itest modules as well

2017-03-09 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903405#comment-15903405 ] Peter Vary commented on HIVE-15751: --- Thanks for the review, and the commit! > Make it possible to run

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-03-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901471#comment-15901471 ] Peter Vary commented on HIVE-16146: --- Tested: - silent mode removes every message (PREHOOK, POSTHOOK) as

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-03-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901399#comment-15901399 ] Peter Vary commented on HIVE-16146: --- I can imagine 2 different approach: - Blacklist - Keeping every

[jira] [Updated] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-09 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16127: -- Attachment: HIVE-16127.03.patch Addressed RB comments, and rebased > Separate database initialization

[jira] [Updated] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16127: -- Attachment: HIVE-16127.02.patch Addressed review comments > Separate database initialization from

[jira] [Updated] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16127: -- Status: Patch Available (was: Open) > Separate database initialization from actual query run in

[jira] [Assigned] (HIVE-16152) TestBeeLineDriver logging improvements

2017-03-09 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16152: - > TestBeeLineDriver logging improvements > -- > >

[jira] [Commented] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-09 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903108#comment-15903108 ] Peter Vary commented on HIVE-16127: --- A green run! :) Failures are not related :D > Separate database

[jira] [Commented] (HIVE-16152) TestBeeLineDriver logging improvements

2017-03-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924243#comment-15924243 ] Peter Vary commented on HIVE-16152: --- The changed output: - diff problem: {code} Java HotSpot(TM) 64-Bit

[jira] [Updated] (HIVE-16152) TestBeeLineDriver logging improvements

2017-03-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16152: -- Attachment: HIVE-16152.patch First version. Please review [~kgyrtkirk], [~vihangk1], [~zsombor.klara],

[jira] [Updated] (HIVE-16152) TestBeeLineDriver logging improvements

2017-03-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16152: -- Status: Patch Available (was: Open) > TestBeeLineDriver logging improvements >

[jira] [Commented] (HIVE-16152) TestBeeLineDriver logging improvements

2017-03-13 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907121#comment-15907121 ] Peter Vary commented on HIVE-16152: --- I would prefer to use the result class created in the patch >

[jira] [Assigned] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-03-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16146: - > If possible find a better way to filter the TestBeeLineDriver output >

[jira] [Commented] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-13 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922954#comment-15922954 ] Peter Vary commented on HIVE-16127: --- And of course thanks [~vihangk1] and [~zsombor.klara] for the

[jira] [Commented] (HIVE-15616) Improve contents of qfile test output

2017-03-13 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922873#comment-15922873 ] Peter Vary commented on HIVE-15616: --- There is a missing file in the commit (QTestProcessExecResult)

[jira] [Commented] (HIVE-15616) Improve contents of qfile test output

2017-03-13 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922884#comment-15922884 ] Peter Vary commented on HIVE-15616: --- :) You were faster [~ashutoshc] :) > Improve contents of qfile

[jira] [Commented] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-13 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922896#comment-15922896 ] Peter Vary commented on HIVE-16127: --- Thanks [~kgyrtkirk] for the review and the commit! Eager to

[jira] [Assigned] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16127: - > Separate database initialization from actual query run in TestBeeLineDriver >

[jira] [Commented] (HIVE-16116) Beeline throws NPE when beeline.hiveconfvariables={} in beeline.properties

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897472#comment-15897472 ] Peter Vary commented on HIVE-16116: --- Errors not related. For the BeeLine one

[jira] [Commented] (HIVE-16089) "trustStorePassword" is logged as part of jdbc connection url

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898027#comment-15898027 ] Peter Vary commented on HIVE-16089: --- [~sfroehlich]: You could take a look at here:

[jira] [Commented] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897992#comment-15897992 ] Peter Vary commented on HIVE-16101: --- [~ngangam]: Yes, the first failures were because of {{No space left

[jira] [Commented] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899189#comment-15899189 ] Peter Vary commented on HIVE-16101: --- Thanks [~kgyrtkirk] for the review and the commit! > QTest failure

[jira] [Updated] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16127: -- Attachment: HIVE-16127.01.patch The first version. Open to suggestions, how to enhance. Please review.

[jira] [Commented] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

2017-03-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899596#comment-15899596 ] Peter Vary commented on HIVE-16127: --- CC: [~kgyrtkirk], [~ngangam], [~spena], [~vihangk1],

[jira] [Updated] (HIVE-16057) SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured

2017-03-04 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16057: -- Status: Patch Available (was: Reopened) Forgot to press submit patch button. Let's see what will

[jira] [Commented] (HIVE-16057) SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured

2017-03-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896558#comment-15896558 ] Peter Vary commented on HIVE-16057: --- The failures are not related. > SchemaTool ignores --passWord

[jira] [Updated] (HIVE-16057) SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured

2017-03-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16057: -- Attachment: HIVE-16057.03.patch Was not aware, that there are itests for SchemaTool too... Always

[jira] [Updated] (HIVE-16057) SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured

2017-03-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16057: -- Attachment: HIVE-16057.02.patch Build infrastructure failure: {code} + curl -s -S --location --retry 3

[jira] [Commented] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896501#comment-15896501 ] Peter Vary commented on HIVE-16101: --- [~ngangam]: Could you please review. I do not want the BeeLine

[jira] [Commented] (HIVE-16116) Beeline throws NPE when beeline.hiveconfvariables={} in beeline.properties

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896964#comment-15896964 ] Peter Vary commented on HIVE-16116: --- Thanks for the patch [~rajesh.balamohan]! Just a quick question: -

[jira] [Updated] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16101: -- Attachment: HIVE-16101.2.patch Thanks for the review [~kgyrtkirk]! Retriggering the precommit with the

[jira] [Commented] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897063#comment-15897063 ] Peter Vary commented on HIVE-16101: --- Failures are not related. > QTest failure BeeLine escape_comments

[jira] [Updated] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16101: -- Attachment: HIVE-16101.patch Patch removes the log lines before diff > QTest failure BeeLine

[jira] [Updated] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16101: -- Status: Patch Available (was: Open) > QTest failure BeeLine escape_comments after HIVE-16045 >

[jira] [Commented] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894095#comment-15894095 ] Peter Vary commented on HIVE-16101: --- [~kgyrtkirk]: Could you review please? Concurrent changes in

[jira] [Assigned] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

2017-03-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16101: - > QTest failure BeeLine escape_comments after HIVE-16045 >

[jira] [Updated] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

2017-04-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16345: -- Attachment: HIVE-16345.2.patch > BeeLineDriver should be able to run qtest files which are using

[jira] [Commented] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

2017-04-05 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956807#comment-15956807 ] Peter Vary commented on HIVE-16345: --- About the test results: - HIVE-15776 - Flaky test:

[jira] [Updated] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

2017-04-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16345: -- Attachment: HIVE-16345.3.patch Instead of the needsContinuation method refactor moved the getCommands

[jira] [Commented] (HIVE-16313) Flaky test: TestBeeLineDriver[drop_with_concurrency]

2017-04-06 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958346#comment-15958346 ] Peter Vary commented on HIVE-16313: --- [~vihangk1], thanks for reporting! Caused by these parallel

[jira] [Commented] (HIVE-16334) Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960376#comment-15960376 ] Peter Vary commented on HIVE-16334: --- The failed tests are not related: - TestBeeLineDriver error will be

[jira] [Commented] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

2017-04-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960385#comment-15960385 ] Peter Vary commented on HIVE-16345: --- Test failure not related: - HIVE-16387 - Fix failing test

[jira] [Updated] (HIVE-16007) When the query does not complie the LogRunnable never stops

2017-03-21 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16007: -- Attachment: HIVE-16007.6.patch The BeeLine tests error were relevant. The last lines of the log was not

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-04-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960928#comment-15960928 ] Peter Vary commented on HIVE-16146: --- [~kgyrtkirk], [~ychena], [~aihuaxu], [~vihangk1] you can review if

[jira] [Commented] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

2017-04-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960923#comment-15960923 ] Peter Vary commented on HIVE-16146: --- The test failures are not related: - HIVE-16405 - Flaky Test:

[jira] [Commented] (HIVE-16334) Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-07 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960825#comment-15960825 ] Peter Vary commented on HIVE-16334: --- Thanks for the commit [~ctang.ma]! Updated the document, added the

[jira] [Commented] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972328#comment-15972328 ] Peter Vary commented on HIVE-16451: --- This 2 are known flaky: - HIVE-15776 - Flaky test:

[jira] [Updated] (HIVE-16449) BeeLineDriver should handle query result sorting

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16449: -- Attachment: HIVE-16449.04.patch Rebased the patch, handled checkstyle and findbugs errors, and made it

[jira] [Updated] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

2017-04-14 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16451: -- Attachment: HIVE-16451.02.patch Addressed test failures > Race condition between

[jira] [Commented] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972263#comment-15972263 ] Peter Vary commented on HIVE-16467: --- Well, since every query has an {{ORDER BY}} clause, it is not a

[jira] [Commented] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972450#comment-15972450 ] Peter Vary commented on HIVE-16467: --- [~mmccline], the vector_order_null query file is added by

[jira] [Assigned] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-16467: - Assignee: Peter Vary > Flaky test: TestCliDriver.testCliDriver[vector_order_null] >

[jira] [Updated] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16467: -- Status: Patch Available (was: Open) > Flaky test: TestCliDriver.testCliDriver[vector_order_null] >

[jira] [Updated] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16467: -- Attachment: HIVE-16467.patch It is easier to create the patch, than describe :) > Flaky test:

[jira] [Commented] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

2017-04-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972534#comment-15972534 ] Peter Vary commented on HIVE-16467: --- Hi [~mmccline], Judging from the test name, the queries and the

[jira] [Commented] (HIVE-16357) Failed folder creation when creating a new table is reported incorrectly

2017-08-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108643#comment-16108643 ] Peter Vary commented on HIVE-16357: --- Thanks for the patch [~zsombor.klara]! I like this solution. +1

[jira] [Assigned] (HIVE-17230) Timestamp format different in HiveCLI and Beeline

2017-08-02 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary reassigned HIVE-17230: - > Timestamp format different in HiveCLI and Beeline >

[jira] [Commented] (HIVE-17230) Timestamp format different in HiveCLI and Beeline

2017-08-02 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110874#comment-16110874 ] Peter Vary commented on HIVE-17230: --- The root cause of the issue is, that HiveCLI writes out the value

[jira] [Commented] (HIVE-17230) Timestamp format different in HiveCLI and Beeline

2017-08-02 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110888#comment-16110888 ] Peter Vary commented on HIVE-17230: --- I have found this issue when I was trying to run several more tests

[jira] [Commented] (HIVE-16294) Support snapshot for truncate table

2017-08-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112497#comment-16112497 ] Peter Vary commented on HIVE-16294: --- There is a non public API to find out, if a directory is

[jira] [Commented] (HIVE-17144) export of temporary tables not working and it seems to be using distcp rather than filesystem copy

2017-08-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112539#comment-16112539 ] Peter Vary commented on HIVE-17144: --- Thanks [~zsombor.klara] for localizing this issue. Committed the

[jira] [Updated] (HIVE-16845) INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-08-03 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-16845: -- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available)

[jira] [Commented] (HIVE-16294) Support snapshot for truncate table

2017-08-04 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114161#comment-16114161 ] Peter Vary commented on HIVE-16294: --- +1 pending tests > Support snapshot for truncate table >

[jira] [Commented] (HIVE-17311) Numeric overflow in the HiveConf

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127405#comment-16127405 ] Peter Vary commented on HIVE-17311: --- [~olegd]: Could you please update the description field, to match

[jira] [Updated] (HIVE-17311) Numeric overflow in the HiveConf

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-17311: -- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available)

[jira] [Issue Comment Deleted] (HIVE-17311) Numeric overflow in the HiveConf

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-17311: -- Comment: was deleted (was: [~olegd]: Could you please update the description field, to match the patch

[jira] [Updated] (HIVE-17305) New insert overwrite dynamic partitions qtest need to have the golden file regenerated

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-17305: -- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available)

[jira] [Commented] (HIVE-17322) Serialise BeeLine qtest execution to prevent flakyness

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127401#comment-16127401 ] Peter Vary commented on HIVE-17322: --- +1 LGTM Could you please run the test 2-3 more times before commit

[jira] [Updated] (HIVE-17292) Change TestMiniSparkOnYarnCliDriver test configuration to use the configured cores

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-17292: -- Attachment: HIVE-17292.5.patch Well, this patch become huge :( The actual code/configuration change is

[jira] [Updated] (HIVE-17268) WebUI / QueryPlan: query plan is sometimes null when explain output conf is on

2017-08-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated HIVE-17268: -- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available)

[jira] [Commented] (HIVE-17292) Change TestMiniSparkOnYarnCliDriver test configuration to use the configured cores

2017-08-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128601#comment-16128601 ] Peter Vary commented on HIVE-17292: --- [~lirui]: HIVE-17292.3.patch is the version where we change only

[jira] [Commented] (HIVE-17325) Clean up intermittently failing uni tests

2017-08-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128616#comment-16128616 ] Peter Vary commented on HIVE-17325: --- Thanks [~alangates] to bring this up! I really hate these

<    1   2   3   4   5   6   7   8   9   10   >