Re: [PR] feat: Introduce basic file scan planning. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #129: URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1435998742 ## crates/iceberg/src/spec/schema.rs: ## @@ -32,16 +32,18 @@ use std::sync::Arc; use _serde::SchemaEnum; +/// Type alias for schema id. +pub type SchemaId

Re: [PR] feat: Add roadmap and features status in README.md [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #134: URL: https://github.com/apache/iceberg-rust/pull/134#discussion_r1435989666 ## README.md: ## @@ -21,6 +21,37 @@ Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/). +## RoadMap + +### Catalog + +| Catalog T

Re: [PR] feat: Add roadmap and features status in README.md [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #134: URL: https://github.com/apache/iceberg-rust/pull/134#discussion_r1435989344 ## README.md: ## @@ -21,6 +21,37 @@ Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/). +## RoadMap + +### Catalog + +| Catalog T

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986885 ## crates/iceberg/src/expr/unbound.rs: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986733 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986624 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435983199 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435982647 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [I] Iceberg does not work with other types of data lakes [iceberg]

2023-12-24 Thread via GitHub
BsoBird commented on issue #8624: URL: https://github.com/apache/iceberg/issues/8624#issuecomment-1868795070 @RussellSpitzer @amogh-jahagirdar Hi. Anything new on this subject? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[I] How does Iceberg support writing data to local paths, network disks, interfaces, and other storage media [iceberg]

2023-12-24 Thread via GitHub
smileyboy2019 opened a new issue, #9378: URL: https://github.com/apache/iceberg/issues/9378 ### Apache Iceberg version None ### Query engine None ### Please describe the bug 🐞 My data is stored locally or on Baidu Cloud. Can I directly write the data to a f

Re: [PR] Spark 3.5: Parallelize reading files in add_files procedure [iceberg]

2023-12-24 Thread via GitHub
manuzhang commented on PR #9274: URL: https://github.com/apache/iceberg/pull/9274#issuecomment-1868726591 @amogh-jahagirdar updated. Thanks for review. Merry Christmas 🎄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] com/fasterxml/jackson/core/exc/StreamConstraintsException [iceberg]

2023-12-24 Thread via GitHub
smileyboy2019 commented on issue #9355: URL: https://github.com/apache/iceberg/issues/9355#issuecomment-1868674881 gbicc.net data-lake 1.0-SNAPSHOT org.apache.maven.plugins maven-compiler-plugin

Re: [PR] feat: Add website layout [iceberg-rust]

2023-12-24 Thread via GitHub
Xuanwo commented on PR #130: URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1868673496 Thanks a lot, @bitsondatadev! --- @Fokko, what else needs to be done for this PR to be merged? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] How to improve write speed for data in the same partition? [iceberg]

2023-12-24 Thread via GitHub
coolderli commented on issue #9330: URL: https://github.com/apache/iceberg/issues/9330#issuecomment-1868649138 try to set `write.distribution-mode` to `none`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Add partition evolution [iceberg-python]

2023-12-24 Thread via GitHub
Fokko commented on issue #193: URL: https://github.com/apache/iceberg-python/issues/193#issuecomment-1868592509 @amogh-jahagirdar Feel free to go for it! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core: Use CharSequenceMap for writing unordered deletes [iceberg]

2023-12-24 Thread via GitHub
aokolnychyi commented on PR #9365: URL: https://github.com/apache/iceberg/pull/9365#issuecomment-1868576447 Thank you, @amogh-jahagirdar! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Core: Use CharSequenceMap for writing unordered deletes [iceberg]

2023-12-24 Thread via GitHub
aokolnychyi merged PR #9365: URL: https://github.com/apache/iceberg/pull/9365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [I] Add partition evolution [iceberg-python]

2023-12-24 Thread via GitHub
amogh-jahagirdar commented on issue #193: URL: https://github.com/apache/iceberg-python/issues/193#issuecomment-1868575943 If anyone's not already working on this @Fokko I'd love to try and take a stab at this! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
amogh-jahagirdar commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435850488 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreem

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1868530447 - Addressed Review comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435834977 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -134,8 +130,7 @@ private Table createPrimitiveTable()

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-24 Thread via GitHub
nastra merged PR #9368: URL: https://github.com/apache/iceberg/pull/9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Optimize manifest evaluation for super wide tables [iceberg]

2023-12-24 Thread via GitHub
Fokko commented on PR #9147: URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1868525212 Hey @irshadcc Sorry for the long wait here, and thanks for pinging me. Let's get this in 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435822390 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,217 @@ import org.apache.iceberg.catalog.TableIdentifie

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-24 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435813342 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Deliver key metadata to parquet encryption [iceberg]

2023-12-24 Thread via GitHub
ggershinsky commented on code in PR #9359: URL: https://github.com/apache/iceberg/pull/9359#discussion_r1435812202 ## core/src/main/java/org/apache/iceberg/avro/Avro.java: ## @@ -91,6 +92,13 @@ public static WriteBuilder write(OutputFile file) { return new WriteBuilder(file

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435807876 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1868493547 @vinitpatni just a few minor things, but should be ready to go once those are addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435806758 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -134,8 +130,7 @@ private Table createPrimitiveTable() thr

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435806371 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -76,7 +72,7 @@ protected TableEnvironment getTableEnv() {

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435805962 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,217 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435805795 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,217 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1868486503 - Revert as per original behaviour and moved parameters to CatalogTestBase and overrided the parameters in subclass as per need -- This is an automated message from the Apache Git Se

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435800371 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -18,270 +18,241 @@ */ package org.apache.iceberg.flink; -import

Re: [PR] Build: Bump guava from 32.1.3-jre to 33.0.0-jre [iceberg]

2023-12-24 Thread via GitHub
nastra merged PR #9373: URL: https://github.com/apache/iceberg/pull/9373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump arrow from 14.0.1 to 14.0.2 [iceberg]

2023-12-24 Thread via GitHub
nastra merged PR #9372: URL: https://github.com/apache/iceberg/pull/9372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435794998 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -18,270 +18,241 @@ */ package org.apache.iceberg.flink; -import jav

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435795062 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -40,28 +42,22 @@ import org.apache.iceberg.data.FileHelp

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435795062 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -40,28 +42,22 @@ import org.apache.iceberg.data.FileHelp

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-24 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435794998 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -18,270 +18,241 @@ */ package org.apache.iceberg.flink; -import jav

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.26.2 [iceberg-go]

2023-12-24 Thread via GitHub
dependabot[bot] opened a new pull request, #47: URL: https://github.com/apache/iceberg-go/pull/47 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.19.1 to 1.26.2. Commits https://github.com/aws/aws-sdk-go-v2/commit/732d6d70f2640e9cdf4430

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.26.1 [iceberg-go]

2023-12-24 Thread via GitHub
dependabot[bot] commented on PR #45: URL: https://github.com/apache/iceberg-go/pull/45#issuecomment-1868460488 Superseded by #47. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.26.1 [iceberg-go]

2023-12-24 Thread via GitHub
dependabot[bot] closed pull request #45: build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.26.1 URL: https://github.com/apache/iceberg-go/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Build: Bump mkdocs-material from 9.5.1 to 9.5.3 [iceberg]

2023-12-24 Thread via GitHub
Fokko merged PR #9376: URL: https://github.com/apache/iceberg/pull/9376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach