[PR] Exclude `docutils!=0.21` as a dependency [iceberg-python]

2024-04-17 Thread via GitHub
Fokko opened a new pull request, #615: URL: https://github.com/apache/iceberg-python/pull/615 This release is bodged, and causes Poetry to fail when it tries to fetch the tar: https://github.com/python-poetry/poetry/issues/9293#issuecomment-2048205226 It is being tracked:

Re: [PR] chore: update roadmap [iceberg-rust]

2024-04-17 Thread via GitHub
sdd commented on code in PR #336: URL: https://github.com/apache/iceberg-rust/pull/336#discussion_r1570012813 ## README.md: ## @@ -50,19 +50,19 @@ expand to other service. Reader | Feature| Status |

Re: [I] Timestamp/Day transform returns Date as required type while days is actually stored integer [iceberg]

2024-04-17 Thread via GitHub
manuzhang commented on issue #10159: URL: https://github.com/apache/iceberg/issues/10159#issuecomment-2063024043 @zinking You may check [this comment](https://github.com/apache/iceberg/issues/279#issuecomment-519620975) for the background. -- This is an automated message from the Apache

[I] TestDataFrameWrites#testFaultToleranceOnWrite failed due to exception in cleaning up temporary directory [iceberg]

2024-04-17 Thread via GitHub
manuzhang opened a new issue, #10172: URL: https://github.com/apache/iceberg/issues/10172 ### Apache Iceberg version main (development) ### Query engine Spark ### Please describe the bug  ``` TestDataFrameWrites > testFaultToleranceOnWrite() > format =

Re: [PR] Sql catalog [iceberg-rust]

2024-04-17 Thread via GitHub
himadripal commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2062991628 @JanKaul WDYT? I think this PR is ready for review, I can add the update and delete in a separate PR. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Add metadata tables [iceberg-python]

2024-04-17 Thread via GitHub
Gowthami03B commented on issue #511: URL: https://github.com/apache/iceberg-python/issues/511#issuecomment-2062975602 @https://github.com/apache/iceberg-python/pull/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Add metadata tables [iceberg-python]

2024-04-17 Thread via GitHub
Gowthami03B commented on issue #511: URL: https://github.com/apache/iceberg-python/issues/511#issuecomment-2062975370 [https://github.com/apache/iceberg-python/pull/614](url) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] files metadata table [iceberg-python]

2024-04-17 Thread via GitHub
Gowthami03B opened a new pull request, #614: URL: https://github.com/apache/iceberg-python/pull/614 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Spark 3.5: Fix system function pushdown in CoW row-level commands [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar opened a new pull request, #10170: URL: https://github.com/apache/iceberg/pull/10170 Cherry picks #9873 to the 1.5.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [feature request] Allow engines to time travel [iceberg-python]

2024-04-17 Thread via GitHub
kevinjqliu commented on issue #600: URL: https://github.com/apache/iceberg-python/issues/600#issuecomment-2062828600 > an api like Table.as_of(snapshot_id/timestamp) -> Snapshot would be useful Yea, it's helpful in situations where we need to manipulate the Table state and get back

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar closed pull request #9407: JDBC Catalog:Change SQL like escape character from '\\' to '!' URL: https://github.com/apache/iceberg/pull/9407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2062812347 I'll close this since #9407 has been merged, thanks @xuchuanqiu @jbonofre ! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Restrict generated locations to URI syntax [iceberg]

2024-04-17 Thread via GitHub
ajantha-bhat commented on issue #10168: URL: https://github.com/apache/iceberg/issues/10168#issuecomment-2062777454 Assigned the milestone "Iceberg V3 spec" milestone as discussed on community sync. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Allow SchemaToType class to be public so we can extends and override `record` method [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2580: URL: https://github.com/apache/iceberg/issues/2580#issuecomment-2062758047 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Cannot unset hive.engine.enabled once enabled if Iceberg Jars are not on the HMS Classpath [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2578: URL: https://github.com/apache/iceberg/issues/2578#issuecomment-2062758032 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Hive: cannot find field xxx at Map operator initialization failed when iceberg table join hive table [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2567: URL: https://github.com/apache/iceberg/issues/2567#issuecomment-2062757966 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Hive: insert overwrite table xxx partition (pt='xxx') on iceberg table [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2576: URL: https://github.com/apache/iceberg/issues/2576#issuecomment-2062758019 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Support creating flink table without creating an explicit hive/hadoop catalog [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2572: URL: https://github.com/apache/iceberg/issues/2572#issuecomment-2062758005 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Flink batch job cannot read the iceberg table that writing few chang-log events in format v2. [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2571: URL: https://github.com/apache/iceberg/issues/2571#issuecomment-2062757992 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Error when dropping partition fields for the same source field more than once. [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2569: URL: https://github.com/apache/iceberg/issues/2569#issuecomment-2062757982 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Web 404 Not Found, Many page jump links cannot be opened [iceberg]

2024-04-17 Thread via GitHub
github-actions[bot] commented on issue #2561: URL: https://github.com/apache/iceberg/issues/2561#issuecomment-2062757954 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [PR] Hive: turn off the stats gathering when iceberg.hive.keep.stats is false [iceberg]

2024-04-17 Thread via GitHub
stargrey102 commented on PR #10148: URL: https://github.com/apache/iceberg/pull/10148#issuecomment-2062688748 @deniskuzZ thank you for the link. HiveOperationsBase uses HiveMetastore client when creating the Iceberg table:

Re: [I] [feature request] Allow engines to time travel [iceberg-python]

2024-04-17 Thread via GitHub
corleyma commented on issue #600: URL: https://github.com/apache/iceberg-python/issues/600#issuecomment-2062571021 Still, an api like `Table.as_of(snapshot_id/timestamp) -> Snapshot` would be useful, even if reading requires then passing the correct arguments to `Table.scan`. In general

Re: [PR] Core: Fix namespace SQL statement using ESCAPE character that works with MySQL/PostgreSQL (#10167) [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar merged PR #10169: URL: https://github.com/apache/iceberg/pull/10169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Build: Bump Guava to 32.1.1 [iceberg]

2024-04-17 Thread via GitHub
fdavis99 commented on PR #7973: URL: https://github.com/apache/iceberg/pull/7973#issuecomment-2062371744 This isn't listed in https://github.com/apache/iceberg/releases (nor is #7971), and release notes for 1.4.1 > Dependencies don't mention bumping Guava. Makes it difficult to track when

Re: [I] Flink: Decouple the iceberg integration work from hadoop libraries [iceberg]

2024-04-17 Thread via GitHub
Fokko commented on issue #3117: URL: https://github.com/apache/iceberg/issues/3117#issuecomment-2062342437 I have a draft over here: https://github.com/apache/iceberg/pull/7369 but it breaks quite a few APIs. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Core: Calling rewrite_position_delete_files fails on tables with more than 1k columns [iceberg]

2024-04-17 Thread via GitHub
szehon-ho commented on PR #10020: URL: https://github.com/apache/iceberg/pull/10020#issuecomment-2062330828 Hi @bk-mz we discussed this a bit in the last Iceberg community sync. The motivation here is to fix the position_deletes metadata table. Any other fix as you mentioned is either

Re: [PR] Core: Fix namespace SQL statement using ESCAPE character that works with MySQL/PostgreSQL (#10167) [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #10169: URL: https://github.com/apache/iceberg/pull/10169#issuecomment-2062278521 @nastra @amogh-jahagirdar hey guys, here's the backport on `1.5.x` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Core: Fix namespace SQL statement using ESCAPE character that works with MySQL/PostgreSQL (#10167) [iceberg]

2024-04-17 Thread via GitHub
jbonofre opened a new pull request, #10169: URL: https://github.com/apache/iceberg/pull/10169 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [feature request] Allow engines to time travel [iceberg-python]

2024-04-17 Thread via GitHub
kevinjqliu commented on issue #600: URL: https://github.com/apache/iceberg-python/issues/600#issuecomment-2062244023 +1, I agree with you. Passing the snapshot-id should be an engine-specific implementation detail. I was thinking about the Spark/Trino syntax of `AS OF / `. I

Re: [PR] Core: fix namespace SQL statement using ESCAPE character working with MySQL, PostgreSQL, ... [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar merged PR #10167: URL: https://github.com/apache/iceberg/pull/10167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] flink:FlinkSink support dynamically changed schema [iceberg]

2024-04-17 Thread via GitHub
pvary commented on issue #4190: URL: https://github.com/apache/iceberg/issues/4190#issuecomment-2061836288 I think it is not trivial to implement this feature, as the schema of the RowData objects which are the input of the Sink is finalized when the job graph is created. To change the

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on PR #592: URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061828760 Thanks for fixing this @MehulBatra Much appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko merged PR #592: URL: https://github.com/apache/iceberg-python/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Pagination To List Apis [iceberg]

2024-04-17 Thread via GitHub
rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1569192411 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2329,6 +2332,120 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

Re: [PR] Add Pagination To List Apis [iceberg]

2024-04-17 Thread via GitHub
rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1569180280 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2329,6 +2332,120 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

[I] Restrict generated locations to URI syntax [iceberg]

2024-04-17 Thread via GitHub
dimas-b opened a new issue, #10168: URL: https://github.com/apache/iceberg/issues/10168 ### Feature Request / Improvement It is [possible](https://github.com/projectnessie/nessie/issues/8328) to make Iceberg produce S3 (as an example) locations that violate URI syntax. Granted

Re: [PR] Docs: Update features for Hive 4.0 [iceberg]

2024-04-17 Thread via GitHub
pvary commented on code in PR #10162: URL: https://github.com/apache/iceberg/pull/10162#discussion_r1569171967 ## docs/docs/hive.md: ## @@ -34,6 +34,32 @@ Iceberg compatibility with Hive 2.x and Hive 3.1.2/3 supports the following feat !!! warning DML operations work

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
MehulBatra commented on PR #592: URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061776890 > @MehulBatra I've removed an unrelated change, I think #612 addresses the issue that you ran into sounds good! -- This is an automated message from the Apache Git

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on PR #592: URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061773917 @MehulBatra I've removed an unrelated change, I think https://github.com/apache/iceberg-python/pull/612/ addresses the issue that you ran into -- This is an automated message from

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #592: URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1569167115 ## tests/expressions/test_literals.py: ## @@ -277,8 +277,7 @@ def test_decimal_to_decimal_conversion() -> None: def test_timestamp_to_date() -> None:

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #592: URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1569166271 ## tests/expressions/test_literals.py: ## @@ -277,8 +277,7 @@ def test_decimal_to_decimal_conversion() -> None: def test_timestamp_to_date() -> None:

Re: [I] Iceberg Rest OpenAPI Spec views/rename should return 204 [iceberg]

2024-04-17 Thread via GitHub
nastra closed issue #10135: Iceberg Rest OpenAPI Spec views/rename should return 204 URL: https://github.com/apache/iceberg/issues/10135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix open-api /rename/views success return code [iceberg]

2024-04-17 Thread via GitHub
nastra merged PR #10166: URL: https://github.com/apache/iceberg/pull/10166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [BUG] Valid column characters fail on to_arrow() or to_pandas() ArrowInvalid: No match for FieldRef.Name [iceberg-python]

2024-04-17 Thread via GitHub
kevinjqliu commented on issue #584: URL: https://github.com/apache/iceberg-python/issues/584#issuecomment-2061699557 @gwindes The fixes for the read side (#597) and write side (#590) are merged. Thanks for reporting this issue! -- This is an automated message from the Apache Git

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061642341 Thanks @jbonofre ! Discussed offline, we'll ensure that @xuchuanqiu gets co-authorship/attribution. Thanks @xuchuanqiu -- This is an automated message from the Apache Git

Re: [PR] Core: fix namespace SQL statement using ESCAPE character working with MySQL, PostgreSQL, ... [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #10167: URL: https://github.com/apache/iceberg/pull/10167#issuecomment-2061641506 This closes #10056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061639934 Replaced by #10167 to merge the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core: fix namespace SQL statement using ESCAPE character working with MySQL, PostgreSQL, ... [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #10167: URL: https://github.com/apache/iceberg/pull/10167#issuecomment-2061638296 @nastra @amogh-jahagirdar superseding #9407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Core: fix namespace SQL statement using ESCAPE character working with MySQL, PostgreSQL, ... [iceberg]

2024-04-17 Thread via GitHub
jbonofre opened a new pull request, #10167: URL: https://github.com/apache/iceberg/pull/10167 Co-Author (special thanks to): xuchuanqiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on code in PR #9407: URL: https://github.com/apache/iceberg/pull/9407#discussion_r1569078743 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -136,7 +136,7 @@ final class JdbcUtil { + TABLE_NAMESPACE + " = ? OR "

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061615460 I also tested with PostgreSQL 42.7.3 and it works fine. In order to fix the conflict, I propose to create a clean PR. -- This is an automated message from the Apache Git

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061586682 I tested with MySQL 8.3.0 (both server and JDBC driver) and I confirm the `!` notation works. I used MySQL 8.3.0 docker image, create the schema and updated the `GET_NAMESPACE_SQL`

Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]

2024-04-17 Thread via GitHub
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061567560 I've added this to the 1.5.1 milestone. If we validate that it works on all the backends as expected, then I think we can include in the patch release (we'll also discuss this

Re: [I] flink autoscaler: how set write-parallelism ? [iceberg]

2024-04-17 Thread via GitHub
pvary commented on issue #10147: URL: https://github.com/apache/iceberg/issues/10147#issuecomment-2061388525 Could it be, that the table is partitioned and all of the new data is targeting a single partition? If you start the sink with higher writer parallelism, how does the data

Re: [PR] Backport Flink 1.18 JUnit5 migration to Flink 1.17 [iceberg]

2024-04-17 Thread via GitHub
tomtongue commented on PR #10163: URL: https://github.com/apache/iceberg/pull/10163#issuecomment-2061336515 Sure, thanks for the headsup. Will submit a PR for Flink 1.9 including backport to other versions. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix CI [iceberg-python]

2024-04-17 Thread via GitHub
Fokko merged PR #613: URL: https://github.com/apache/iceberg-python/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Add metadata tables [iceberg-python]

2024-04-17 Thread via GitHub
Gowthami03B commented on issue #511: URL: https://github.com/apache/iceberg-python/issues/511#issuecomment-2061211477 > @Gowthami03B checking in if you're still interested in contributing the `files` table. @Fokko yes, I will be sending over a PR shortly. -- This is an automated

[I] Iceberg may occur data duplication when use flink to write data to iceberg and commit failed [iceberg]

2024-04-17 Thread via GitHub
zlzhang0122 opened a new issue, #10165: URL: https://github.com/apache/iceberg/issues/10165 ### Apache Iceberg version 1.3.0 ### Query engine Spark ### Please describe the bug  Iceberg may occur data duplication when use flink to write data to iceberg and

Re: [PR] add `InclusiveProjection` Visitor [iceberg-rust]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #335: URL: https://github.com/apache/iceberg-rust/pull/335#discussion_r1568751884 ## crates/iceberg/src/expr/visitors/inclusive_projection.rs: ## @@ -0,0 +1,371 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] add `InclusiveProjection` Visitor [iceberg-rust]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #335: URL: https://github.com/apache/iceberg-rust/pull/335#discussion_r1568763855 ## crates/iceberg/src/expr/visitors/inclusive_projection.rs: ## @@ -0,0 +1,371 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Hive: turn off the stats gathering when iceberg.hive.keep.stats is false [iceberg]

2024-04-17 Thread via GitHub
deniskuzZ commented on PR #10148: URL: https://github.com/apache/iceberg/pull/10148#issuecomment-2061152342 @stargrey102, have you checked the same in Hive-4.0? see HIVE-27355, https://github.com/apache/hive/pull/4348 -- This is an automated message from the Apache Git Service. To

Re: [PR] Sanitized special character column name before writing to parquet [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on PR #590: URL: https://github.com/apache/iceberg-python/pull/590#issuecomment-2061073883 Thanks for working on this @kevinjqliu and thanks @HonahX for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Sanitized special character column name before writing to parquet [iceberg-python]

2024-04-17 Thread via GitHub
Fokko merged PR #590: URL: https://github.com/apache/iceberg-python/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Sanitized special character column name before writing to parquet [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #590: URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1568710826 ## pyiceberg/io/pyarrow.py: ## @@ -1769,27 +1769,33 @@ def data_file_statistics_from_parquet_metadata( def write_file(io: FileIO, table_metadata:

Re: [I] [BUG] Valid column characters fail on to_arrow() or to_pandas() ArrowInvalid: No match for FieldRef.Name [iceberg-python]

2024-04-17 Thread via GitHub
Fokko closed issue #584: [BUG] Valid column characters fail on to_arrow() or to_pandas() ArrowInvalid: No match for FieldRef.Name URL: https://github.com/apache/iceberg-python/issues/584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
javrasya commented on code in PR #9464: URL: https://github.com/apache/iceberg/pull/9464#discussion_r1568704619 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/split/SerializerHelper.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

Re: [PR] Incremental Append Scan [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1568698784 ## pyiceberg/table/__init__.py: ## @@ -1594,6 +1617,197 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow())

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
javrasya commented on PR #9464: URL: https://github.com/apache/iceberg/pull/9464#issuecomment-2061065359 Done @pvary , I guess the triggers are requiring an approval to kick in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #592: URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568690611 ## tests/test_types.py: ## @@ -560,13 +560,13 @@ def test_deserialization_struct() -> None: def test_str_struct(simple_struct: StructType) -> None: -assert

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
MehulBatra commented on code in PR #592: URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568694815 ## tests/test_types.py: ## @@ -560,13 +560,13 @@ def test_deserialization_struct() -> None: def test_str_struct(simple_struct: StructType) -> None: -

Re: [I] Add metadata tables [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on issue #511: URL: https://github.com/apache/iceberg-python/issues/511#issuecomment-2061028334 @Gowthami03B checking in if you're still interested in contributing the `files` table. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
MehulBatra commented on PR #592: URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061051645 > Looks good @MehulBatra Left one small suggestion. > > Could you also remove `required=False` from `mkdocs/docs/api.md`. Since this is now default, I think we should

Re: [PR] StructType field `optional` by default [iceberg-python]

2024-04-17 Thread via GitHub
MehulBatra commented on code in PR #592: URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568694815 ## tests/test_types.py: ## @@ -560,13 +560,13 @@ def test_deserialization_struct() -> None: def test_str_struct(simple_struct: StructType) -> None: -

[I] Cannot insert table created by spark temp into iceberg table [iceberg]

2024-04-17 Thread via GitHub
hellonewplayer opened a new issue, #10164: URL: https://github.com/apache/iceberg/issues/10164 ### Apache Iceberg version None ### Query engine Spark ### Please describe the bug  Helo, I got a similar issue to https://github.com/apache/iceberg/issues/510.

Re: [PR] add `InclusiveProjection` Visitor [iceberg-rust]

2024-04-17 Thread via GitHub
marvinlanhenke commented on code in PR #335: URL: https://github.com/apache/iceberg-rust/pull/335#discussion_r1568705676 ## crates/iceberg/src/expr/visitors/inclusive_projection.rs: ## @@ -0,0 +1,371 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Backport Flink 1.18 JUnit5 migration to Flink 1.17 [iceberg]

2024-04-17 Thread via GitHub
nastra merged PR #10163: URL: https://github.com/apache/iceberg/pull/10163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Refs metadata table [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on code in PR #602: URL: https://github.com/apache/iceberg-python/pull/602#discussion_r1568666707 ## tests/integration/test_inspect_table.py: ## @@ -274,6 +274,64 @@ def test_inspect_entries_partitioned(spark: SparkSession, session_catalog: Catal

[PR] chore: update roadmap [iceberg-rust]

2024-04-17 Thread via GitHub
marvinlanhenke opened a new pull request, #336: URL: https://github.com/apache/iceberg-rust/pull/336 partly #330. - updated the roadmap to reflect the current status (to the best of my knowledge) @liurenjie1024 Can you PTAL at the `reader` section I'm not sure, I could

Re: [PR] Add Refs metadata table [iceberg-python]

2024-04-17 Thread via GitHub
Fokko commented on PR #602: URL: https://github.com/apache/iceberg-python/pull/602#issuecomment-2061026458 Thanks @geruh for working on this  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add Refs metadata table [iceberg-python]

2024-04-17 Thread via GitHub
Fokko merged PR #602: URL: https://github.com/apache/iceberg-python/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Docs: Update features for Hive 4.0 [iceberg]

2024-04-17 Thread via GitHub
SourabhBadhya commented on PR #10162: URL: https://github.com/apache/iceberg/pull/10162#issuecomment-2060924512 @pvary Requesting your review on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Docs: Update features for Hive 4.0 [iceberg]

2024-04-17 Thread via GitHub
SourabhBadhya commented on code in PR #10162: URL: https://github.com/apache/iceberg/pull/10162#discussion_r1568611714 ## docs/docs/hive.md: ## @@ -431,12 +466,120 @@ ALTER TABLE t SET TBLPROPERTIES ('storage_handler'='org.apache.iceberg.mr.hive.H During the migration the

Re: [PR] feat: Glue Catalog - table operations (3/3) [iceberg-rust]

2024-04-17 Thread via GitHub
marvinlanhenke commented on PR #314: URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2060905965 > For the 'missing table checks' - I'll file an Issue later, so we can track this and implement in separate PRs. #337 -- This is an automated message from the Apache

Re: [PR] Backport Flink 1.18 JUnit5 migration to Flink 1.17 [iceberg]

2024-04-17 Thread via GitHub
tomtongue commented on PR #10163: URL: https://github.com/apache/iceberg/pull/10163#issuecomment-2060751325 @nastra Could you review this PR? If I should migrate more files to this PR, please let me know. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
pvary commented on code in PR #9464: URL: https://github.com/apache/iceberg/pull/9464#discussion_r1568432766 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/split/SerializerHelper.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
pvary commented on PR #9464: URL: https://github.com/apache/iceberg/pull/9464#issuecomment-2060691225 @javrasya: Please fix the failures as well. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add Pagination To List Apis [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1568415371 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2329,6 +2332,120 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

Re: [PR] Add Pagination To List Apis [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1568398951 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2329,6 +2332,120 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

Re: [PR] Docs: Update features for Hive 4.0 [iceberg]

2024-04-17 Thread via GitHub
ajantha-bhat commented on code in PR #10162: URL: https://github.com/apache/iceberg/pull/10162#discussion_r1568390242 ## docs/docs/hive.md: ## @@ -431,12 +466,120 @@ ALTER TABLE t SET TBLPROPERTIES ('storage_handler'='org.apache.iceberg.mr.hive.H During the migration the data

Re: [PR] feat: Glue Catalog - table operations (3/3) [iceberg-rust]

2024-04-17 Thread via GitHub
marvinlanhenke commented on PR #314: URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2060583038 @liurenjie1024 I think I fixed all of your suggestions - thanks again for the review. For the 'missing table checks' - I'll file an Issue later, so we can track this and

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
javrasya commented on code in PR #9464: URL: https://github.com/apache/iceberg/pull/9464#discussion_r1568359596 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/split/SerializerHelper.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Don't fail to serialize IcebergSourceSplit when there is too many delete files [iceberg]

2024-04-17 Thread via GitHub
javrasya commented on code in PR #9464: URL: https://github.com/apache/iceberg/pull/9464#discussion_r1568359596 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/split/SerializerHelper.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[PR] Support CreateTableTransaction for Hive and SQL Catalog [iceberg-python]

2024-04-17 Thread via GitHub
HonahX opened a new pull request, #611: URL: https://github.com/apache/iceberg-python/pull/611 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568292423 ## data/src/test/java/org/apache/iceberg/data/TestReadProjection.java: ## @@ -76,20 +78,21 @@ public void testSpecialCharacterProjection() throws Exception {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568271659 ## data/src/test/java/org/apache/iceberg/data/TestReadProjection.java: ## @@ -31,16 +34,14 @@ import org.apache.iceberg.types.Comparators; import

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270818 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +272,36 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270613 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +272,36 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270029 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -266,12 +254,15 @@ public void testRandomData() throws IOException { append.commit();

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-04-17 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568268561 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -32,21 +32,14 @@ import java.io.IOException; import java.nio.ByteBuffer; import

  1   2   >