nastra merged PR #10631:
URL: https://github.com/apache/iceberg/pull/10631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko merged PR #894:
URL: https://github.com/apache/iceberg-python/pull/894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #10276:
URL: https://github.com/apache/iceberg/pull/10276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2210287505
Let's get this in, thanks @lawofcycles for working on this, and
@amogh-jahagirdar and @rahil-c for the review!
--
This is an automated message from the Apache Git Service.
To respond to
Fokko closed issue #10220: AWS: Updating Glue catalog table removes column
descriptions
URL: https://github.com/apache/iceberg/issues/10220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Sourabh-Dilraj opened a new issue, #10633:
URL: https://github.com/apache/iceberg/issues/10633
### Query engine
HIve
### Question
I am using HIve branch-4.0.0-alpha-1 , I have placed
iceberg-hive-runtime-1.6.0-SNAPSHOT.jar jar in hive/lib/ dir.
Also made all the requi
tomtongue commented on code in PR #10632:
URL: https://github.com/apache/iceberg/pull/10632#discussion_r1666304183
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestArrayPoolDataIteratorBatcherRowData.java:
##
@@ -107,7 +114,11 @@ public void testSing
tomtongue commented on PR #10632:
URL: https://github.com/apache/iceberg/pull/10632#issuecomment-2210176248
@nastra when you have a chance, could you review this PR? Currently this PR
only includes Flink 1.10 because of the a lot of file changes.
--
This is an automated message from the A
thexiay commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666297390
##
Cargo.toml:
##
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt
fengjiajie commented on PR #10565:
URL: https://github.com/apache/iceberg/pull/10565#issuecomment-2210172557
> +1 from me. Let's wait a bit, to see if someone else is interested in
reviewing. If there're no more comments, I will merge next Tuesday. (Ping me if
I forgot π)
Thanks
--
tomtongue commented on PR #10632:
URL: https://github.com/apache/iceberg/pull/10632#issuecomment-2210148539
This PR currently only has Flink 1.19 because the number of class changes
are a bit many. Will create the backport PR for other Flink versions 1.17 and
1.18
--
This is an automated
Xuanwo commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666227308
##
Cargo.toml:
##
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt =
thexiay commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666223166
##
Cargo.toml:
##
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt
rahil-c commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1666192983
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(response.ta
Xuanwo commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666177869
##
Cargo.toml:
##
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt =
liurenjie1024 merged PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
thexiay commented on code in PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#discussion_r1666126704
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -123,9 +122,9 @@ impl NamespaceIdent {
Self::from_vec(iter.into_iter().map(|s| s.to_string()).collect())
}
zymap commented on code in PR #10630:
URL: https://github.com/apache/iceberg/pull/10630#discussion_r1666167004
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -290,6 +291,14 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
Xuanwo commented on issue #408:
URL: https://github.com/apache/iceberg-rust/issues/408#issuecomment-2209879237
> @Xuanwo I can take the Azure datalake FileIO Implementation + the
corresponding infrastructure set up, sound ok?
Welcome, have fun!
--
This is an automated message from
liurenjie1024 commented on code in PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#discussion_r1666155211
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -123,9 +122,9 @@ impl NamespaceIdent {
Self::from_vec(iter.into_iter().map(|s| s.to_string()).collect())
ajantha-bhat opened a new pull request, #10631:
URL: https://github.com/apache/iceberg/pull/10631
https://github.com/revapi/gradle-revapi/releases/tag/1.8.0
Special thanks to @nastra, @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message,
thexiay commented on PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#issuecomment-2209672375
> cc @thexiay Would you take a look if this helps?
yesοΌ it really helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
thexiay commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666119516
##
crates/catalog/glue/tests/glue_catalog_test.rs:
##
@@ -92,6 +96,24 @@ async fn set_test_fixture(func: &str) -> TestFixture {
}
}
+async fn lazy_reuse_dc()
thexiay commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666119013
##
crates/catalog/glue/tests/glue_catalog_test.rs:
##
@@ -92,6 +96,24 @@ async fn set_test_fixture(func: &str) -> TestFixture {
}
}
+async fn lazy_reuse_dc()
vinjai commented on PR #871:
URL: https://github.com/apache/iceberg-python/pull/871#issuecomment-2209659177
This PR solves for:
1. Writing sorted datasets to a partitioned or non-partitioned iceberg table.
2. Generating manifests with correct sort-order-id.
3. Integration tests to ma
vinjai commented on PR #871:
URL: https://github.com/apache/iceberg-python/pull/871#issuecomment-2209659324
@Fokko This PR is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
thexiay commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666118879
##
crates/catalog/glue/tests/glue_catalog_test.rs:
##
@@ -92,6 +96,24 @@ async fn set_test_fixture(func: &str) -> TestFixture {
}
}
+async fn lazy_reuse_dc()
github-actions[bot] commented on issue #2802:
URL: https://github.com/apache/iceberg/issues/2802#issuecomment-2209658051
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2791:
URL: https://github.com/apache/iceberg/issues/2791#issuecomment-2209658040
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
syun64 commented on code in PR #890:
URL: https://github.com/apache/iceberg-python/pull/890#discussion_r1666094679
##
pyiceberg/table/__init__.py:
##
@@ -1866,7 +1866,7 @@ def plan_files(self) -> Iterable[FileScanTask]:
for data_entry in data_entries
]
-
dependabot[bot] opened a new pull request, #894:
URL: https://github.com/apache/iceberg-python/pull/894
Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.8.0 to 2.8.2.
Release notes
Sourced from https://github.com/pydantic/pydantic/releases";>pydantic's
releases.
kevinjqliu commented on issue #893:
URL: https://github.com/apache/iceberg-python/issues/893#issuecomment-2209610949
Is there a way on the Java/spark side to turn metadata information into
JSON? With #535, perhaps we can compare the two JSON results and check for
mismatches like this one.
Fokko merged PR #878:
URL: https://github.com/apache/iceberg-python/pull/878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
lawofcycles commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1666063693
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(respons
Fokko merged PR #886:
URL: https://github.com/apache/iceberg-python/pull/886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1666060990
##
mkdocs/docs/configuration.md:
##
@@ -222,6 +222,12 @@ catalog:
uri: sqlite:tmp/pyiceberg.db
```
+| Key | Example
Fokko closed issue #891: Check nullability of `508: field_summary`
URL: https://github.com/apache/iceberg-python/issues/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Fokko commented on issue #891:
URL: https://github.com/apache/iceberg-python/issues/891#issuecomment-2209531903
I checked with Spark, and this seems to be correct:
```json
{
"name" : "partitions",
"type" : [ "null", {
"type" : "array",
"items" : {
Fokko commented on code in PR #890:
URL: https://github.com/apache/iceberg-python/pull/890#discussion_r1666027762
##
pyiceberg/table/__init__.py:
##
@@ -1866,7 +1866,7 @@ def plan_files(self) -> Iterable[FileScanTask]:
for data_entry in data_entries
]
-
jsimbadev commented on issue #408:
URL: https://github.com/apache/iceberg-rust/issues/408#issuecomment-2209489934
@Xuanwo I can take the Azure datalake FileIO Implementation + the
corresponding infrastructure set up, sound ok?
--
This is an automated message from the Apache Git Service.
T
Fokko commented on PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#issuecomment-2209468950
Another test with `commit.manifest.min-count-to-merge` set to 100, and doing
500 append operations:
```
avro-tools tojson
/tmp/some.db/w/metadata/snap-395291108779496
Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1666006402
##
mkdocs/docs/api.md:
##
@@ -273,6 +273,10 @@ tbl.append(df)
# or
+tbl.merge_append(df)
Review Comment:
btw, I like how you split it out in classes, it is
Fokko commented on PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#issuecomment-2209460864
Doing some testing with `avro-tools`, asserting the state after 5 append
operations with `"commit.manifest.min-count-to-merge": "2"`
# V1 Table
## Manifest-list
###
Fokko opened a new issue, #893:
URL: https://github.com/apache/iceberg-python/issues/893
### Feature Request / Improvement
It looks like a misnamed field slipped in:
```json
{
"status": 1,
"snapshot_id": {
"long": 898025966831056900
},
"
hantangwangd commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665997350
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops,
UpdateTable
kevinjqliu commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2209446665
Opened #892 to track the issue with AWS credential formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kevinjqliu opened a new issue, #892:
URL: https://github.com/apache/iceberg-python/issues/892
### Apache Iceberg version
None
### Please describe the bug π
`s3.access-key-id` and `s3.secret-access-key` are the pyiceberg way to pass
AWS credentials as properties to the ca
kevinjqliu commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2209443484
@impproductions Thanks for the detailed explanation. Great catch!
Looking through the code, there's indeed an expectation for both AWS
credential formats.
`s3.acces
kevinjqliu commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1665991459
##
mkdocs/docs/configuration.md:
##
@@ -222,6 +222,12 @@ catalog:
uri: sqlite:tmp/pyiceberg.db
```
+| Key | Example
Fokko opened a new issue, #891:
URL: https://github.com/apache/iceberg-python/issues/891
### Apache Iceberg version
0.6.1 (latest release)
### Please describe the bug π
Field-id 508 is the struct in the list of partition summaries. It marked as
optional, but I think it s
Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1665964764
##
mkdocs/docs/api.md:
##
@@ -273,6 +273,10 @@ tbl.append(df)
# or
+tbl.merge_append(df)
Review Comment:
Thanks! I think the use-case of the Java library is
Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1665964062
##
pyiceberg/table/__init__.py:
##
@@ -2998,21 +3074,22 @@ def _deleted_entries(self) -> List[ManifestEntry]: ...
@abstractmethod
def _existing_manifests(s
adutra commented on code in PR #10621:
URL: https://github.com/apache/iceberg/pull/10621#discussion_r1665281650
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
amogh-jahagirdar merged PR #10615:
URL: https://github.com/apache/iceberg/pull/10615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar closed issue #10591: Possible heap data corruption of
`org.apache.iceberg.rest.auth.OAuth2Util.AuthSession#headers`
URL: https://github.com/apache/iceberg/issues/10591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
amogh-jahagirdar commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665910677
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) {
// it is only safe to
amogh-jahagirdar commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665909446
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops,
UpdateT
snazy commented on issue #10618:
URL: https://github.com/apache/iceberg/issues/10618#issuecomment-2209310322
@jackye1995 looks like you linked the wrong document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pvary commented on PR #10629:
URL: https://github.com/apache/iceberg/pull/10629#issuecomment-2209285181
Thanks for the fix @snazy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
pvary merged PR #10629:
URL: https://github.com/apache/iceberg/pull/10629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Xuanwo commented on code in PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#discussion_r1665841971
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -123,9 +122,9 @@ impl NamespaceIdent {
Self::from_vec(iter.into_iter().map(|s| s.to_string()).collect())
}
awdavidson commented on PR #752:
URL: https://github.com/apache/iceberg-python/pull/752#issuecomment-2209205175
> @awdavidson This looks like a nice addition. Could you add a test as well?
Unit tests have been added
--
This is an automated message from the Apache Git Service.
To res
awdavidson commented on code in PR #752:
URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1665835337
##
pyiceberg/catalog/hive.py:
##
@@ -271,6 +271,18 @@ def __init__(self, name: str, **properties: str):
DEFAULT_LOCK_CHECK_RETRIES,
)
+
liurenjie1024 commented on PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#issuecomment-2209197404
cc @thexiay Would you take a look if this helps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liurenjie1024 commented on issue #433:
URL: https://github.com/apache/iceberg-rust/issues/433#issuecomment-2209197794
Fixed in #435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Fokko commented on PR #876:
URL: https://github.com/apache/iceberg-python/pull/876#issuecomment-2209093993
Yes, when you create a new table and you write an empty dataframe, it will
create a manfist-list that's pointing to zero manifests. I don't think there
are any cases where you would wr
syun64 commented on PR #876:
URL: https://github.com/apache/iceberg-python/pull/876#issuecomment-2208991366
Hi @Fokko this is an interesting find.
Is my understanding of the issue correct? When we are writing an empty
commit, we are already creating an empty avro file (manifest list)
ndrluis commented on issue #866:
URL: https://github.com/apache/iceberg-python/issues/866#issuecomment-2208987634
Hello @Fokko,
I'd like to resolve this issue. I just want to confirm the expected
behavior. Since we are replacing ADLFS with ADLS, I believe the expected
behavior should
snazy commented on code in PR #10603:
URL: https://github.com/apache/iceberg/pull/10603#discussion_r1665623076
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -176,19 +176,34 @@ public void initialize(String name, Map
unresolved) {
long startTi
adutra commented on PR #10314:
URL: https://github.com/apache/iceberg/pull/10314#issuecomment-2208819566
Thank you to all involved! I'm very glad that we could reach a consensus
here π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
nastra merged PR #10314:
URL: https://github.com/apache/iceberg/pull/10314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
snazy commented on code in PR #10630:
URL: https://github.com/apache/iceberg/pull/10630#discussion_r1665606754
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -290,6 +291,14 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
liurenjie1024 commented on issue #433:
URL: https://github.com/apache/iceberg-rust/issues/433#issuecomment-2208778213
Cool, I will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chenzl25 opened a new issue, #434:
URL: https://github.com/apache/iceberg-rust/issues/434
If an iceberg table is created and inserted with data by spark, we will get
a manifest list with prefix `s3a`.
```
spark-sql --packages
org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.4.3
impproductions commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2208697240
We had the same problem within our Airflow deployment. The easy fix for us
would have been to set the default aws credentials through environment
variables:
```bash
zymap commented on PR #10630:
URL: https://github.com/apache/iceberg/pull/10630#issuecomment-2208681983
@snazy Please take a look when you have time. Thanks! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
zymap opened a new pull request, #10630:
URL: https://github.com/apache/iceberg/pull/10630
---
### Motivation
Create multiple level namespace together when creating namespace. For more
time, the namespace level is one. But sometimes when we have multiple levels to
construct the na
thexiay commented on issue #433:
URL: https://github.com/apache/iceberg-rust/issues/433#issuecomment-2208658504
> Interesting, could you elaborate the rest catalog server you use? In fact
our integration tests have things dealing with multi level namespace ident:
>
>
https://github.c
krishan711 commented on issue #10294:
URL: https://github.com/apache/iceberg/issues/10294#issuecomment-2208654859
I have the same issue also. i was hoping delete and then insert would work
in separate statements (just to test it) but even this fails with too many
columns:
```
MERGE IN
Fokko commented on PR #876:
URL: https://github.com/apache/iceberg-python/pull/876#issuecomment-2208625219
I didn't think the fact that we allowed writing empty commits, so I was a
bit strong in my first approach.
--
This is an automated message from the Apache Git Service.
To respond to
Fokko commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1665466731
##
mkdocs/docs/configuration.md:
##
@@ -222,6 +222,12 @@ catalog:
uri: sqlite:tmp/pyiceberg.db
```
+| Key | Example
snazy opened a new pull request, #10629:
URL: https://github.com/apache/iceberg/pull/10629
Backport of #10580 and resolve IDE warning/error wrt `floorMod`/`floorDiv`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liurenjie1024 commented on issue #433:
URL: https://github.com/apache/iceberg-rust/issues/433#issuecomment-2208492052
Interesting, could you elaborate the rest catalog server you use? In fact
our integration tests have things dealing with multi level namespace ident:
https://github.com/apac
fengjiajie commented on code in PR #10565:
URL: https://github.com/apache/iceberg/pull/10565#discussion_r1665382438
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java:
##
@@ -79,7 +79,11 @@ public static Object convertConstant(Type type, Object
va
MehulBatra commented on PR #881:
URL: https://github.com/apache/iceberg-python/pull/881#issuecomment-2208439531
@Fokko do see when you get a chance, waiting for your feedback too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
nastra commented on code in PR #10314:
URL: https://github.com/apache/iceberg/pull/10314#discussion_r1665347177
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##
@@ -738,13 +738,21 @@ private static AuthSession fromTokenResponse(
long startTimeMilli
Xuanwo commented on issue #433:
URL: https://github.com/apache/iceberg-rust/issues/433#issuecomment-2208389939
Thanks for report! Would you like to give it a fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nastra commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1665327420
##
open-api/rest-catalog-open-api.yaml:
##
@@ -61,12 +65,26 @@ security:
- OAuth2: [catalog]
- BearerAuth: []
+# Capability tags describe optional functionality
nastra commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1665314780
##
open-api/rest-catalog-open-api.yaml:
##
@@ -191,7 +220,8 @@ paths:
get:
tags:
-- Catalog API
+- tables
+- views
Review Comment:
adutra commented on code in PR #10621:
URL: https://github.com/apache/iceberg/pull/10621#discussion_r1665304639
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSession.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
twuebi commented on PR #331:
URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2208353517
Thanks for checking this @nastra, I understand that we should be relaxing
the constraints of NamespaceIdent then if an empty default-namespace is
expected.
--
This is an automated me
adutra commented on code in PR #10621:
URL: https://github.com/apache/iceberg/pull/10621#discussion_r1665284071
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
adutra commented on code in PR #10621:
URL: https://github.com/apache/iceberg/pull/10621#discussion_r1665281650
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
chinmay-bhat commented on code in PR #758:
URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340
##
pyiceberg/table/__init__.py:
##
@@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
thexiay opened a new issue, #433:
URL: https://github.com/apache/iceberg-rust/issues/433
replace test unit `rest_catalog_test::test_list_empty_namespace` to this:
```
#[tokio::test]
async fn test_list_empty_namespace() {
let fixture = get_test_fixture("test_list_empty_namespac
chinmay-bhat commented on code in PR #758:
URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340
##
pyiceberg/table/__init__.py:
##
@@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
ajantha-bhat commented on code in PR #10627:
URL: https://github.com/apache/iceberg/pull/10627#discussion_r1665247303
##
docs/docs/spark-getting-started.md:
##
@@ -48,8 +48,6 @@ This command creates a path-based catalog named `local` for
tables under `$PWD/w
```sh
spark-sql -
chinmay-bhat commented on code in PR #758:
URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340
##
pyiceberg/table/__init__.py:
##
@@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
Raphael-Vignes commented on PR #9420:
URL: https://github.com/apache/iceberg/pull/9420#issuecomment-2208273896
Sorry but I never finished this PR, I'm not sure it's fully functional. I'll
try to finish it when I've time.
--
This is an automated message from the Apache Git Service.
To resp
99 matches
Mail list logo
