Re: [I] Implement `TableProviderFactory` for a `IcebergTableFactory` [iceberg-rust]

2024-09-02 Thread via GitHub
yukkit commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2324782434 @liurenjie1024 Thank you so much for your feedback! I agree with your points, and I will start working on it based on this approach. -- This is an automated message from the Apac

Re: [I] Implement `TableProviderFactory` for a `IcebergTableFactory` [iceberg-rust]

2024-09-01 Thread via GitHub
liurenjie1024 commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2323635619 Hi, @yukkit Thanks for your interest and welcome to contribute! > For the first question: > > 1. By default, use the latest version. > 2. [Optional] Support s

Re: [I] Implement `TableProviderFactory` for a `IcebergTableFactory` [iceberg-rust]

2024-08-31 Thread via GitHub
matthewmturner commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2322972430 @yukkit I am actually only familiar with the `ObjectStore` abstraction and not `FileIO` - ill need to look into that more. Prior to knowing that I had naively expected to

Re: [I] Implement `TableProviderFactory` for a `IcebergTableFactory` [iceberg-rust]

2024-08-31 Thread via GitHub
yukkit commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2322940734 Here are a few questions that need clarification: 1. Is there a need to support specifying a version? @matthewmturner 2. Where should the parameters for object storage, suc

Re: [I] Implement `TableProviderFactory` for a `IcebergTableFactory` [iceberg-rust]

2024-08-31 Thread via GitHub
yukkit commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2322902965 Please assign it to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific