Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558712520 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558712520 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558704222 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558551506 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558549404 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558307800 ## core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java: ## @@ -83,6 +83,23 @@ public void testBuilderDoesNotCreateInvalidObjects() {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558181883 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2288,6 +2289,34 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1557807369 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +226,7 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1557801099 ## core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java: ## @@ -105,6 +105,23 @@ public void testBuilderDoesNotCreateInvalidObjects() {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1557800399 ## core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java: ## @@ -83,6 +83,23 @@ public void testBuilderDoesNotCreateInvalidObjects() {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1557169245 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2288,6 +2289,34 @@ public void multipleDiffsAgainstMultipleTablesLastFails() {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556673446 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556425249 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -274,14 +277,34 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556399763 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +226,7 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556370624 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +226,7 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556366558 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -274,14 +277,34 @@ public void setConf(Object newConf) { @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on PR #9782: URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2035897279 > I just want to add a few high-level comments here: > > 1. It looks like `pageSize` is currently required, but I believe the default should be that if it is not set, no pagination

Re: [PR] Add Pagination To List Apis [iceberg]

sachet commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1548998658 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1548945175 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1545017898 ## core/src/main/java/org/apache/iceberg/rest/PaginatedList.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on PR #9782: URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2027829487 I just want to add a few high-level comments here: 1. It looks like `pageSize` is currently required, but I believe the default should be that if it is not set, no pagination

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1544946200 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -114,6 +114,9 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1544047140 ## core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java: ## @@ -105,6 +105,14 @@ public void testBuilderDoesNotCreateInvalidObjects() {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1520289302 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1539170095 ## core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java: ## @@ -105,6 +105,14 @@ public void testBuilderDoesNotCreateInvalidObjects() {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on PR #9782: URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2019317801 @jackye1995 @danielcweeks @nastra If you can take a look at the revision for this whenever you guys get a chance would be appreciated. -- This is an automated message from the Apache

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1538538607 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1538536990 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -114,6 +114,9 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog

Re: [PR] Add Pagination To List Apis [iceberg]

danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1538216438 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -114,6 +114,9 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1536646978 ## core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java: ## @@ -59,6 +68,7 @@ public static Builder builder() { public static class

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1536645727 ## core/src/main/java/org/apache/iceberg/rest/responses/ListTablesResponse.java: ## @@ -30,13 +30,15 @@ public class ListTablesResponse implements RESTResponse {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1520289302 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500378492 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1045,6 +1094,27 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500375047 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500371045 ## core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java: ## @@ -59,6 +68,7 @@ public static Builder builder() { public static class

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500369784 ## core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java: ## @@ -29,13 +29,15 @@ public class ListNamespacesResponse implements RESTResponse

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500369207 ## core/src/main/java/org/apache/iceberg/rest/responses/ListTablesResponse.java: ## @@ -60,6 +69,7 @@ public static Builder builder() { public static class Builder

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500368758 ## core/src/main/java/org/apache/iceberg/rest/responses/ListTablesResponse.java: ## @@ -30,13 +30,15 @@ public class ListTablesResponse implements RESTResponse {

Re: [PR] Add Pagination To List Apis [iceberg]

nastra commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500365522 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1500065202 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1045,6 +1094,27 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Add Pagination To List Apis [iceberg]

jackye1995 commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499968208 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1045,6 +1094,27 @@ public void commitTransaction(SessionContext context, List

Re: [PR] Add Pagination To List Apis [iceberg]

jackye1995 commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499966845 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

jackye1995 commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499965680 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

geruh commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499953848 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -224,6 +229,12 @@ public void initialize(String name, Map unresolved) {

Re: [PR] Add Pagination To List Apis [iceberg]

rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499894821 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

geruh commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499864124 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

Re: [PR] Add Pagination To List Apis [iceberg]

geruh commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499864124 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -490,12 +522,29 @@ public void createNamespace( @Override public List

[PR] Add Pagination To List Apis [iceberg]

rahil-c opened a new pull request, #9782: URL: https://github.com/apache/iceberg/pull/9782 Implemented pagination in list apis based on the spec: https://github.com/apache/iceberg/pull/9660 @jackye1995 @nastra @danielcweeks @geruh ## Testing * Ran gradle build * Manual

<    1   2