Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

Fokko merged PR #265: URL: https://github.com/apache/iceberg-python/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

Fokko commented on PR #265: URL: https://github.com/apache/iceberg-python/pull/265#issuecomment-1895723645 Thanks @syun64 for working on this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

Fokko commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1453609341 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +363,66 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451754672 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451680767 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451680767 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451680767 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451680767 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451651003 ## pyiceberg/catalog/sql.py: ## @@ -268,16 +269,32 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None: identifier_tuple = self.identifier

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451648309 ## tests/catalog/test_sql.py: ## @@ -87,6 +88,20 @@ def catalog_sqlite(warehouse: Path) -> Generator[SqlCatalog, None, None]: catalog.destroy_tables() +@p

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1451397678 ## tests/catalog/test_sql.py: ## @@ -87,6 +88,20 @@ def catalog_sqlite(warehouse: Path) -> Generator[SqlCatalog, None, None]: catalog.destroy_tables() +@p

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449849825 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449849825 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449812309 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449807335 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449806795 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] Add SqlCatalog _commit_table support [iceberg-python]

HonahX commented on code in PR #265: URL: https://github.com/apache/iceberg-python/pull/265#discussion_r1449791012 ## pyiceberg/catalog/sql.py: ## @@ -329,8 +330,46 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

[PR] Add SqlCatalog _commit_table support [iceberg-python]

syun64 opened a new pull request, #265: URL: https://github.com/apache/iceberg-python/pull/265 https://github.com/apache/iceberg-python/issues/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to