Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-22 Thread via GitHub
nastra merged PR #10023: URL: https://github.com/apache/iceberg/pull/10023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-21 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1574204162 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { } priv

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1572637783 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { }

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-16 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1567311373 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { } priv

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-16 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1567311373 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { } priv

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-09 Thread via GitHub
amogh-jahagirdar commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1558676985 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { }

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-09 Thread via GitHub
amogh-jahagirdar commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1558672872 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) { }

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-03-22 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1535671891 ## api/src/test/java/org/apache/iceberg/util/TestCharSequenceWrapper.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-03-22 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1535670174 ## api/src/main/java/org/apache/iceberg/types/JavaHashes.java: ## @@ -26,6 +26,10 @@ public class JavaHashes { private JavaHashes() {} public static int hashCo

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-03-22 Thread via GitHub
nastra commented on code in PR #10023: URL: https://github.com/apache/iceberg/pull/10023#discussion_r1535663017 ## api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java: ## @@ -67,7 +78,13 @@ public boolean equals(Object other) { @Override public int hashCod

[PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-03-22 Thread via GitHub
nastra opened a new pull request, #10023: URL: https://github.com/apache/iceberg/pull/10023 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m