Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

slessard commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1720293723 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java: ## @@ -262,6 +263,89 @@ public void testReadColumnFilter2() throws Exception {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

slessard commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1753042474 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java: ## @@ -262,6 +263,89 @@ public void testReadColumnFilter2() throws Exception {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

slessard commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1753034022 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java: ## @@ -262,6 +264,111 @@ public void testReadColumnFilter2() throws Exception {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1751658615 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java: ## @@ -262,6 +264,111 @@ public void testReadColumnFilter2() throws Exception {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1751657930 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java: ## @@ -140,12 +141,16 @@ public static class ConstantVectorHolder extends VectorHolder {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

slessard commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1750566040 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java: ## @@ -262,6 +264,111 @@ public void testReadColumnFilter2() throws Exception {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1749998444 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1749997916 ## arrow/src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1749992612 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java: ## @@ -140,14 +141,16 @@ public static class ConstantVectorHolder extends VectorHolder {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

sl255051 commented on PR #10953: URL: https://github.com/apache/iceberg/pull/10953#issuecomment-2307968000 Thank you, Eduard, for your help. I will be on vacation next week. I will pick this up again when I return on September 3. -Steve Lessard From: Eduard Tudenhoefner ***

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1726810395 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java: ## @@ -463,12 +460,16 @@ public static VectorizedArrowReader positionsWithSetAr

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1726803463 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java: ## @@ -244,6 +248,18 @@ public final boolean getBoolean(int rowId) {

Re: [PR] DRAFT - Issue 10275 - Reward support for nulls [iceberg]

nastra commented on code in PR #10953: URL: https://github.com/apache/iceberg/pull/10953#discussion_r1726800757 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java: ## @@ -220,8 +221,11 @@ private ArrowVectorAccessor getPlai }