pvary merged PR #10207:
URL: https://github.com/apache/iceberg/pull/10207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580860665
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn =
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580202486
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn =
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580202486
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn =
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578865383
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java:
##
@@ -48,7 +48,9 @@
import org.junit.jupiter.api.AfterEach;
import
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578858474
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn =
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578850573
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -155,6 +155,13 @@ private void validate() {
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578677929
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java:
##
@@ -48,7 +48,9 @@
import org.junit.jupiter.api.AfterEach;
import
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578672004
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -155,6 +155,13 @@ private void validate() {
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1577703711
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -155,6 +155,13 @@ private void validate() {
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1576658083
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -155,6 +155,13 @@ private void validate() {
stevenzwu commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1576603768
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -155,6 +155,13 @@ private void validate() {
12 matches
Mail list logo