nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2189554813
Thanks a lot @szehon-ho .
> hi, @nk1506 thanks for ping, ill look at this, but just FYI, when I look a
few times back this patch seems a bit far, it adds things like
szehon-ho commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2189510488
hi, @nk1506 thanks for ping, ill look at this, but just FYI, when I look a
few times back this patch seems a bit far, it adds things like
ViewAwareTableBuilder and
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579326259
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579323906
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579292821
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -209,11 +262,58 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579255109
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579215950
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579198316
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,395 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1578924531
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,395 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1578904316
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -152,6 +173,38 @@ public List listTables(Namespace
namespace) {
}
}
+
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577368517
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577355581
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577351385
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577350170
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1576411506
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2056983641
Hi @szehon-ho / @pvary / @nastra ,
Please take a look .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560434336
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560477166
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,395 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560434336
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560433436
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560432153
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vteja11 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560368628
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 closed pull request #8907: Hive: Add View support for HIVE catalog
URL: https://github.com/apache/iceberg/pull/8907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nk1506 commented on PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#issuecomment-2037749273
Closing this PR as same has been addressed with ongoing
[PR](https://github.com/apache/iceberg/pull/9852) .
--
This is an automated message from the Apache Git Service.
To respond to
nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2034389989
@szehon-ho / @nastra , Please let me know if there are any comments left .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1542729687
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1542321268
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541896158
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541864321
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541864321
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541854460
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541619872
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541619023
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541618026
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541613871
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1540493957
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539932982
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539907379
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539276798
##
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##
@@ -59,7 +59,7 @@ public abstract class ViewCatalogTests
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539275723
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -85,6 +85,22 @@ default Integer currentSchemaId() {
@Nullable
String
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538653347
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539222675
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -191,6 +191,10 @@ protected void doCommit(TableMetadata base, TableMetadata
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539216264
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -113,6 +124,16 @@ public void initialize(String inputName, Map properties) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539213080
##
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##
@@ -59,7 +59,7 @@ public abstract class
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539210409
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -85,6 +85,22 @@ default Integer currentSchemaId() {
@Nullable
String
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538653347
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538017237
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538017237
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1535409457
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -76,10 +159,10 @@ default boolean exposeInHmsProperties() {
return
nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2006601809
This PR is looking meshy with all the refactor changes. I have moved the
common code for table view with this new
[PR](https://github.com/apache/iceberg/pull/10001) . This PR can go as
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528270018
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -113,6 +124,24 @@ public void initialize(String inputName, Map properties) {
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528265184
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528257514
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528253765
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528242070
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -222,53 +231,203 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527865180
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -113,6 +124,24 @@ public void initialize(String inputName, Map properties) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527421375
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527420981
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527420651
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,474 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527420076
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,474 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527419265
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java:
##
@@ -0,0 +1,474 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526482900
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -222,53 +231,203 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge)
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526478953
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +264,220 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526468355
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -269,6 +284,160 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526465824
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -269,6 +284,160 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526457958
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1526455990
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -166,168 +161,33 @@ protected void doRefresh() {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1522568230
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520927889
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from,
TableIdentifier
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520888231
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +296,214 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520875974
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +264,220 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520828123
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
pvary commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520469971
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520424415
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520424415
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520440313
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +264,220 @@ default Table newHmsTable(String hmsTableOwner) {
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520430836
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -222,24 +220,144 @@ public boolean dropTable(TableIdentifier identifier,
boolean
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520204263
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520204263
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String
nastra commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-1988556545
> @nastra build is failing because of following reason: `Error: The log was
not found. It may have been deleted based on retention settings.`
>
> Ref:
nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-1988285382
@nastra build is failing because of following reason:
`Error: The log was not found. It may have been deleted based on retention
settings.`
Ref:
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1519276012
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String
pvary commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1519220818
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1519191056
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +264,220 @@ default Table newHmsTable(String hmsTableOwner) {
nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1519153254
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1518485878
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1518485878
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1518485878
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1518485714
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1518485623
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1517329880
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516670655
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516670655
##
core/src/main/java/org/apache/iceberg/BaseMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516394903
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) {
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516386673
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -139,18 +222,33 @@ static StorageDescriptor storageDescriptor(TableMetadata
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516381489
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -139,18 +222,33 @@ static StorageDescriptor storageDescriptor(TableMetadata
nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516379316
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String
1 - 100 of 281 matches
Mail list logo