github-actions[bot] commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-2424318564
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] closed pull request #9461: Hive: Refactor hive-table commit
operation to be used for other operations like view
URL: https://github.com/apache/iceberg/pull/9461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-2408754956
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1481156673
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -166,153 +163,58 @@ protected void doRefresh() {
refreshFromMetadataLocation
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1481156673
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -166,153 +163,58 @@ protected void doRefresh() {
refreshFromMetadataLocation
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1480936905
##
core/src/main/java/org/apache/iceberg/util/MetastoreOperationsUtil.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1480936118
##
core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
nk1506 commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-1929402938
> Hi , I am sorry for the late reply.
>
> I left some more comments and explanations of preivous comments.
>
> I am also now thinking, whether it makes sense to have a common i
szehon-ho commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1479132215
##
core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1468275853
##
core/src/main/java/org/apache/iceberg/util/MetastoreOperationsUtil.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1467006116
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +300,19 @@ protected enum CommitStatus {
* @return Commit Status of Succ
nk1506 commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-1905385023
@szehon-ho With issue https://github.com/apache/iceberg/issues/9514 we are
discussing what would be the best approach to handle this? We have not
concluded on anything yet which is why thi
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1454918307
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +300,19 @@ protected enum CommitStatus {
* @return Commit Status of Success
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1449959948
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -181,4 +213,136 @@ default Table newHmsTable(String hmsTableOwner) {
return
nk1506 commented on code in PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#discussion_r1449952807
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -166,153 +164,58 @@ protected void doRefresh() {
refreshFromMetadataLocation
nk1506 commented on PR #9461:
URL: https://github.com/apache/iceberg/pull/9461#issuecomment-1888541095
cc: @pvary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
nk1506 opened a new pull request, #9461:
URL: https://github.com/apache/iceberg/pull/9461
Ref: https://github.com/apache/iceberg/pull/8907#discussion_r1441986754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
17 matches
Mail list logo
