Re: [PR] minor: Fix `double` API doc typo [iceberg-rust]

2024-03-02 Thread via GitHub
viirya commented on code in PR #226: URL: https://github.com/apache/iceberg-rust/pull/226#discussion_r1510017267 ## crates/iceberg/src/spec/values.rs: ## @@ -265,7 +265,7 @@ impl Datum { } } -/// Creates a date in `%Y-%m-%d` format, assume in utc timezone. +

Re: [PR] minor: Fix `double` API doc typo [iceberg-rust]

2024-03-02 Thread via GitHub
viirya commented on code in PR #226: URL: https://github.com/apache/iceberg-rust/pull/226#discussion_r1510017188 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -171,13 +171,13 @@ pub enum PrimitiveType { Int, /// 64-bit signed integer Long, -/// 32-bit IEEE

Re: [PR] minor: Fix `double` API doc typo [iceberg-rust]

2024-03-02 Thread via GitHub
viirya commented on code in PR #226: URL: https://github.com/apache/iceberg-rust/pull/226#discussion_r1510017188 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -171,13 +171,13 @@ pub enum PrimitiveType { Int, /// 64-bit signed integer Long, -/// 32-bit IEEE

[PR] minor: Fix `double` API doc typo [iceberg-rust]

2024-03-02 Thread via GitHub
viirya opened a new pull request, #226: URL: https://github.com/apache/iceberg-rust/pull/226 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,