[jira] [Commented] (KYLIN-5279) Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.

2022-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624194#comment-17624194 ] ASF GitHub Bot commented on KYLIN-5279: --- hit-lacus commented on PR #2001: URL: http

[GitHub] [kylin] hit-lacus commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.

2022-10-25 Thread GitBox
hit-lacus commented on PR #2001: URL: https://github.com/apache/kylin/pull/2001#issuecomment-1291530344 LGTM, I will merge it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (KYLIN-5279) Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.

2022-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623830#comment-17623830 ] ASF GitHub Bot commented on KYLIN-5279: --- zznlime commented on PR #2001: URL: https:

[GitHub] [kylin] zznlime commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.

2022-10-25 Thread GitBox
zznlime commented on PR #2001: URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290563309 Thanks for the suggestion! Have remove the config 'kylin.query.asc-order-null-first-enable', and reuse KylinConfigBase#getCalciteExtrasProperties for setting default null collation.

[jira] [Commented] (KYLIN-5280) Introduce memcached as a distributed query cache for Kylin5

2022-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623636#comment-17623636 ] ASF GitHub Bot commented on KYLIN-5280: --- hit-lacus commented on PR #2002: URL: http

[GitHub] [kylin] hit-lacus commented on pull request #2002: KYLIN-5280 Introduce memcached as a distributed cache for queries for Kylin5

2022-10-25 Thread GitBox
hit-lacus commented on PR #2002: URL: https://github.com/apache/kylin/pull/2002#issuecomment-1290145746 After check, I have following commnets: 1. Looks like a lot of configuration entries is hard-coded in `MemcachedCacheConfig`, such as `timeout`, do they really not need be configur

[jira] [Updated] (KYLIN-5283) JobWorker execute方法无法捕获原始异常

2022-10-25 Thread huangsheng (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huangsheng updated KYLIN-5283: -- Priority: Critical (was: Major) > JobWorker execute方法无法捕获原始异常 > --- > >

[jira] [Created] (KYLIN-5283) JobWorker execute方法无法捕获原始异常

2022-10-25 Thread huangsheng (Jira)
huangsheng created KYLIN-5283: - Summary: JobWorker execute方法无法捕获原始异常 Key: KYLIN-5283 URL: https://issues.apache.org/jira/browse/KYLIN-5283 Project: Kylin Issue Type: Bug Components: Job