[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-09-23 Thread liyang (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177604#comment-16177604 ] liyang commented on KYLIN-2718: --- Commit merged with slight modification according to latest master. Thanks

[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-08-02 Thread Zhong Yanghong (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110458#comment-16110458 ] Zhong Yanghong commented on KYLIN-2718: --- Thanks [~liyang.g...@gmail.com]'s comments. Now overflow

[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-07-21 Thread liyang (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095941#comment-16095941 ] liyang commented on KYLIN-2718: --- I could make a simple LongOverflowDetector that checks a long keeps

[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-07-17 Thread Zhong Yanghong (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091000#comment-16091000 ] Zhong Yanghong commented on KYLIN-2718: --- Is there an easy way to catch the long overflow? And should

[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-07-11 Thread Zhong Yanghong (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082322#comment-16082322 ] Zhong Yanghong commented on KYLIN-2718: --- Thanks. Could you help review this patch together?:) >

[jira] [Commented] (KYLIN-2718) overflow when calculating combination amount based on static rules

2017-07-10 Thread Zhong Yanghong (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081480#comment-16081480 ] Zhong Yanghong commented on KYLIN-2718: --- [~yangli907], could you help have a check of this patch