[GitHub] [lucene-solr] janhoy commented on issue #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin

2020-03-18 Thread GitBox
janhoy commented on issue #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-600921994 Thanks for the contribution. I think your implementation is correct, and should be aimed at v9, i.e. master branch only.

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

2020-03-18 Thread GitBox
mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394707461 ## File path:

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

2020-03-18 Thread GitBox
mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394705034 ## File path:

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

2020-03-18 Thread GitBox
mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394707206 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394683505 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java ## @@

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394671963 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -201,20

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394676728 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -223,44

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394677039 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -201,20

[jira] [Commented] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062095#comment-17062095 ] Mike Drob commented on LUCENE-9170: --- I've run into this as well on master. Instead of hardcoding the

[jira] [Created] (SOLR-14349) Upgrade to slf4j 2x when available and encourage using lambdas for expensive methods called in log statements.

2020-03-18 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14349: - Summary: Upgrade to slf4j 2x when available and encourage using lambdas for expensive methods called in log statements. Key: SOLR-14349 URL:

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394663323 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394663323 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394663323 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394659789 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394656108 ## File path:

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-18 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r394655989 ## File path:

[jira] [Commented] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

2020-03-18 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062078#comment-17062078 ] Lucene/Solr QA commented on SOLR-14348: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-14325) Core status could be improved to not require an IndexSearcher

2020-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062022#comment-17062022 ] David Smiley commented on SOLR-14325: - I think the central problem here is that we can't be sure the

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

2020-03-18 Thread GitBox
mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394589235 ## File path:

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

2020-03-18 Thread GitBox
mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394591134 ## File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java

[jira] [Commented] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062010#comment-17062010 ] Lucene/Solr QA commented on SOLR-14345: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-14347) Autoscaling placement wrong due to incorrect LockLevel for collection modifications

2020-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062007#comment-17062007 ] David Smiley commented on SOLR-14347: - I wonder if we should not take this approach and instead

[jira] [Commented] (SOLR-14347) Autoscaling placement wrong due to incorrect LockLevel for collection modifications

2020-03-18 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061971#comment-17061971 ] Andrzej Bialecki commented on SOLR-14347: - This patch seems to fix SOLR-13884, too. >

[jira] [Commented] (SOLR-13884) Concurrent collection creation leads to multiple replicas placed on same node

2020-03-18 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061970#comment-17061970 ] Andrzej Bialecki commented on SOLR-13884: - See also SOLR-14347, this test passes when the fix in

[jira] [Commented] (SOLR-14325) Core status could be improved to not require an IndexSearcher

2020-03-18 Thread Richard Goodman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061939#comment-17061939 ] Richard Goodman commented on SOLR-14325: Hi David, we noticed the following when trying to

[jira] [Comment Edited] (SOLR-13768) Remove support for deprecated 'requireSub' parameter in JWTAuthPlugin

2020-03-18 Thread Rabi Kumar K C (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061890#comment-17061890 ] Rabi Kumar K C edited comment on SOLR-13768 at 3/18/20, 5:27 PM: - Hi

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061927#comment-17061927 ] Dawid Weiss commented on LUCENE-9281: - Yes, this looks good too. > Retire SPIClassIterator from

[jira] [Commented] (SOLR-13768) Remove support for deprecated 'requireSub' parameter in JWTAuthPlugin

2020-03-18 Thread Rabi Kumar K C (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061890#comment-17061890 ] Rabi Kumar K C commented on SOLR-13768: --- Hi [~janhoy] I was just going through JWTAuthPlugin class

[jira] [Commented] (LUCENE-9283) DelimitedBoostTokenFilter can fail testRandomChains

2020-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061878#comment-17061878 ] David Smiley commented on LUCENE-9283: -- Yes, remove in TestRandomChains for consistency with the

[GitHub] [lucene-solr] ravowlga123 opened a new pull request #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin

2020-03-18 Thread GitBox
ravowlga123 opened a new pull request #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin URL: https://github.com/apache/lucene-solr/pull/1362 # Description As per ticket [SOLR-13768](https://jira.apache.org/jira/browse/SOLR-13768) we need to remove support for deprecated

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061797#comment-17061797 ] Tomoko Uchida commented on LUCENE-9281: --- I am fine with the changes. > Retire SPIClassIterator

[jira] [Commented] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061787#comment-17061787 ] Munendra S N commented on SOLR-14348: - [^SOLR-14348.patch] This patch splits {{TestJsonFacets}}

[jira] [Updated] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14348: Status: Patch Available (was: Open) > Split TestJsonFacets to multiple Test Classes >

[jira] [Updated] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14348: Attachment: SOLR-14348.patch > Split TestJsonFacets to multiple Test Classes >

[jira] [Created] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

2020-03-18 Thread Munendra S N (Jira)
Munendra S N created SOLR-14348: --- Summary: Split TestJsonFacets to multiple Test Classes Key: SOLR-14348 URL: https://issues.apache.org/jira/browse/SOLR-14348 Project: Solr Issue Type: Test

[jira] [Assigned] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14345: --- Assignee: Munendra S N > Error messages are not properly propagated with non-default

[jira] [Updated] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14345: Status: Patch Available (was: Open) > Error messages are not properly propagated with non-default

[jira] [Commented] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061781#comment-17061781 ] Munendra S N commented on SOLR-14345: - [^SOLR-14345.patch] This handles both Http/Http2 clients >

[jira] [Updated] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14345: Attachment: SOLR-14345.patch > Error messages are not properly propagated with non-default

[jira] [Updated] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9281: -- Description: We currently have our own implementation of the service loader standard (SPI)

[jira] [Commented] (SOLR-14340) ZkStateReader.readConfigName is doing too much work

2020-03-18 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061758#comment-17061758 ] Erick Erickson commented on SOLR-14340: --- [~dsmiley]  It's not an expensive test though. True, I

[jira] [Comment Edited] (SOLR-14034) remove deprecated min_rf references

2020-03-18 Thread Rabi Kumar K C (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061718#comment-17061718 ] Rabi Kumar K C edited comment on SOLR-14034 at 3/18/20, 2:00 PM: - Hi

[jira] [Commented] (SOLR-14034) remove deprecated min_rf references

2020-03-18 Thread Rabi Kumar K C (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061718#comment-17061718 ] Rabi Kumar K C commented on SOLR-14034: --- Hi [~cpoerschke] I am new to solr and want to work ontthis

[jira] [Updated] (SOLR-14347) Autoscaling placement wrong due to incorrect LockLevel for collection modifications

2020-03-18 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14347: Attachment: SOLR-14347.patch > Autoscaling placement wrong due to incorrect LockLevel for

[jira] [Created] (SOLR-14347) Autoscaling placement wrong due to incorrect LockLevel for collection modifications

2020-03-18 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-14347: --- Summary: Autoscaling placement wrong due to incorrect LockLevel for collection modifications Key: SOLR-14347 URL: https://issues.apache.org/jira/browse/SOLR-14347

[jira] [Commented] (SOLR-14343) Properly set initCapacity in NamedList

2020-03-18 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061682#comment-17061682 ] Lucene/Solr QA commented on SOLR-14343: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061679#comment-17061679 ] Uwe Schindler commented on LUCENE-9281: --- FYI, I moved the

[GitHub] [lucene-solr] s1monw opened a new pull request #1361: LUCENE-8118: Throw exception if DWPT grows beyond it's maximum ram limit

2020-03-18 Thread GitBox
s1monw opened a new pull request #1361: LUCENE-8118: Throw exception if DWPT grows beyond it's maximum ram limit URL: https://github.com/apache/lucene-solr/pull/1361 Today if you add documents that cause a single DWPT to grow beyond its maximum ram buffer size we just keep on indexing. If

[jira] [Resolved] (SOLR-14256) Remove HashDocSet

2020-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14256. - Resolution: Fixed > Remove HashDocSet > - > > Key: SOLR-14256 >

[jira] [Commented] (SOLR-14296) Update netty to 4.1.47

2020-03-18 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061675#comment-17061675 ] Erick Erickson commented on SOLR-14296: --- Thanks [~dweiss] , that's a good thing to know about. Once

[GitHub] [lucene-solr] dsmiley commented on issue #1358: SOLR-14256: replaced EMPTY with empty() to fix deadlock

2020-03-18 Thread GitBox
dsmiley commented on issue #1358: SOLR-14256: replaced EMPTY with empty() to fix deadlock URL: https://github.com/apache/lucene-solr/pull/1358#issuecomment-600595629 Merged: 4fd96bedc27adff61f3487539adbd67011181b90 This is

[GitHub] [lucene-solr] dsmiley closed pull request #1358: SOLR-14256: replaced EMPTY with empty() to fix deadlock

2020-03-18 Thread GitBox
dsmiley closed pull request #1358: SOLR-14256: replaced EMPTY with empty() to fix deadlock URL: https://github.com/apache/lucene-solr/pull/1358 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-14256) Remove HashDocSet

2020-03-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061673#comment-17061673 ] ASF subversion and git services commented on SOLR-14256: Commit

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061670#comment-17061670 ] Uwe Schindler commented on LUCENE-9281: --- I opened a Github Pull Request using my idea. I did not

[GitHub] [lucene-solr] uschindler opened a new pull request #1360: LUCENE-9281: First mockup of SPIClassIterator retirement

2020-03-18 Thread GitBox
uschindler opened a new pull request #1360: LUCENE-9281: First mockup of SPIClassIterator retirement URL: https://github.com/apache/lucene-solr/pull/1360 See https://issues.apache.org/jira/browse/LUCENE-9281 for more details: We currently have our own implementation of the service

[jira] [Comment Edited] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061644#comment-17061644 ] maoxiajun edited comment on SOLR-14346 at 3/18/20, 12:11 PM: - seems method

[jira] [Comment Edited] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061651#comment-17061651 ] Uwe Schindler edited comment on LUCENE-9281 at 3/18/20, 11:44 AM: --

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061651#comment-17061651 ] Uwe Schindler commented on LUCENE-9281: --- Another option 3) We can also simply add the no-arg ctor

[jira] [Commented] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061644#comment-17061644 ] maoxiajun commented on SOLR-14346: -- find out method *checkAZombieServer* in *LBSolrClient* not working

[jira] [Comment Edited] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061644#comment-17061644 ] maoxiajun edited comment on SOLR-14346 at 3/18/20, 11:31 AM: - seems method

[jira] [Updated] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoxiajun updated SOLR-14346: - Environment: solr: 8.3.1 (not cloud mode) java: 1.8.0_191 os: centos 7 was: solr: 8.3.1 java:

[jira] [Updated] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoxiajun updated SOLR-14346: - Description: solr version: 8.3.1 steps to reappear: step1: configured LbHttpSolrClient whith

[jira] [Created] (SOLR-14346) Solr fails to check zombie server in LbHttpSolrClient

2020-03-18 Thread maoxiajun (Jira)
maoxiajun created SOLR-14346: Summary: Solr fails to check zombie server in LbHttpSolrClient Key: SOLR-14346 URL: https://issues.apache.org/jira/browse/SOLR-14346 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394213103 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394217885 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394215894 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394194718 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394214819 ## File path:

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-18 Thread GitBox
jimczi commented on a change in pull request #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#discussion_r394218121 ## File path:

[jira] [Commented] (LUCENE-9283) DelimitedBoostTokenFilter can fail testRandomChains

2020-03-18 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061547#comment-17061547 ] Alan Woodward commented on LUCENE-9283: --- {code} 20:39:23[junit4] Suite:

[jira] [Created] (LUCENE-9283) DelimitedBoostTokenFilter can fail testRandomChains

2020-03-18 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9283: - Summary: DelimitedBoostTokenFilter can fail testRandomChains Key: LUCENE-9283 URL: https://issues.apache.org/jira/browse/LUCENE-9283 Project: Lucene - Core

[jira] [Created] (LUCENE-9282) Surround query parser's Query instances accumulate clause count on rewrite() causing TooManyBasicQueries and hashCode/equals changes

2020-03-18 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9282: --- Summary: Surround query parser's Query instances accumulate clause count on rewrite() causing TooManyBasicQueries and hashCode/equals changes Key: LUCENE-9282 URL:

[jira] [Commented] (SOLR-14341) Move a collection's configSet name to state.json

2020-03-18 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061521#comment-17061521 ] Jan Høydahl commented on SOLR-14341: +1 While ZK allows a znode to both have data and children,

[jira] [Commented] (LUCENE-9281) Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

2020-03-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061488#comment-17061488 ] Dawid Weiss commented on LUCENE-9281: - I see two possibilities: 1) A cleaner and more reasonable

[jira] [Commented] (SOLR-14296) Update netty to 4.1.47

2020-03-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061480#comment-17061480 ] Dawid Weiss commented on SOLR-14296: {quote}bq. Curiously, the gradle version was 4.1.45, not sure

[jira] [Commented] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061433#comment-17061433 ] Munendra S N commented on SOLR-14345: - [^SOLR-14345.patch] Initial patch bit hacky * Works with

[jira] [Updated] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14345: Attachment: SOLR-14345.patch > Error messages are not properly propagated with non-default

[jira] [Created] (SOLR-14345) Error messages are not properly propagated with non-default response parsers

2020-03-18 Thread Munendra S N (Jira)
Munendra S N created SOLR-14345: --- Summary: Error messages are not properly propagated with non-default response parsers Key: SOLR-14345 URL: https://issues.apache.org/jira/browse/SOLR-14345 Project: